All of lore.kernel.org
 help / color / mirror / Atom feed
From: JeffyChen <jeffy.chen@rock-chips.com>
To: Will Deacon <will.deacon@arm.com>, Joerg Roedel <joro@8bytes.org>
Cc: linux-kernel@vger.kernel.org, jcliang@chromium.org,
	tfiga@chromium.org, iommu@lists.linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones
Date: Thu, 18 Jan 2018 22:58:23 +0800	[thread overview]
Message-ID: <5A60B60F.6040602@rock-chips.com> (raw)
In-Reply-To: <20180118144118.GA12394@arm.com>

Hi Will,

Thanks for your reply.

On 01/18/2018 10:41 PM, Will Deacon wrote:
>> >
>> >Makes sense to me, but I'd like to have an OK from Robin or Will (added
>> >to Cc) before applying this.
> I don't think this patch makes a lot of sense in isolation: the SMMU drivers
> themselves will likely still probe, and it's unclear what we should about
> DMA when an IOMMU is not deemed to be available. See:
>
> https://patchwork.kernel.org/patch/9681211/
>
> Jeffy -- are you solving a real issue here, or is this just an attempt at
> some cleanup?

hmmm, it's just a cleanup, but it seems like we already removed this 
of_iommu_init_fn in:
b0c560f7d8a4 iommu: Clean up of_iommu_init_fn

so this patch can be disregarded too :)
>
> Will
>
>
>

WARNING: multiple messages have this Message-ID (diff)
From: JeffyChen <jeffy.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
	Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] iommu/of: Only do IOMMU lookup for available ones
Date: Thu, 18 Jan 2018 22:58:23 +0800	[thread overview]
Message-ID: <5A60B60F.6040602@rock-chips.com> (raw)
In-Reply-To: <20180118144118.GA12394-5wv7dgnIgG8@public.gmane.org>

Hi Will,

Thanks for your reply.

On 01/18/2018 10:41 PM, Will Deacon wrote:
>> >
>> >Makes sense to me, but I'd like to have an OK from Robin or Will (added
>> >to Cc) before applying this.
> I don't think this patch makes a lot of sense in isolation: the SMMU drivers
> themselves will likely still probe, and it's unclear what we should about
> DMA when an IOMMU is not deemed to be available. See:
>
> https://patchwork.kernel.org/patch/9681211/
>
> Jeffy -- are you solving a real issue here, or is this just an attempt at
> some cleanup?

hmmm, it's just a cleanup, but it seems like we already removed this 
of_iommu_init_fn in:
b0c560f7d8a4 iommu: Clean up of_iommu_init_fn

so this patch can be disregarded too :)
>
> Will
>
>
>

  reply	other threads:[~2018-01-18 14:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-03  6:09 [PATCH] iommu/of: Only do IOMMU lookup for available ones Jeffy Chen
2018-01-08 11:45 ` Robin Murphy
2018-01-08 11:45   ` Robin Murphy
2018-01-17 13:28 ` Joerg Roedel
2018-01-18 14:41   ` Will Deacon
2018-01-18 14:41     ` Will Deacon
2018-01-18 14:58     ` JeffyChen [this message]
2018-01-18 14:58       ` JeffyChen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5A60B60F.6040602@rock-chips.com \
    --to=jeffy.chen@rock-chips.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jcliang@chromium.org \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=tfiga@chromium.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.