From: Lu Baolu <baolu.lu@linux.intel.com> To: "Liu, Yi L" <yi.l.liu@intel.com>, David Woodhouse <dwmw2@infradead.org>, Joerg Roedel <joro@8bytes.org> Cc: "Raj, Ashok" <ashok.raj@intel.com>, "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>, "Pan, Jacob jun" <jacob.jun.pan@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>, "Sun, Yi Y" <yi.y.sun@intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Jacob Pan <jacob.jun.pan@linux.intel.com> Subject: Re: [PATCH 6/9] iommu/vt-d: Allocate and free pasid table Date: Wed, 2 May 2018 11:09:45 +0800 [thread overview] Message-ID: <5AE92BF9.2090106@linux.intel.com> (raw) In-Reply-To: <A2975661238FB949B60364EF0F2C257439BE752C@SHSMSX104.ccr.corp.intel.com> Hi, On 05/01/2018 05:22 PM, Liu, Yi L wrote: >> From: Lu Baolu [mailto:baolu.lu@linux.intel.com] >> Sent: Tuesday, April 17, 2018 11:03 AM >> >> This patch allocates PASID table for a domain at the time when >> it is being created (if any devices using this domain supports >> PASID feature), and free it when the domain is freed. >> >> Cc: Ashok Raj <ashok.raj@intel.com> >> Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> >> Cc: Kevin Tian <kevin.tian@intel.com> >> Cc: Liu Yi L <yi.l.liu@intel.com> >> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> >> --- >> drivers/iommu/intel-iommu.c | 13 +++++++++++++ >> drivers/iommu/intel-svm.c | 8 -------- >> include/linux/intel-iommu.h | 10 ++++++++-- >> 3 files changed, 21 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c >> index caa0b5c..99c643b 100644 >> --- a/drivers/iommu/intel-iommu.c >> +++ b/drivers/iommu/intel-iommu.c >> @@ -2460,6 +2460,18 @@ static struct dmar_domain >> *dmar_insert_one_dev_info(struct intel_iommu *iommu, >> dev->archdata.iommu = info; >> spin_unlock_irqrestore(&device_domain_lock, flags); >> >> + if (dev && dev_is_pci(dev) && info->pasid_supported) { >> + if (pasid_enabled(iommu)) { >> + size_t size, count; >> + >> + size = sizeof(struct pasid_entry); >> + count = min_t(int, >> + pci_max_pasids(to_pci_dev(dev)), >> + intel_pasid_max_id); >> + ret = intel_pasid_alloc_table(dev, size, count); > No check for the return value? Nice catch. Will fix it in a v2. > >> + } >> + } >> + >> if (dev && domain_context_mapping(domain, dev)) { >> pr_err("Domain context map for %s failed\n", dev_name(dev)); >> dmar_remove_one_dev_info(domain, dev); >> @@ -4826,6 +4838,7 @@ static void dmar_remove_one_dev_info(struct >> dmar_domain *domain, >> unsigned long flags; >> >> spin_lock_irqsave(&device_domain_lock, flags); >> + intel_pasid_free_table(dev); >> info = dev->archdata.iommu; >> __dmar_remove_one_dev_info(info); >> spin_unlock_irqrestore(&device_domain_lock, flags); >> diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c >> index 24d0ea1..3abc94f 100644 >> --- a/drivers/iommu/intel-svm.c >> +++ b/drivers/iommu/intel-svm.c >> @@ -34,14 +34,6 @@ >> >> static irqreturn_t prq_event_thread(int irq, void *d); >> >> -struct pasid_entry { >> - u64 val; >> -}; >> - >> -struct pasid_state_entry { >> - u64 val; >> -}; >> - >> int intel_svm_alloc_pasid_tables(struct intel_iommu *iommu) >> { >> struct page *pages; >> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h >> index bee7a3f..08e5811 100644 >> --- a/include/linux/intel-iommu.h >> +++ b/include/linux/intel-iommu.h >> @@ -382,8 +382,14 @@ enum { >> #define VTD_FLAG_TRANS_PRE_ENABLED (1 << 0) >> #define VTD_FLAG_IRQ_REMAP_PRE_ENABLED (1 << 1) >> >> -struct pasid_entry; >> -struct pasid_state_entry; >> +struct pasid_entry { >> + u64 val; >> +}; >> + >> +struct pasid_state_entry { >> + u64 val; >> +}; >> + >> struct page_req_dsc; >> >> struct dmar_domain { > Overall, this patch looks good to me. But need to fix the comment above. > > Reviewed-by: Liu, Yi L <yi.l.liu@intel.com> > > Regards, > Yi Liu Sure. Best regards, Lu Baolu
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> To: "Liu, Yi L" <yi.l.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> Cc: "Raj, Ashok" <ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "Kumar, Sanjay K" <sanjay.k.kumar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" <iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "Sun, Yi Y" <yi.y.sun-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "Pan, Jacob jun" <jacob.jun.pan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Subject: Re: [PATCH 6/9] iommu/vt-d: Allocate and free pasid table Date: Wed, 2 May 2018 11:09:45 +0800 [thread overview] Message-ID: <5AE92BF9.2090106@linux.intel.com> (raw) In-Reply-To: <A2975661238FB949B60364EF0F2C257439BE752C-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org> Hi, On 05/01/2018 05:22 PM, Liu, Yi L wrote: >> From: Lu Baolu [mailto:baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org] >> Sent: Tuesday, April 17, 2018 11:03 AM >> >> This patch allocates PASID table for a domain at the time when >> it is being created (if any devices using this domain supports >> PASID feature), and free it when the domain is freed. >> >> Cc: Ashok Raj <ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> >> Cc: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> >> Cc: Kevin Tian <kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> >> Cc: Liu Yi L <yi.l.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> >> Signed-off-by: Lu Baolu <baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> >> --- >> drivers/iommu/intel-iommu.c | 13 +++++++++++++ >> drivers/iommu/intel-svm.c | 8 -------- >> include/linux/intel-iommu.h | 10 ++++++++-- >> 3 files changed, 21 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c >> index caa0b5c..99c643b 100644 >> --- a/drivers/iommu/intel-iommu.c >> +++ b/drivers/iommu/intel-iommu.c >> @@ -2460,6 +2460,18 @@ static struct dmar_domain >> *dmar_insert_one_dev_info(struct intel_iommu *iommu, >> dev->archdata.iommu = info; >> spin_unlock_irqrestore(&device_domain_lock, flags); >> >> + if (dev && dev_is_pci(dev) && info->pasid_supported) { >> + if (pasid_enabled(iommu)) { >> + size_t size, count; >> + >> + size = sizeof(struct pasid_entry); >> + count = min_t(int, >> + pci_max_pasids(to_pci_dev(dev)), >> + intel_pasid_max_id); >> + ret = intel_pasid_alloc_table(dev, size, count); > No check for the return value? Nice catch. Will fix it in a v2. > >> + } >> + } >> + >> if (dev && domain_context_mapping(domain, dev)) { >> pr_err("Domain context map for %s failed\n", dev_name(dev)); >> dmar_remove_one_dev_info(domain, dev); >> @@ -4826,6 +4838,7 @@ static void dmar_remove_one_dev_info(struct >> dmar_domain *domain, >> unsigned long flags; >> >> spin_lock_irqsave(&device_domain_lock, flags); >> + intel_pasid_free_table(dev); >> info = dev->archdata.iommu; >> __dmar_remove_one_dev_info(info); >> spin_unlock_irqrestore(&device_domain_lock, flags); >> diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c >> index 24d0ea1..3abc94f 100644 >> --- a/drivers/iommu/intel-svm.c >> +++ b/drivers/iommu/intel-svm.c >> @@ -34,14 +34,6 @@ >> >> static irqreturn_t prq_event_thread(int irq, void *d); >> >> -struct pasid_entry { >> - u64 val; >> -}; >> - >> -struct pasid_state_entry { >> - u64 val; >> -}; >> - >> int intel_svm_alloc_pasid_tables(struct intel_iommu *iommu) >> { >> struct page *pages; >> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h >> index bee7a3f..08e5811 100644 >> --- a/include/linux/intel-iommu.h >> +++ b/include/linux/intel-iommu.h >> @@ -382,8 +382,14 @@ enum { >> #define VTD_FLAG_TRANS_PRE_ENABLED (1 << 0) >> #define VTD_FLAG_IRQ_REMAP_PRE_ENABLED (1 << 1) >> >> -struct pasid_entry; >> -struct pasid_state_entry; >> +struct pasid_entry { >> + u64 val; >> +}; >> + >> +struct pasid_state_entry { >> + u64 val; >> +}; >> + >> struct page_req_dsc; >> >> struct dmar_domain { > Overall, this patch looks good to me. But need to fix the comment above. > > Reviewed-by: Liu, Yi L <yi.l.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > Regards, > Yi Liu Sure. Best regards, Lu Baolu
next prev parent reply other threads:[~2018-05-02 3:09 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-17 3:03 [PATCH 0/9] iommu/vt-d: Improve PASID id and table management Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-04-17 3:03 ` [PATCH 1/9] iommu/vt-d: Global PASID name space Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-05-01 9:21 ` Liu, Yi L 2018-05-01 9:21 ` Liu, Yi L 2018-04-17 3:03 ` [PATCH 2/9] iommu/vt-d: Decouple idr bond pointer from svm Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-05-01 9:21 ` Liu, Yi L 2018-04-17 3:03 ` [PATCH 3/9] iommu/vt-d: Use global PASID for SVM usage Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-05-01 9:21 ` Liu, Yi L 2018-05-01 9:21 ` Liu, Yi L 2018-04-17 3:03 ` [PATCH 4/9] iommu/vt-d: Move device_domain_info to header Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-05-01 9:21 ` Liu, Yi L 2018-05-01 9:21 ` Liu, Yi L 2018-04-17 3:03 ` [PATCH 5/9] iommu/vt-d: Per domain pasid table interfaces Lu Baolu 2018-05-01 9:22 ` Liu, Yi L 2018-05-01 9:22 ` Liu, Yi L 2018-05-02 3:08 ` Lu Baolu 2018-05-02 3:08 ` Lu Baolu 2018-04-17 3:03 ` [PATCH 6/9] iommu/vt-d: Allocate and free pasid table Lu Baolu 2018-05-01 9:22 ` Liu, Yi L 2018-05-01 9:22 ` Liu, Yi L 2018-05-02 3:09 ` Lu Baolu [this message] 2018-05-02 3:09 ` Lu Baolu 2018-04-17 3:03 ` [PATCH 7/9] iommu/vt-d: Calculate PTS value Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-05-01 9:22 ` Liu, Yi L 2018-05-01 9:22 ` Liu, Yi L 2018-04-17 3:03 ` [PATCH 8/9] iommu/vt-d: Use per-domain pasid table Lu Baolu 2018-05-01 9:23 ` Liu, Yi L 2018-05-01 9:23 ` Liu, Yi L 2018-05-02 4:38 ` Lu Baolu 2018-05-02 4:38 ` Lu Baolu 2018-04-17 3:03 ` [PATCH 9/9] iommu/vt-d: Clean up PASID talbe management for SVM Lu Baolu 2018-05-01 9:24 ` Liu, Yi L 2018-05-01 9:24 ` Liu, Yi L 2018-05-02 4:43 ` Lu Baolu 2018-05-02 4:43 ` Lu Baolu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5AE92BF9.2090106@linux.intel.com \ --to=baolu.lu@linux.intel.com \ --cc=ashok.raj@intel.com \ --cc=dwmw2@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@intel.com \ --cc=jacob.jun.pan@linux.intel.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=sanjay.k.kumar@intel.com \ --cc=yi.l.liu@intel.com \ --cc=yi.y.sun@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.