From: "Liu, Yi L" <yi.l.liu@intel.com> To: Lu Baolu <baolu.lu@linux.intel.com>, David Woodhouse <dwmw2@infradead.org>, Joerg Roedel <joro@8bytes.org> Cc: "Raj, Ashok" <ashok.raj@intel.com>, "Kumar, Sanjay K" <sanjay.k.kumar@intel.com>, "Pan, Jacob jun" <jacob.jun.pan@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>, "Sun, Yi Y" <yi.y.sun@intel.com>, "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Jacob Pan <jacob.jun.pan@linux.intel.com> Subject: RE: [PATCH 7/9] iommu/vt-d: Calculate PTS value Date: Tue, 1 May 2018 09:22:31 +0000 [thread overview] Message-ID: <A2975661238FB949B60364EF0F2C257439BE753A@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <1523934202-21669-8-git-send-email-baolu.lu@linux.intel.com> > From: Lu Baolu [mailto:baolu.lu@linux.intel.com] > Sent: Tuesday, April 17, 2018 11:03 AM > > Calculate PTS (PASID Table Size) value for the extended > context entry from the real size of the PASID table for > a domain. > > Cc: Ashok Raj <ashok.raj@intel.com> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com> > Cc: Kevin Tian <kevin.tian@intel.com> > Cc: Liu Yi L <yi.l.liu@intel.com> > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> Looks good to me. Reviewed-by: Liu, Yi L <yi.l.liu@intel.com> Regards, Yi Liu > --- > drivers/iommu/intel-iommu.c | 22 ++++++++-------------- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c > index 99c643b..d4f9cea 100644 > --- a/drivers/iommu/intel-iommu.c > +++ b/drivers/iommu/intel-iommu.c > @@ -5146,22 +5146,16 @@ static void intel_iommu_put_resv_regions(struct device > *dev, > > #ifdef CONFIG_INTEL_IOMMU_SVM > #define MAX_NR_PASID_BITS (20) > -static inline unsigned long intel_iommu_get_pts(struct intel_iommu *iommu) > +static inline unsigned long intel_iommu_get_pts(struct dmar_domain *domain) > { > - /* > - * Convert ecap_pss to extend context entry pts encoding, also > - * respect the soft pasid_max value set by the iommu. > - * - number of PASID bits = ecap_pss + 1 > - * - number of PASID table entries = 2^(pts + 5) > - * Therefore, pts = ecap_pss - 4 > - * e.g. KBL ecap_pss = 0x13, PASID has 20 bits, pts = 15 > - */ > - if (ecap_pss(iommu->ecap) < 5) > + int pts; > + > + pts = find_first_bit((unsigned long *)&domain->max_pasid, > + MAX_NR_PASID_BITS); > + if (pts < 5) > return 0; > > - /* pasid_max is encoded as actual number of entries not the bits */ > - return find_first_bit((unsigned long *)&iommu->pasid_max, > - MAX_NR_PASID_BITS) - 5; > + return pts - 5; > } > > int intel_iommu_enable_pasid(struct intel_iommu *iommu, struct intel_svm_dev > *sdev) > @@ -5198,7 +5192,7 @@ int intel_iommu_enable_pasid(struct intel_iommu > *iommu, struct intel_svm_dev *sd > if (iommu->pasid_state_table) > context[1].hi = (u64)virt_to_phys(iommu- > >pasid_state_table); > context[1].lo = (u64)virt_to_phys(iommu->pasid_table) | > - intel_iommu_get_pts(iommu); > + intel_iommu_get_pts(domain); > > wmb(); > /* CONTEXT_TT_MULTI_LEVEL and CONTEXT_TT_DEV_IOTLB are > both > -- > 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: "Liu, Yi L" <yi.l.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> To: Lu Baolu <baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org> Cc: "Raj, Ashok" <ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "Kumar, Sanjay K" <sanjay.k.kumar-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" <iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "Sun, Yi Y" <yi.y.sun-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, "Pan, Jacob jun" <jacob.jun.pan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Subject: RE: [PATCH 7/9] iommu/vt-d: Calculate PTS value Date: Tue, 1 May 2018 09:22:31 +0000 [thread overview] Message-ID: <A2975661238FB949B60364EF0F2C257439BE753A@SHSMSX104.ccr.corp.intel.com> (raw) In-Reply-To: <1523934202-21669-8-git-send-email-baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> > From: Lu Baolu [mailto:baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org] > Sent: Tuesday, April 17, 2018 11:03 AM > > Calculate PTS (PASID Table Size) value for the extended > context entry from the real size of the PASID table for > a domain. > > Cc: Ashok Raj <ashok.raj-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > Cc: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> > Cc: Kevin Tian <kevin.tian-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > Cc: Liu Yi L <yi.l.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > Signed-off-by: Lu Baolu <baolu.lu-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Looks good to me. Reviewed-by: Liu, Yi L <yi.l.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Regards, Yi Liu > --- > drivers/iommu/intel-iommu.c | 22 ++++++++-------------- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c > index 99c643b..d4f9cea 100644 > --- a/drivers/iommu/intel-iommu.c > +++ b/drivers/iommu/intel-iommu.c > @@ -5146,22 +5146,16 @@ static void intel_iommu_put_resv_regions(struct device > *dev, > > #ifdef CONFIG_INTEL_IOMMU_SVM > #define MAX_NR_PASID_BITS (20) > -static inline unsigned long intel_iommu_get_pts(struct intel_iommu *iommu) > +static inline unsigned long intel_iommu_get_pts(struct dmar_domain *domain) > { > - /* > - * Convert ecap_pss to extend context entry pts encoding, also > - * respect the soft pasid_max value set by the iommu. > - * - number of PASID bits = ecap_pss + 1 > - * - number of PASID table entries = 2^(pts + 5) > - * Therefore, pts = ecap_pss - 4 > - * e.g. KBL ecap_pss = 0x13, PASID has 20 bits, pts = 15 > - */ > - if (ecap_pss(iommu->ecap) < 5) > + int pts; > + > + pts = find_first_bit((unsigned long *)&domain->max_pasid, > + MAX_NR_PASID_BITS); > + if (pts < 5) > return 0; > > - /* pasid_max is encoded as actual number of entries not the bits */ > - return find_first_bit((unsigned long *)&iommu->pasid_max, > - MAX_NR_PASID_BITS) - 5; > + return pts - 5; > } > > int intel_iommu_enable_pasid(struct intel_iommu *iommu, struct intel_svm_dev > *sdev) > @@ -5198,7 +5192,7 @@ int intel_iommu_enable_pasid(struct intel_iommu > *iommu, struct intel_svm_dev *sd > if (iommu->pasid_state_table) > context[1].hi = (u64)virt_to_phys(iommu- > >pasid_state_table); > context[1].lo = (u64)virt_to_phys(iommu->pasid_table) | > - intel_iommu_get_pts(iommu); > + intel_iommu_get_pts(domain); > > wmb(); > /* CONTEXT_TT_MULTI_LEVEL and CONTEXT_TT_DEV_IOTLB are > both > -- > 2.7.4
next prev parent reply other threads:[~2018-05-01 9:22 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-17 3:03 [PATCH 0/9] iommu/vt-d: Improve PASID id and table management Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-04-17 3:03 ` [PATCH 1/9] iommu/vt-d: Global PASID name space Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-05-01 9:21 ` Liu, Yi L 2018-05-01 9:21 ` Liu, Yi L 2018-04-17 3:03 ` [PATCH 2/9] iommu/vt-d: Decouple idr bond pointer from svm Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-05-01 9:21 ` Liu, Yi L 2018-04-17 3:03 ` [PATCH 3/9] iommu/vt-d: Use global PASID for SVM usage Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-05-01 9:21 ` Liu, Yi L 2018-05-01 9:21 ` Liu, Yi L 2018-04-17 3:03 ` [PATCH 4/9] iommu/vt-d: Move device_domain_info to header Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-05-01 9:21 ` Liu, Yi L 2018-05-01 9:21 ` Liu, Yi L 2018-04-17 3:03 ` [PATCH 5/9] iommu/vt-d: Per domain pasid table interfaces Lu Baolu 2018-05-01 9:22 ` Liu, Yi L 2018-05-01 9:22 ` Liu, Yi L 2018-05-02 3:08 ` Lu Baolu 2018-05-02 3:08 ` Lu Baolu 2018-04-17 3:03 ` [PATCH 6/9] iommu/vt-d: Allocate and free pasid table Lu Baolu 2018-05-01 9:22 ` Liu, Yi L 2018-05-01 9:22 ` Liu, Yi L 2018-05-02 3:09 ` Lu Baolu 2018-05-02 3:09 ` Lu Baolu 2018-04-17 3:03 ` [PATCH 7/9] iommu/vt-d: Calculate PTS value Lu Baolu 2018-04-17 3:03 ` Lu Baolu 2018-05-01 9:22 ` Liu, Yi L [this message] 2018-05-01 9:22 ` Liu, Yi L 2018-04-17 3:03 ` [PATCH 8/9] iommu/vt-d: Use per-domain pasid table Lu Baolu 2018-05-01 9:23 ` Liu, Yi L 2018-05-01 9:23 ` Liu, Yi L 2018-05-02 4:38 ` Lu Baolu 2018-05-02 4:38 ` Lu Baolu 2018-04-17 3:03 ` [PATCH 9/9] iommu/vt-d: Clean up PASID talbe management for SVM Lu Baolu 2018-05-01 9:24 ` Liu, Yi L 2018-05-01 9:24 ` Liu, Yi L 2018-05-02 4:43 ` Lu Baolu 2018-05-02 4:43 ` Lu Baolu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=A2975661238FB949B60364EF0F2C257439BE753A@SHSMSX104.ccr.corp.intel.com \ --to=yi.l.liu@intel.com \ --cc=ashok.raj@intel.com \ --cc=baolu.lu@linux.intel.com \ --cc=dwmw2@infradead.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jacob.jun.pan@intel.com \ --cc=jacob.jun.pan@linux.intel.com \ --cc=joro@8bytes.org \ --cc=kevin.tian@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=sanjay.k.kumar@intel.com \ --cc=yi.y.sun@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.