From: "Winkler, Tomas" <tomas.winkler@intel.com> To: Colin King <colin.king@canonical.com>, Arnd Bergmann <arnd@arndb.de>, "Greg Kroah-Hartman" <gregkh@linuxfoundation.org> Cc: "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH] mei: remove dev_err message on an unsupported ioctl Date: Tue, 27 Feb 2018 17:26:22 +0000 [thread overview] Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9422A4CC@hasmsx108.ger.corp.intel.com> (raw) In-Reply-To: <20180227162105.14113-1-colin.king@canonical.com> > > From: Colin Ian King <colin.king@canonical.com> > > Currently the driver spams the kernel log on unsupported ioctls which is > unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway. > I suspect this was originally for debugging purposes but it really is not > required so remove it. > This is rather strange as most of the legimit applications are using one IOCTL from kernel 3.0 Do you have any reference where this call is originated from, frankly this is the first time I got such complain. In any case it would be maybe better to change it a warn once call. Thanks Tomas > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/misc/mei/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index > 758dc73602d5..7bb013644aeb 100644 > --- a/drivers/misc/mei/main.c > +++ b/drivers/misc/mei/main.c > @@ -507,7 +507,6 @@ static long mei_ioctl(struct file *file, unsigned int > cmd, unsigned long data) > break; > > default: > - dev_err(dev->dev, ": unsupported ioctl %d.\n", cmd); > rets = -ENOIOCTLCMD; > } > > -- > 2.15.1
WARNING: multiple messages have this Message-ID (diff)
From: "Winkler, Tomas" <tomas.winkler@intel.com> To: Colin King <colin.king@canonical.com>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH] mei: remove dev_err message on an unsupported ioctl Date: Tue, 27 Feb 2018 17:26:22 +0000 [thread overview] Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9422A4CC@hasmsx108.ger.corp.intel.com> (raw) In-Reply-To: <20180227162105.14113-1-colin.king@canonical.com> PiANCj4gRnJvbTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCj4g DQo+IEN1cnJlbnRseSB0aGUgZHJpdmVyIHNwYW1zIHRoZSBrZXJuZWwgbG9nIG9uIHVuc3VwcG9y dGVkIGlvY3RscyB3aGljaCBpcw0KPiB1bm5lY2Vzc2FyeSBhcyB0aGUgaW9jdGwgcmV0dXJucyAt RU5PSU9DVExDTUQgdG8gaW5kaWNhdGUgdGhpcyBhbnl3YXkuDQo+IEkgc3VzcGVjdCB0aGlzIHdh cyBvcmlnaW5hbGx5IGZvciBkZWJ1Z2dpbmcgcHVycG9zZXMgYnV0IGl0IHJlYWxseSBpcyBub3QN Cj4gcmVxdWlyZWQgc28gcmVtb3ZlIGl0Lg0KPg0KDQpUaGlzIGlzIHJhdGhlciBzdHJhbmdlIGFz IG1vc3Qgb2YgdGhlIGxlZ2ltaXQgYXBwbGljYXRpb25zIGFyZSB1c2luZyBvbmUgSU9DVEwgZnJv bSBrZXJuZWwgMy4wDQpEbyB5b3UgaGF2ZSBhbnkgcmVmZXJlbmNlIHdoZXJlIHRoaXMgY2FsbCBp cyBvcmlnaW5hdGVkIGZyb20sIGZyYW5rbHkgdGhpcyBpcyB0aGUgZmlyc3QgdGltZSBJIGdvdCBz dWNoIGNvbXBsYWluLg0KDQpJbiBhbnkgY2FzZSBpdCB3b3VsZCBiZSBtYXliZSBiZXR0ZXIgdG8g Y2hhbmdlIGl0IGEgd2FybiBvbmNlIGNhbGwuDQogDQpUaGFua3MNClRvbWFzDQoNCj4gU2lnbmVk LW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCj4gLS0t DQo+ICBkcml2ZXJzL21pc2MvbWVpL21haW4uYyB8IDEgLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEg ZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21pc2MvbWVpL21haW4uYyBi L2RyaXZlcnMvbWlzYy9tZWkvbWFpbi5jIGluZGV4DQo+IDc1OGRjNzM2MDJkNS4uN2JiMDEzNjQ0 YWViIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL21pc2MvbWVpL21haW4uYw0KPiArKysgYi9kcml2 ZXJzL21pc2MvbWVpL21haW4uYw0KPiBAQCAtNTA3LDcgKzUwNyw2IEBAIHN0YXRpYyBsb25nIG1l aV9pb2N0bChzdHJ1Y3QgZmlsZSAqZmlsZSwgdW5zaWduZWQgaW50DQo+IGNtZCwgdW5zaWduZWQg bG9uZyBkYXRhKQ0KPiAgCQlicmVhazsNCj4gDQo+ICAJZGVmYXVsdDoNCj4gLQkJZGV2X2Vycihk ZXYtPmRldiwgIjogdW5zdXBwb3J0ZWQgaW9jdGwgJWQuXG4iLCBjbWQpOw0KPiAgCQlyZXRzID0g LUVOT0lPQ1RMQ01EOw0KPiAgCX0NCj4gDQo+IC0tDQo+IDIuMTUuMQ0KDQo
next prev parent reply other threads:[~2018-02-27 17:26 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-27 16:21 [PATCH] mei: remove dev_err message on an unsupported ioctl Colin King 2018-02-27 16:21 ` Colin King 2018-02-27 17:26 ` Winkler, Tomas [this message] 2018-02-27 17:26 ` Winkler, Tomas 2018-02-27 17:31 ` Colin Ian King 2018-02-27 21:47 ` Winkler, Tomas 2018-02-27 21:47 ` Winkler, Tomas 2018-02-27 18:10 ` Greg Kroah-Hartman 2018-02-27 18:10 ` Greg Kroah-Hartman 2018-02-27 21:44 ` Winkler, Tomas 2018-02-28 9:49 ` Greg Kroah-Hartman 2018-02-28 9:49 ` Greg Kroah-Hartman 2018-02-28 9:52 ` Winkler, Tomas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5B8DA87D05A7694D9FA63FD143655C1B9422A4CC@hasmsx108.ger.corp.intel.com \ --to=tomas.winkler@intel.com \ --cc=arnd@arndb.de \ --cc=colin.king@canonical.com \ --cc=gregkh@linuxfoundation.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.