All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Winkler, Tomas" <tomas.winkler@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Colin King <colin.king@canonical.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] mei: remove dev_err message on an unsupported ioctl
Date: Wed, 28 Feb 2018 09:52:42 +0000	[thread overview]
Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B9422AF6C@hasmsx108.ger.corp.intel.com> (raw)
In-Reply-To: <20180228094958.GA12946@kroah.com>

> 
> On Tue, Feb 27, 2018 at 09:44:41PM +0000, Winkler, Tomas wrote:
> > >
> > > On Tue, Feb 27, 2018 at 05:26:22PM +0000, Winkler, Tomas wrote:
> > > > >
> > > > > From: Colin Ian King <colin.king@canonical.com>
> > > > >
> > > > > Currently the driver spams the kernel log on unsupported ioctls
> > > > > which is unnecessary as the ioctl returns -ENOIOCTLCMD to
> > > > > indicate this
> > > anyway.
> > > > > I suspect this was originally for debugging purposes but it
> > > > > really is not required so remove it.
> > > > >
> > > >
> > > > This is rather strange as most of the legimit applications are
> > > > using one IOCTL from kernel 3.0 Do you have any reference where
> > > > this call is
> > > originated from, frankly this is the first time I got such complain.
> > > >
> > > > In any case it would be maybe better to change it a warn once call.
> > >
> > > Just drop the message, it should not be this easy for userspace to
> > > spam the kernel log.  The patch looks fine to me.
> > >
> > Fair enough, add my ack too.
> >
> > Still I'm curious if this comes from the field.
> 
> fuzzers are "in the field" :)

It's definitely fuzzers season.

Tomas

      reply	other threads:[~2018-02-28  9:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-27 16:21 [PATCH] mei: remove dev_err message on an unsupported ioctl Colin King
2018-02-27 16:21 ` Colin King
2018-02-27 17:26 ` Winkler, Tomas
2018-02-27 17:26   ` Winkler, Tomas
2018-02-27 17:31   ` Colin Ian King
2018-02-27 21:47     ` Winkler, Tomas
2018-02-27 21:47       ` Winkler, Tomas
2018-02-27 18:10   ` Greg Kroah-Hartman
2018-02-27 18:10     ` Greg Kroah-Hartman
2018-02-27 21:44     ` Winkler, Tomas
2018-02-28  9:49       ` Greg Kroah-Hartman
2018-02-28  9:49         ` Greg Kroah-Hartman
2018-02-28  9:52         ` Winkler, Tomas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5B8DA87D05A7694D9FA63FD143655C1B9422AF6C@hasmsx108.ger.corp.intel.com \
    --to=tomas.winkler@intel.com \
    --cc=arnd@arndb.de \
    --cc=colin.king@canonical.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.