[PATCH] mei: remove dev_err message on an unsupported ioctl

[PATCH] mei: remove dev_err message on an unsupported ioctl

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

Currently the driver spams the kernel log on unsupported ioctls which is
unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway.
I suspect this was originally for debugging purposes but it really is not
required so remove it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
---
 drivers/misc/mei/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index 758dc73602d5..7bb013644aeb 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -507,7 +507,6 @@ static long mei_ioctl(struct file *file, unsigned int cmd, unsigned long data)
 		break;
 
 	default:
-		dev_err(dev->dev, ": unsupported ioctl %d.\n", cmd);
 		rets = -ENOIOCTLCMD;
 	}
 
-- 
2.15.1

[PATCH] mei: remove dev_err message on an unsupported ioctl

[Colin King]

From: Colin Ian King <colin.king@canonical.com>

Currently the driver spams the kernel log on unsupported ioctls which is
unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway.
I suspect this was originally for debugging purposes but it really is not
required so remove it.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/misc/mei/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index 758dc73602d5..7bb013644aeb 100644
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -507,7 +507,6 @@ static long mei_ioctl(struct file *file, unsigned int cmd, unsigned long data)
 		break;
 
 	default:
-		dev_err(dev->dev, ": unsupported ioctl %d.\n", cmd);
 		rets = -ENOIOCTLCMD;
 	}
 
-- 
2.15.1

RE: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Winkler, Tomas]

> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently the driver spams the kernel log on unsupported ioctls which is
> unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway.
> I suspect this was originally for debugging purposes but it really is not
> required so remove it.
>

This is rather strange as most of the legimit applications are using one IOCTL from kernel 3.0
Do you have any reference where this call is originated from, frankly this is the first time I got such complain.

In any case it would be maybe better to change it a warn once call.
 
Thanks
Tomas

> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/misc/mei/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index
> 758dc73602d5..7bb013644aeb 100644
> --- a/drivers/misc/mei/main.c
> +++ b/drivers/misc/mei/main.c
> @@ -507,7 +507,6 @@ static long mei_ioctl(struct file *file, unsigned int
> cmd, unsigned long data)
>  		break;
> 
>  	default:
> -		dev_err(dev->dev, ": unsupported ioctl %d.\n", cmd);
>  		rets = -ENOIOCTLCMD;
>  	}
> 
> --
> 2.15.1

RE: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Winkler, Tomas]

PiANCj4gRnJvbTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCj4g
DQo+IEN1cnJlbnRseSB0aGUgZHJpdmVyIHNwYW1zIHRoZSBrZXJuZWwgbG9nIG9uIHVuc3VwcG9y
dGVkIGlvY3RscyB3aGljaCBpcw0KPiB1bm5lY2Vzc2FyeSBhcyB0aGUgaW9jdGwgcmV0dXJucyAt
RU5PSU9DVExDTUQgdG8gaW5kaWNhdGUgdGhpcyBhbnl3YXkuDQo+IEkgc3VzcGVjdCB0aGlzIHdh
cyBvcmlnaW5hbGx5IGZvciBkZWJ1Z2dpbmcgcHVycG9zZXMgYnV0IGl0IHJlYWxseSBpcyBub3QN
Cj4gcmVxdWlyZWQgc28gcmVtb3ZlIGl0Lg0KPg0KDQpUaGlzIGlzIHJhdGhlciBzdHJhbmdlIGFz
IG1vc3Qgb2YgdGhlIGxlZ2ltaXQgYXBwbGljYXRpb25zIGFyZSB1c2luZyBvbmUgSU9DVEwgZnJv
bSBrZXJuZWwgMy4wDQpEbyB5b3UgaGF2ZSBhbnkgcmVmZXJlbmNlIHdoZXJlIHRoaXMgY2FsbCBp
cyBvcmlnaW5hdGVkIGZyb20sIGZyYW5rbHkgdGhpcyBpcyB0aGUgZmlyc3QgdGltZSBJIGdvdCBz
dWNoIGNvbXBsYWluLg0KDQpJbiBhbnkgY2FzZSBpdCB3b3VsZCBiZSBtYXliZSBiZXR0ZXIgdG8g
Y2hhbmdlIGl0IGEgd2FybiBvbmNlIGNhbGwuDQogDQpUaGFua3MNClRvbWFzDQoNCj4gU2lnbmVk
LW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCj4gLS0t
DQo+ICBkcml2ZXJzL21pc2MvbWVpL21haW4uYyB8IDEgLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDEg
ZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21pc2MvbWVpL21haW4uYyBi
L2RyaXZlcnMvbWlzYy9tZWkvbWFpbi5jIGluZGV4DQo+IDc1OGRjNzM2MDJkNS4uN2JiMDEzNjQ0
YWViIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL21pc2MvbWVpL21haW4uYw0KPiArKysgYi9kcml2
ZXJzL21pc2MvbWVpL21haW4uYw0KPiBAQCAtNTA3LDcgKzUwNyw2IEBAIHN0YXRpYyBsb25nIG1l
aV9pb2N0bChzdHJ1Y3QgZmlsZSAqZmlsZSwgdW5zaWduZWQgaW50DQo+IGNtZCwgdW5zaWduZWQg
bG9uZyBkYXRhKQ0KPiAgCQlicmVhazsNCj4gDQo+ICAJZGVmYXVsdDoNCj4gLQkJZGV2X2Vycihk
ZXYtPmRldiwgIjogdW5zdXBwb3J0ZWQgaW9jdGwgJWQuXG4iLCBjbWQpOw0KPiAgCQlyZXRzID0g
LUVOT0lPQ1RMQ01EOw0KPiAgCX0NCj4gDQo+IC0tDQo+IDIuMTUuMQ0KDQo

Re: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Colin Ian King]

On 27/02/18 17:26, Winkler, Tomas wrote:
>>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Currently the driver spams the kernel log on unsupported ioctls which is
>> unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway.
>> I suspect this was originally for debugging purposes but it really is not
>> required so remove it.
>>
> 
> This is rather strange as most of the legimit applications are using one IOCTL from kernel 3.0
> Do you have any reference where this call is originated from, frankly this is the first time I got such complain.

I hit this while stressing the kernel with my stress-ng kernel stressing
tool; this was not using the legitimate ioctls (to see if things
explode) and I got a rather full kernel log. So it was being abused
somewhat ;-)

> 
> In any case it would be maybe better to change it a warn once call.

Probably so, I can fix that up if that is preferred.

Colin

>  
> Thanks
> Tomas
> 
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>  drivers/misc/mei/main.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c index
>> 758dc73602d5..7bb013644aeb 100644
>> --- a/drivers/misc/mei/main.c
>> +++ b/drivers/misc/mei/main.c
>> @@ -507,7 +507,6 @@ static long mei_ioctl(struct file *file, unsigned int
>> cmd, unsigned long data)
>>  		break;
>>
>>  	default:
>> -		dev_err(dev->dev, ": unsupported ioctl %d.\n", cmd);
>>  		rets = -ENOIOCTLCMD;
>>  	}
>>
>> --
>> 2.15.1
> 

RE: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Winkler, Tomas]

> On 27/02/18 17:26, Winkler, Tomas wrote:
> >>
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> Currently the driver spams the kernel log on unsupported ioctls which
> >> is unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this
> anyway.
> >> I suspect this was originally for debugging purposes but it really is
> >> not required so remove it.
> >>
> >
> > This is rather strange as most of the legimit applications are using
> > one IOCTL from kernel 3.0 Do you have any reference where this call is
> originated from, frankly this is the first time I got such complain.
> 
> I hit this while stressing the kernel with my stress-ng kernel stressing tool;
> this was not using the legitimate ioctls (to see if things
> explode) and I got a rather full kernel log. So it was being abused somewhat
> ;-)

Okay, thanks for the info.

RE: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Winkler, Tomas]

DQo+IE9uIDI3LzAyLzE4IDE3OjI2LCBXaW5rbGVyLCBUb21hcyB3cm90ZToNCj4gPj4NCj4gPj4g
RnJvbTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCj4gPj4NCj4g
Pj4gQ3VycmVudGx5IHRoZSBkcml2ZXIgc3BhbXMgdGhlIGtlcm5lbCBsb2cgb24gdW5zdXBwb3J0
ZWQgaW9jdGxzIHdoaWNoDQo+ID4+IGlzIHVubmVjZXNzYXJ5IGFzIHRoZSBpb2N0bCByZXR1cm5z
IC1FTk9JT0NUTENNRCB0byBpbmRpY2F0ZSB0aGlzDQo+IGFueXdheS4NCj4gPj4gSSBzdXNwZWN0
IHRoaXMgd2FzIG9yaWdpbmFsbHkgZm9yIGRlYnVnZ2luZyBwdXJwb3NlcyBidXQgaXQgcmVhbGx5
IGlzDQo+ID4+IG5vdCByZXF1aXJlZCBzbyByZW1vdmUgaXQuDQo+ID4+DQo+ID4NCj4gPiBUaGlz
IGlzIHJhdGhlciBzdHJhbmdlIGFzIG1vc3Qgb2YgdGhlIGxlZ2ltaXQgYXBwbGljYXRpb25zIGFy
ZSB1c2luZw0KPiA+IG9uZSBJT0NUTCBmcm9tIGtlcm5lbCAzLjAgRG8geW91IGhhdmUgYW55IHJl
ZmVyZW5jZSB3aGVyZSB0aGlzIGNhbGwgaXMNCj4gb3JpZ2luYXRlZCBmcm9tLCBmcmFua2x5IHRo
aXMgaXMgdGhlIGZpcnN0IHRpbWUgSSBnb3Qgc3VjaCBjb21wbGFpbi4NCj4gDQo+IEkgaGl0IHRo
aXMgd2hpbGUgc3RyZXNzaW5nIHRoZSBrZXJuZWwgd2l0aCBteSBzdHJlc3Mtbmcga2VybmVsIHN0
cmVzc2luZyB0b29sOw0KPiB0aGlzIHdhcyBub3QgdXNpbmcgdGhlIGxlZ2l0aW1hdGUgaW9jdGxz
ICh0byBzZWUgaWYgdGhpbmdzDQo+IGV4cGxvZGUpIGFuZCBJIGdvdCBhIHJhdGhlciBmdWxsIGtl
cm5lbCBsb2cuIFNvIGl0IHdhcyBiZWluZyBhYnVzZWQgc29tZXdoYXQNCj4gOy0pDQoNCk9rYXks
IHRoYW5rcyBmb3IgdGhlIGluZm8uDQoNCg=

Re: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Greg Kroah-Hartman]

On Tue, Feb 27, 2018 at 05:26:22PM +0000, Winkler, Tomas wrote:
> > 
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > Currently the driver spams the kernel log on unsupported ioctls which is
> > unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway.
> > I suspect this was originally for debugging purposes but it really is not
> > required so remove it.
> >
> 
> This is rather strange as most of the legimit applications are using one IOCTL from kernel 3.0
> Do you have any reference where this call is originated from, frankly this is the first time I got such complain.
> 
> In any case it would be maybe better to change it a warn once call.

Just drop the message, it should not be this easy for userspace to spam
the kernel log.  The patch looks fine to me.

thanks,

greg k-h

Re: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Greg Kroah-Hartman]

On Tue, Feb 27, 2018 at 05:26:22PM +0000, Winkler, Tomas wrote:
> > 
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > Currently the driver spams the kernel log on unsupported ioctls which is
> > unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this anyway.
> > I suspect this was originally for debugging purposes but it really is not
> > required so remove it.
> >
> 
> This is rather strange as most of the legimit applications are using one IOCTL from kernel 3.0
> Do you have any reference where this call is originated from, frankly this is the first time I got such complain.
> 
> In any case it would be maybe better to change it a warn once call.

Just drop the message, it should not be this easy for userspace to spam
the kernel log.  The patch looks fine to me.

thanks,

greg k-h

RE: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Winkler, Tomas]

> 
> On Tue, Feb 27, 2018 at 05:26:22PM +0000, Winkler, Tomas wrote:
> > >
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > Currently the driver spams the kernel log on unsupported ioctls
> > > which is unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this
> anyway.
> > > I suspect this was originally for debugging purposes but it really
> > > is not required so remove it.
> > >
> >
> > This is rather strange as most of the legimit applications are using
> > one IOCTL from kernel 3.0 Do you have any reference where this call is
> originated from, frankly this is the first time I got such complain.
> >
> > In any case it would be maybe better to change it a warn once call.
> 
> Just drop the message, it should not be this easy for userspace to spam the
> kernel log.  The patch looks fine to me.
> 
Fair enough, add my ack too.

Still I'm curious if this comes from the field.

Thanks
Tomas

Re: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Greg Kroah-Hartman]

On Tue, Feb 27, 2018 at 09:44:41PM +0000, Winkler, Tomas wrote:
> > 
> > On Tue, Feb 27, 2018 at 05:26:22PM +0000, Winkler, Tomas wrote:
> > > >
> > > > From: Colin Ian King <colin.king@canonical.com>
> > > >
> > > > Currently the driver spams the kernel log on unsupported ioctls
> > > > which is unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this
> > anyway.
> > > > I suspect this was originally for debugging purposes but it really
> > > > is not required so remove it.
> > > >
> > >
> > > This is rather strange as most of the legimit applications are using
> > > one IOCTL from kernel 3.0 Do you have any reference where this call is
> > originated from, frankly this is the first time I got such complain.
> > >
> > > In any case it would be maybe better to change it a warn once call.
> > 
> > Just drop the message, it should not be this easy for userspace to spam the
> > kernel log.  The patch looks fine to me.
> > 
> Fair enough, add my ack too.
> 
> Still I'm curious if this comes from the field.

fuzzers are "in the field" :)

Re: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Greg Kroah-Hartman]

On Tue, Feb 27, 2018 at 09:44:41PM +0000, Winkler, Tomas wrote:
> > 
> > On Tue, Feb 27, 2018 at 05:26:22PM +0000, Winkler, Tomas wrote:
> > > >
> > > > From: Colin Ian King <colin.king@canonical.com>
> > > >
> > > > Currently the driver spams the kernel log on unsupported ioctls
> > > > which is unnecessary as the ioctl returns -ENOIOCTLCMD to indicate this
> > anyway.
> > > > I suspect this was originally for debugging purposes but it really
> > > > is not required so remove it.
> > > >
> > >
> > > This is rather strange as most of the legimit applications are using
> > > one IOCTL from kernel 3.0 Do you have any reference where this call is
> > originated from, frankly this is the first time I got such complain.
> > >
> > > In any case it would be maybe better to change it a warn once call.
> > 
> > Just drop the message, it should not be this easy for userspace to spam the
> > kernel log.  The patch looks fine to me.
> > 
> Fair enough, add my ack too.
> 
> Still I'm curious if this comes from the field.

fuzzers are "in the field" :)

RE: [PATCH] mei: remove dev_err message on an unsupported ioctl

[Winkler, Tomas]

> 
> On Tue, Feb 27, 2018 at 09:44:41PM +0000, Winkler, Tomas wrote:
> > >
> > > On Tue, Feb 27, 2018 at 05:26:22PM +0000, Winkler, Tomas wrote:
> > > > >
> > > > > From: Colin Ian King <colin.king@canonical.com>
> > > > >
> > > > > Currently the driver spams the kernel log on unsupported ioctls
> > > > > which is unnecessary as the ioctl returns -ENOIOCTLCMD to
> > > > > indicate this
> > > anyway.
> > > > > I suspect this was originally for debugging purposes but it
> > > > > really is not required so remove it.
> > > > >
> > > >
> > > > This is rather strange as most of the legimit applications are
> > > > using one IOCTL from kernel 3.0 Do you have any reference where
> > > > this call is
> > > originated from, frankly this is the first time I got such complain.
> > > >
> > > > In any case it would be maybe better to change it a warn once call.
> > >
> > > Just drop the message, it should not be this easy for userspace to
> > > spam the kernel log.  The patch looks fine to me.
> > >
> > Fair enough, add my ack too.
> >
> > Still I'm curious if this comes from the field.
> 
> fuzzers are "in the field" :)

It's definitely fuzzers season.

Tomas