From: "Jan Beulich" <JBeulich@suse.com>
To: mirela.simonovic@aggios.com
Cc: Tim Deegan <tim@xen.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
dm@aggios.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen Devel <xen-devel@lists.xen.org>,
Julien Grall <julien.grall@arm.com>,
stefano.stabellini@xilinx.com, saeed.nowshadi@xilinx.com
Subject: Re: [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface)
Date: Mon, 12 Nov 2018 05:45:19 -0700 [thread overview]
Message-ID: <5BE975DF02000078001FAF91@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <CAKPH-NjKU6KvU7ZaQUXuaKYFBgKqCNO0uW2Rn2K8YVEtbew8mg@mail.gmail.com>
>>> On 12.11.18 at 12:50, <mirela.simonovic@aggios.com> wrote:
> What?
Please don't top post.
> On Mon, Nov 12, 2018 at 12:42 PM Jan Beulich <JBeulich@suse.com> wrote:
>
>> >>> On 12.11.18 at 12:30, <mirela.simonovic@aggios.com> wrote:
>> > --- a/xen/include/xen/sched.h
>> > +++ b/xen/include/xen/sched.h
>> > @@ -24,6 +24,7 @@
>> > #include <xen/wait.h>
>> > #include <public/xen.h>
>> > #include <public/domctl.h>
>> > +#include <public/sched.h>
>> > #include <public/sysctl.h>
>> > #include <public/vcpu.h>
>> > #include <public/vm_event.h>
>>
>> Why?
I think given the context the question, even if terse, is pretty
clear: Why do you add this #include as the only change in this
header? Nothing in the header previously required it, and if
you have a sudden new requirement elsewhere, then please
include the extra header just there.
Also please accept that given the amount of time needed to
deal with incoming patches, it is not generally scalable to
always give long explanations to what seems pretty obvious
anyway. (I do realize that "obvious" is a rather subjective
attribute to things.)
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-12 12:45 UTC|newest]
Thread overview: 153+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 11:30 [PATCH 00/18] xen/arm64: Suspend to RAM support for Xen Mirela Simonovic
2018-11-12 11:30 ` [PATCH 01/18] xen/arm: Move code that initializes VCPU context into a separate function Mirela Simonovic
2018-11-12 11:41 ` Jan Beulich
2018-11-12 11:43 ` Wei Liu
2018-11-12 13:15 ` Julien Grall
2018-11-14 11:45 ` Mirela Simonovic
2018-11-12 11:30 ` [PATCH 02/18] xen/arm: Implement PSCI system suspend call (virtual interface) Mirela Simonovic
2018-11-12 11:42 ` Jan Beulich
2018-11-12 11:50 ` Mirela Simonovic
2018-11-12 12:45 ` Jan Beulich [this message]
2018-11-12 15:27 ` Julien Grall
2018-11-12 16:35 ` Mirela Simonovic
2018-11-12 16:41 ` Andrew Cooper
2018-11-12 19:56 ` Julien Grall
2018-11-13 8:32 ` Andrew Cooper
2018-11-14 12:08 ` Mirela Simonovic
2018-11-14 12:49 ` Julien Grall
2018-11-15 0:47 ` Andrew Cooper
2018-11-15 10:13 ` Julien Grall
2018-11-15 10:26 ` Andrew Cooper
2018-11-15 10:33 ` Mirela Simonovic
2018-11-15 10:59 ` Julien Grall
2018-11-15 11:10 ` Mirela Simonovic
2018-11-15 11:38 ` Julien Grall
2018-11-15 11:42 ` Mirela Simonovic
2018-11-15 19:30 ` Stefano Stabellini
2018-11-15 20:25 ` Julien Grall
2018-11-16 22:10 ` Dario Faggioli
2018-11-15 10:36 ` Julien Grall
2018-11-15 10:36 ` Julien Grall
2018-11-15 10:50 ` Andrew Cooper
2018-11-13 1:53 ` Stefano Stabellini
2018-11-13 9:41 ` Julien Grall
2018-11-13 20:39 ` Stefano Stabellini
2018-11-14 13:10 ` Julien Grall
2018-11-14 23:08 ` Stefano Stabellini
2018-11-12 20:29 ` Julien Grall
2018-11-13 20:39 ` Stefano Stabellini
2018-11-14 10:45 ` Julien Grall
2018-11-14 12:35 ` Mirela Simonovic
2018-11-14 13:05 ` Julien Grall
2018-11-14 14:48 ` Julien Grall
2018-11-14 15:36 ` Mirela Simonovic
2018-11-14 15:37 ` Mirela Simonovic
2018-11-14 15:51 ` Julien Grall
2018-11-13 10:23 ` Julien Grall
2018-11-13 15:09 ` Julien Grall
2018-11-14 12:44 ` Mirela Simonovic
2018-11-12 11:30 ` [PATCH 03/18] xen/arm: Save GIC and virtual timer context when the domain suspends Mirela Simonovic
2018-11-12 15:36 ` Julien Grall
2018-11-12 16:52 ` Mirela Simonovic
2018-11-12 17:00 ` Julien Grall
2018-11-12 17:42 ` Mirela Simonovic
2018-11-12 19:20 ` Julien Grall
2018-11-13 20:44 ` Stefano Stabellini
2018-11-14 10:48 ` Julien Grall
2018-11-14 22:45 ` Stefano Stabellini
2018-11-14 23:39 ` Julien Grall
2018-11-15 0:05 ` Julien Grall
2018-11-15 0:35 ` Stefano Stabellini
2018-11-15 20:29 ` Julien Grall
2018-11-12 11:30 ` [PATCH 04/18] xen/arm: While a domain is suspended put its watchdogs on pause Mirela Simonovic
2018-11-12 11:47 ` Jan Beulich
2018-11-12 15:17 ` Mirela Simonovic
2018-11-12 15:23 ` Jan Beulich
2018-11-12 15:31 ` Mirela Simonovic
2018-11-12 15:33 ` Andrew Cooper
2018-11-16 22:40 ` Dario Faggioli
2018-11-12 11:30 ` [PATCH 05/18] xen/arm: Trigger Xen suspend when Dom0 completes suspend Mirela Simonovic
2018-11-12 15:45 ` Julien Grall
2018-11-12 23:46 ` Stefano Stabellini
2018-11-13 9:43 ` Julien Grall
2018-11-13 11:26 ` Mirela Simonovic
2018-11-13 11:42 ` Julien Grall
2018-11-14 15:07 ` Julien Grall
2018-11-14 15:40 ` Mirela Simonovic
2018-11-14 17:10 ` Julien Grall
2018-11-14 17:35 ` Mirela Simonovic
2018-11-14 18:48 ` Julien Grall
2018-11-15 12:37 ` Mirela Simonovic
2018-11-15 18:23 ` Julien Grall
2018-11-15 19:17 ` Mirela Simonovic
2018-11-15 20:47 ` Julien Grall
2018-11-12 11:30 ` [PATCH 06/18] xen/x86: Move freeze/thaw_domains into common files Mirela Simonovic
2018-11-13 22:37 ` Stefano Stabellini
2018-11-12 11:30 ` [PATCH 07/18] xen/arm: Freeze domains on suspend and thaw them on resume Mirela Simonovic
2018-11-12 11:30 ` [PATCH 08/18] xen/arm: Disable/enable non-boot physical CPUs on suspend/resume Mirela Simonovic
2018-11-13 22:35 ` Stefano Stabellini
2018-11-14 12:07 ` Julien Grall
2018-11-14 10:52 ` Julien Grall
2018-11-14 13:00 ` Mirela Simonovic
2018-11-14 13:18 ` Julien Grall
2018-11-14 23:04 ` Stefano Stabellini
2018-11-14 23:45 ` Julien Grall
2018-11-15 18:57 ` Stefano Stabellini
2018-11-15 21:09 ` Julien Grall
2018-11-12 11:30 ` [PATCH 09/18] xen/arm: Add rcu_barrier() before enabling non-boot CPUs on resume Mirela Simonovic
2018-11-13 22:42 ` Stefano Stabellini
2018-11-14 12:11 ` Julien Grall
2018-11-14 22:29 ` Stefano Stabellini
2018-11-12 11:30 ` [PATCH 10/18] xen/arm: Implement GIC suspend/resume functions (gicv2 only) Mirela Simonovic
2018-11-13 23:41 ` Stefano Stabellini
2018-11-14 9:13 ` Julien Grall
2018-11-14 11:57 ` Mirela Simonovic
2018-11-14 12:41 ` Julien Grall
2018-11-14 12:52 ` Mirela Simonovic
2018-11-14 13:24 ` Julien Grall
2018-11-14 22:18 ` Stefano Stabellini
2018-11-14 23:50 ` Julien Grall
2018-11-15 18:26 ` Stefano Stabellini
2018-11-12 11:30 ` [PATCH 11/18] xen/arm: Suspend/resume GIC on system suspend/resume Mirela Simonovic
2018-11-12 11:30 ` [PATCH 12/18] xen/arm: Suspend/resume timer interrupt generation Mirela Simonovic
2018-11-12 11:30 ` [PATCH 13/18] xen/arm: Implement PSCI SYSTEM_SUSPEND call (physical interface) Mirela Simonovic
2018-11-14 0:14 ` Stefano Stabellini
2018-11-14 12:03 ` Mirela Simonovic
2018-11-15 21:20 ` Julien Grall
2018-11-12 11:30 ` [PATCH 14/18] xen/arm: Convert setting MMU page tables code into a routine Mirela Simonovic
2018-11-12 11:30 ` [PATCH 15/18] xen/arm: Resume memory management on Xen resume Mirela Simonovic
2018-11-12 16:17 ` Julien Grall
2018-11-13 1:36 ` Stefano Stabellini
2018-11-13 9:59 ` Julien Grall
2018-11-13 21:35 ` Stefano Stabellini
2018-11-13 22:24 ` Julien Grall
2018-11-12 11:30 ` [PATCH 16/18] xen/arm: Save/restore context on suspend/resume Mirela Simonovic
2018-11-12 11:30 ` [PATCH 17/18] xen/arm: Resume Dom0 after Xen resumes Mirela Simonovic
2018-11-15 20:31 ` Julien Grall
2018-11-16 10:33 ` Mirela Simonovic
2018-11-16 11:29 ` Mirela Simonovic
2018-11-16 11:44 ` Julien Grall
2018-11-16 12:34 ` Mirela Simonovic
2018-11-16 13:24 ` Julien Grall
2018-11-16 19:03 ` Stefano Stabellini
2018-11-16 19:09 ` Stefano Stabellini
2018-11-16 21:41 ` Mirela Simonovic
2018-11-16 21:58 ` Julien Grall
2018-11-16 23:01 ` Dario Faggioli
2018-11-16 23:06 ` Stefano Stabellini
2018-11-17 16:01 ` Mirela Simonovic
2018-11-17 16:02 ` Mirela Simonovic
2018-11-17 16:19 ` Mirela Simonovic
2018-11-27 18:36 ` Julien Grall
2018-11-29 14:02 ` Mirela Simonovic
2018-12-04 18:15 ` Julien Grall
2018-11-12 11:30 ` [PATCH 18/18] xen/arm: Suspend/resume console on Xen suspend/resume Mirela Simonovic
2018-11-27 18:46 ` Julien Grall
2018-11-12 11:37 ` [PATCH 00/18] xen/arm64: Suspend to RAM support for Xen Mirela Simonovic
2018-11-12 11:49 ` Julien Grall
2018-11-12 12:01 ` Mirela Simonovic
2018-11-12 12:08 ` Julien Grall
2018-11-12 12:35 ` Mirela Simonovic
2018-11-13 2:22 ` Stefano Stabellini
2018-11-13 10:02 ` Julien Grall
2018-11-13 18:06 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BE975DF02000078001FAF91@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=dm@aggios.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=mirela.simonovic@aggios.com \
--cc=saeed.nowshadi@xilinx.com \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@xilinx.com \
--cc=tim@xen.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.