Re: [PATCH 4/4] libx86: Recalculate synthesised cpuid_policy fields when appropriate

From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Sergey Dyasli <sergey.dyasli@citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: Re: [PATCH 4/4] libx86: Recalculate synthesised cpuid_policy fields when appropriate
Date: Tue, 26 Mar 2019 06:20:36 -0600	[thread overview]
Message-ID: <5C9A19140200007800221E4A@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <1553170866-23812-5-git-send-email-andrew.cooper3@citrix.com>

>>> On 21.03.19 at 13:21, <andrew.cooper3@citrix.com> wrote:
> When filling a policy, either from CPUID or an incomming leaf stream,
> recalculate the synthesised vendor value.  All callers are expected to want
> this behaviour.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Reviewed-by: Jan Beulich <jbeulich@suse.com>
with one question:

> @@ -141,6 +148,8 @@ void x86_cpuid_policy_fill_native(struct cpuid_policy *p)
>      for ( i = 1; i < min_t(unsigned int, ARRAY_SIZE(p->extd.raw),
>                             p->extd.max_leaf + 1 - 0x80000000); ++i )
>          cpuid_leaf(0x80000000 + i, &p->extd.raw[i]);
> +
> +    recalculate_synth(p);
>  }
>  
>  const uint32_t *x86_cpuid_lookup_deep_deps(uint32_t feature)
> @@ -363,6 +372,8 @@ int x86_cpuid_copy_from_buffer(struct cpuid_policy *p,
>          }
>      }
>  
> +    recalculate_synth(p);
> +
>      return 0;
>  
>   out_of_range:

While this takes care of libx86, wouldn't it be desirable to mirror this
behavior into update_domain_cpuid_info() right away?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel