Re: [PATCH 4/4] libx86: Recalculate synthesised cpuid_policy fields when appropriate

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 26/03/2019 12:20, Jan Beulich wrote:
>>>> On 21.03.19 at 13:21, <andrew.cooper3@citrix.com> wrote:
>> When filling a policy, either from CPUID or an incomming leaf stream,
>> recalculate the synthesised vendor value.  All callers are expected to want
>> this behaviour.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> with one question:
>
>> @@ -141,6 +148,8 @@ void x86_cpuid_policy_fill_native(struct cpuid_policy *p)
>>      for ( i = 1; i < min_t(unsigned int, ARRAY_SIZE(p->extd.raw),
>>                             p->extd.max_leaf + 1 - 0x80000000); ++i )
>>          cpuid_leaf(0x80000000 + i, &p->extd.raw[i]);
>> +
>> +    recalculate_synth(p);
>>  }
>>  
>>  const uint32_t *x86_cpuid_lookup_deep_deps(uint32_t feature)
>> @@ -363,6 +372,8 @@ int x86_cpuid_copy_from_buffer(struct cpuid_policy *p,
>>          }
>>      }
>>  
>> +    recalculate_synth(p);
>> +
>>      return 0;
>>  
>>   out_of_range:
> While this takes care of libx86, wouldn't it be desirable to mirror this
> behavior into update_domain_cpuid_info() right away?

That is already done by patch 2 by virtue of the modification to
recalculate_cpuid_policy()

None of this code is going to survive to the end of my CPUID/MSR work.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel