[Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

[Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

[Daniel Loffgren]

Signed-off-by: Daniel Loffgren <daniel@loffgren.org>
---
 include/exec/user/thunk.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
index f19ef4b230..12b5449d8c 100644
--- a/include/exec/user/thunk.h
+++ b/include/exec/user/thunk.h
@@ -19,6 +19,7 @@
 #ifndef THUNK_H
 #define THUNK_H
 
+#include "abitypes.h"
 #include "cpu.h"
 
 /* types enums definitions */
-- 

Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

On 09/24/2017 08:02 PM, Daniel Loffgren wrote:
> 
> Signed-off-by: Daniel Loffgren <daniel@loffgren.org>
> ---
>  include/exec/user/thunk.h | 1 +
>  1 file changed, 1 insertion(+)

meta-comment: your patch is titled 2/2, but was sent as its own
top-level thread (it is missing In-Reply-To: and References: headers).
When sending 2 patches as a series, it is important to include a 0/2
cover letter, and to properly thread things so that both 1/2 and 2/2 are
in-reply-to the 0/2 cover letter.  'git send-email' is probably the
easiest way to get this to work.  More patch submission hints at:

https://wiki.qemu.org/Contribute/SubmitAPatch

> 
> diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
> index f19ef4b230..12b5449d8c 100644
> --- a/include/exec/user/thunk.h
> +++ b/include/exec/user/thunk.h
> @@ -19,6 +19,7 @@
>  #ifndef THUNK_H
>  #define THUNK_H
>  
> +#include "abitypes.h"
>  #include "cpu.h"
>  
>  /* types enums definitions */
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

[Thomas Huth]

Did this cause any trouble? ... one of two sentences in the patch
description would be nice, I think.

 Thomas


On 25.09.2017 03:02, Daniel Loffgren wrote:
> 
> Signed-off-by: Daniel Loffgren <daniel@loffgren.org>
> ---
>  include/exec/user/thunk.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
> index f19ef4b230..12b5449d8c 100644
> --- a/include/exec/user/thunk.h
> +++ b/include/exec/user/thunk.h
> @@ -19,6 +19,7 @@
>  #ifndef THUNK_H
>  #define THUNK_H
>  
> +#include "abitypes.h"
>  #include "cpu.h"
>  
>  /* types enums definitions */
> 

Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

[Daniel Loffgren]

> On Sep 25, 2017, at 9:10 AM, Eric Blake <eblake@redhat.com> wrote:
> 
> On 09/24/2017 08:02 PM, Daniel Loffgren wrote:
>> 
>> Signed-off-by: Daniel Loffgren <daniel@loffgren.org <mailto:daniel@loffgren.org>>
>> ---
>> include/exec/user/thunk.h | 1 +
>> 1 file changed, 1 insertion(+)
> 
> meta-comment: your patch is titled 2/2, but was sent as its own
> top-level thread (it is missing In-Reply-To: and References: headers).
> When sending 2 patches as a series, it is important to include a 0/2
> cover letter, and to properly thread things so that both 1/2 and 2/2 are
> in-reply-to the 0/2 cover letter.  'git send-email' is probably the
> easiest way to get this to work.  More patch submission hints at:
> 
> https://wiki.qemu.org/Contribute/SubmitAPatch <https://wiki.qemu.org/Contribute/SubmitAPatch>

Oops, sorry about that! I used 'git format-patch' to get this email from a set of two commits, and sent each as-is. This commit can totally stand alone.

>> 
>> diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
>> index f19ef4b230..12b5449d8c 100644
>> --- a/include/exec/user/thunk.h
>> +++ b/include/exec/user/thunk.h
>> @@ -19,6 +19,7 @@
>> #ifndef THUNK_H
>> #define THUNK_H
>> 
>> +#include "abitypes.h"
>> #include "cpu.h"
>> 
>> /* types enums definitions */
>> 
> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org <http://qemu.org/> | libvirt.org <http://libvirt.org/>

Re: [Qemu-devel] [PATCH 2/2] thunk.h uses TARGET_ABI_BITS without including abitypes.h

[Daniel Loffgren]

I am attempting to get ppc-darwin-user in a good working state again, and this broke one of the .c files that included it. I figured this change should be made regardless of my branch, and would help reduce the size of my branch for future rebasing.

> On Sep 25, 2017, at 9:37 AM, Thomas Huth <thuth@redhat.com> wrote:
> 
> 
> Did this cause any trouble? ... one of two sentences in the patch
> description would be nice, I think.
> 
> Thomas
> 
> 
> On 25.09.2017 03:02, Daniel Loffgren wrote:
>> 
>> Signed-off-by: Daniel Loffgren <daniel@loffgren.org>
>> ---
>> include/exec/user/thunk.h | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/include/exec/user/thunk.h b/include/exec/user/thunk.h
>> index f19ef4b230..12b5449d8c 100644
>> --- a/include/exec/user/thunk.h
>> +++ b/include/exec/user/thunk.h
>> @@ -19,6 +19,7 @@
>> #ifndef THUNK_H
>> #define THUNK_H
>> 
>> +#include "abitypes.h"
>> #include "cpu.h"
>> 
>> /* types enums definitions */
>> 
>