* [PATCH] semihosting: remove the pthread include which seems unused
@ 2020-05-18 13:02 konrad
2020-05-18 13:50 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 4+ messages in thread
From: konrad @ 2020-05-18 13:02 UTC (permalink / raw)
To: alex.bennee; +Cc: frederic.konrad, qemu-devel
From: KONRAD Frederic <frederic.konrad@adacore.com>
This have been introduced by:
8de702cb677c8381fb702cae252d6b69aa4c653b
It doesn't seem to be used so remove it.
Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
---
hw/semihosting/console.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
index 6346bd7..22e7827 100644
--- a/hw/semihosting/console.c
+++ b/hw/semihosting/console.c
@@ -23,7 +23,6 @@
#include "exec/exec-all.h"
#include "qemu/log.h"
#include "chardev/char.h"
-#include <pthread.h>
#include "chardev/char-fe.h"
#include "sysemu/sysemu.h"
#include "qemu/main-loop.h"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] semihosting: remove the pthread include which seems unused
2020-05-18 13:02 [PATCH] semihosting: remove the pthread include which seems unused konrad
@ 2020-05-18 13:50 ` Philippe Mathieu-Daudé
2020-06-01 9:19 ` Fred Konrad
0 siblings, 1 reply; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-05-18 13:50 UTC (permalink / raw)
To: konrad, alex.bennee; +Cc: frederic.konrad, qemu-devel
On 5/18/20 3:02 PM, konrad@adacore.com wrote:
> From: KONRAD Frederic <frederic.konrad@adacore.com>
>
> This have been introduced by:
> 8de702cb677c8381fb702cae252d6b69aa4c653b
>
> It doesn't seem to be used so remove it.
>
> Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
> ---
> hw/semihosting/console.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
> index 6346bd7..22e7827 100644
> --- a/hw/semihosting/console.c
> +++ b/hw/semihosting/console.c
> @@ -23,7 +23,6 @@
> #include "exec/exec-all.h"
> #include "qemu/log.h"
> #include "chardev/char.h"
> -#include <pthread.h>
> #include "chardev/char-fe.h"
> #include "sysemu/sysemu.h"
> #include "qemu/main-loop.h"
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] semihosting: remove the pthread include which seems unused
2020-05-18 13:50 ` Philippe Mathieu-Daudé
@ 2020-06-01 9:19 ` Fred Konrad
2020-06-01 10:29 ` Alex Bennée
0 siblings, 1 reply; 4+ messages in thread
From: Fred Konrad @ 2020-06-01 9:19 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, alex.bennee
Cc: QEMU Trivial, frederic.konrad, qemu-devel
Le 5/18/20 à 3:50 PM, Philippe Mathieu-Daudé a écrit :
> On 5/18/20 3:02 PM, konrad@adacore.com wrote:
>> From: KONRAD Frederic <frederic.konrad@adacore.com>
>>
>> This have been introduced by:
>> 8de702cb677c8381fb702cae252d6b69aa4c653b
>>
>> It doesn't seem to be used so remove it.
>>
>> Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
>> ---
>> hw/semihosting/console.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
>> index 6346bd7..22e7827 100644
>> --- a/hw/semihosting/console.c
>> +++ b/hw/semihosting/console.c
>> @@ -23,7 +23,6 @@
>> #include "exec/exec-all.h"
>> #include "qemu/log.h"
>> #include "chardev/char.h"
>> -#include <pthread.h>
>> #include "chardev/char-fe.h"
>> #include "sysemu/sysemu.h"
>> #include "qemu/main-loop.h"
>>
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
Thanks for the review, Philippe. Can this go through qemu-trivial?
Regards,
Fred
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] semihosting: remove the pthread include which seems unused
2020-06-01 9:19 ` Fred Konrad
@ 2020-06-01 10:29 ` Alex Bennée
0 siblings, 0 replies; 4+ messages in thread
From: Alex Bennée @ 2020-06-01 10:29 UTC (permalink / raw)
To: Fred Konrad
Cc: QEMU Trivial, frederic.konrad, Philippe Mathieu-Daudé, qemu-devel
Fred Konrad <konrad@adacore.com> writes:
> Le 5/18/20 à 3:50 PM, Philippe Mathieu-Daudé a écrit :
>> On 5/18/20 3:02 PM, konrad@adacore.com wrote:
>>> From: KONRAD Frederic <frederic.konrad@adacore.com>
>>>
>>> This have been introduced by:
>>> 8de702cb677c8381fb702cae252d6b69aa4c653b
>>>
>>> It doesn't seem to be used so remove it.
>>>
>>> Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
>>> ---
>>> hw/semihosting/console.c | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
>>> index 6346bd7..22e7827 100644
>>> --- a/hw/semihosting/console.c
>>> +++ b/hw/semihosting/console.c
>>> @@ -23,7 +23,6 @@
>>> #include "exec/exec-all.h"
>>> #include "qemu/log.h"
>>> #include "chardev/char.h"
>>> -#include <pthread.h>
>>> #include "chardev/char-fe.h"
>>> #include "sysemu/sysemu.h"
>>> #include "qemu/main-loop.h"
>>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>
> Thanks for the review, Philippe. Can this go through qemu-trivial?
Sure:
Acked-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-01 10:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 13:02 [PATCH] semihosting: remove the pthread include which seems unused konrad
2020-05-18 13:50 ` Philippe Mathieu-Daudé
2020-06-01 9:19 ` Fred Konrad
2020-06-01 10:29 ` Alex Bennée
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.