From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: linux-renesas-soc@vger.kernel.org, Takeshi Kihara <takeshi.kihara.df@renesas.com>, Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" <linux-arm-kernel@lists.infradead.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output Date: Fri, 27 Apr 2018 17:22:06 +0100 [thread overview] Message-ID: <5af7b6a6-8a40-880d-3346-8c90bd700957@ideasonboard.com> (raw) In-Reply-To: <2345148.J1marZVneP@avalon> Hi Laurent, On 26/04/18 22:21, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 26 April 2018 19:53:44 EEST Kieran Bingham wrote: >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> >> Enable the HDMI encoder for the M3N Salvator-X board and hook it up to >> the HDMI connector. >> >> Based on a similar patches of the the Salvator-X board >> on the R8A7796 SoC device tree >> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks, collected. > > How about adding the VGA output too ? I think you can add both VGA and HDMI in > a single patch that enables display in one go for the board. Same comment for > the Salvator-XS. I believe the VGA output is handled by the salvator-common.dtsi, and thus doesn't need to be included in this patch. > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >> --- >> .../boot/dts/renesas/r8a77965-salvator-x.dts | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts >> b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts index >> a2b8fb20fef8..11e8d43e9e11 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts >> @@ -31,3 +31,20 @@ >> clock-names = "du.0", "du.1", "du.3", "lvds.0", >> "dclkin.0", "dclkin.1", "dclkin.3"; >> }; >> + >> +&hdmi0 { >> + status = "okay"; >> + >> + ports { >> + port@1 { >> + reg = <1>; >> + rcar_dw_hdmi0_out: endpoint { >> + remote-endpoint = <&hdmi0_con>; >> + }; >> + }; >> + }; >> +}; >> + >> +&hdmi0_con { >> + remote-endpoint = <&rcar_dw_hdmi0_out>; >> +}; >
WARNING: multiple messages have this Message-ID (diff)
From: kieran.bingham+renesas@ideasonboard.com (Kieran Bingham) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output Date: Fri, 27 Apr 2018 17:22:06 +0100 [thread overview] Message-ID: <5af7b6a6-8a40-880d-3346-8c90bd700957@ideasonboard.com> (raw) In-Reply-To: <2345148.J1marZVneP@avalon> Hi Laurent, On 26/04/18 22:21, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 26 April 2018 19:53:44 EEST Kieran Bingham wrote: >> From: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> >> Enable the HDMI encoder for the M3N Salvator-X board and hook it up to >> the HDMI connector. >> >> Based on a similar patches of the the Salvator-X board >> on the R8A7796 SoC device tree >> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks, collected. > > How about adding the VGA output too ? I think you can add both VGA and HDMI in > a single patch that enables display in one go for the board. Same comment for > the Salvator-XS. I believe the VGA output is handled by the salvator-common.dtsi, and thus doesn't need to be included in this patch. > >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >> --- >> .../boot/dts/renesas/r8a77965-salvator-x.dts | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts >> b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts index >> a2b8fb20fef8..11e8d43e9e11 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts >> @@ -31,3 +31,20 @@ >> clock-names = "du.0", "du.1", "du.3", "lvds.0", >> "dclkin.0", "dclkin.1", "dclkin.3"; >> }; >> + >> +&hdmi0 { >> + status = "okay"; >> + >> + ports { >> + port at 1 { >> + reg = <1>; >> + rcar_dw_hdmi0_out: endpoint { >> + remote-endpoint = <&hdmi0_con>; >> + }; >> + }; >> + }; >> +}; >> + >> +&hdmi0_con { >> + remote-endpoint = <&rcar_dw_hdmi0_out>; >> +}; >
next prev parent reply other threads:[~2018-04-27 16:22 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-26 16:53 [PATCH 00/17] r8a77965: M3-N DU Enablement Kieran Bingham 2018-04-26 16:53 ` [PATCH 01/17] dt-bindings: display: renesas: du: Increase indent in output table Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:08 ` Laurent Pinchart 2018-04-26 20:08 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 02/17] dt-bindings: display: renesas: du: Document the R8A77965 bindings Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:57 ` Kieran Bingham 2018-04-26 16:57 ` Kieran Bingham 2018-04-26 20:10 ` Laurent Pinchart 2018-04-26 20:10 ` Laurent Pinchart 2018-04-27 8:40 ` Kieran Bingham 2018-04-27 8:40 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 03/17] pinctrl: sh-pfc: r8a77965: Add DU RGB output pins, groups and functions Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:16 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 04/17] drm: rcar-du: Use the correct naming for ODPM fields in DEFR6 Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:18 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 05/17] drm: rcar-du: Split CRTC handling to support hardware indexing Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:30 ` Laurent Pinchart 2018-04-26 20:30 ` Laurent Pinchart 2018-04-27 10:15 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 06/17] drm: rcar-du: Allow DU groups to work with " Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:36 ` Laurent Pinchart 2018-04-26 20:36 ` Laurent Pinchart 2018-04-27 10:10 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 07/17] drm: rcar-du: Add R8A77965 support Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:43 ` Laurent Pinchart 2018-04-26 20:43 ` Laurent Pinchart 2018-04-27 10:14 ` Kieran Bingham 2018-04-27 10:14 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 08/17] arm64: dts: r8a77965: Provide sysc header definitions Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:53 ` Laurent Pinchart 2018-04-26 20:53 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 09/17] arm64: dts: r8a77965: Use the correct CPG header Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:16 ` Laurent Pinchart 2018-04-26 21:16 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 10/17] arm64: dts: r8a77965: Add FCPF and FCPV instances Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:06 ` Laurent Pinchart 2018-04-26 21:06 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:11 ` Laurent Pinchart 2018-04-26 21:11 ` Laurent Pinchart 2018-04-27 16:33 ` Kieran Bingham 2018-04-27 16:33 ` Kieran Bingham 2018-06-08 9:29 ` Geert Uytterhoeven 2018-06-08 9:29 ` Geert Uytterhoeven 2018-06-08 11:00 ` Laurent Pinchart 2018-06-08 11:00 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:15 ` Laurent Pinchart 2018-04-26 21:15 ` Laurent Pinchart 2018-04-27 16:34 ` Kieran Bingham 2018-04-27 16:34 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 13/17] arm64: dts: r8a77965: Add HDMI encoder instance Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:17 ` Laurent Pinchart 2018-04-26 21:17 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 14/17] arm64: dts: r8a77965-salvator-x: Add DU external dot clocks Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:18 ` Laurent Pinchart 2018-04-26 21:18 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:21 ` Laurent Pinchart 2018-04-26 21:21 ` Laurent Pinchart 2018-04-27 16:22 ` Kieran Bingham [this message] 2018-04-27 16:22 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 16/17] arm64: dts: r8a77965-salvator-xs: Add DU external dot clocks Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:22 ` Laurent Pinchart 2018-04-26 21:22 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 17/17] arm64: dts: r8a77965-salvator-xs: Enable HDMI output Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:23 ` [PATCH 00/17] r8a77965: M3-N DU Enablement Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5af7b6a6-8a40-880d-3346-8c90bd700957@ideasonboard.com \ --to=kieran.bingham+renesas@ideasonboard.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=horms@verge.net.au \ --cc=kieran.bingham@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=takeshi.kihara.df@renesas.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.