From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: linux-renesas-soc@vger.kernel.org, Takeshi Kihara <takeshi.kihara.df@renesas.com>, Simon Horman <horms@verge.net.au>, Magnus Damm <magnus.damm@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)" <linux-arm-kernel@lists.infradead.org>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances Date: Fri, 27 Apr 2018 17:33:46 +0100 [thread overview] Message-ID: <81161c97-2be8-2b5a-14a2-3db8709f5ff7@ideasonboard.com> (raw) In-Reply-To: <1787243.JuNJAuBqMb@avalon> Hi Laurent, On 26/04/18 22:11, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 26 April 2018 19:53:40 EEST Kieran Bingham wrote: >> The r8a77965 has 4 VSP instances. >> >> Based on a similar patch of the R8A7796 device tree >> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>. >> >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> [Kieran: Rebased to top of tree, fixed sort orders] >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >> --- >> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 44 +++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi >> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index >> 1f44ed7c1b1c..e92e6b03333a 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi >> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >> @@ -1009,6 +1009,17 @@ >> resets = <&cpg 615>; >> }; >> >> + vspb: vsp@fe960000 { >> + compatible = "renesas,vsp2"; >> + reg = <0 0xfe960000 0 0x8000>; >> + interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 626>; >> + power-domains = <&sysc R8A77965_PD_A3VP>; >> + resets = <&cpg 626>; >> + >> + renesas,fcp = <&fcpvb0>; >> + }; >> + >> fcpvb0: fcp@fe96f000 { >> compatible = "renesas,fcpv"; >> reg = <0 0xfe96f000 0 0x200>; >> @@ -1017,6 +1028,17 @@ >> resets = <&cpg 607>; >> }; >> >> + vspi0: vsp@fe9a0000 { >> + compatible = "renesas,vsp2"; >> + reg = <0 0xfe9a0000 0 0x8000>; >> + interrupts = <GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 631>; >> + power-domains = <&sysc R8A77965_PD_A3VP>; >> + resets = <&cpg 631>; >> + >> + renesas,fcp = <&fcpvi0>; >> + }; >> + >> fcpvi0: fcp@fe9af000 { >> compatible = "renesas,fcpv"; >> reg = <0 0xfe9af000 0 0x200>; >> @@ -1025,6 +1047,17 @@ >> resets = <&cpg 611>; >> }; >> >> + vspd0: vsp@fea20000 { >> + compatible = "renesas,vsp2"; >> + reg = <0 0xfea20000 0 0x4000>; > > RFP2 has a CLUT so the register range needs to be extended. I'd recommend > covering the entire space (0x8000) even if no LUT or CLU module is present. Ah yes, of course. Updated. > >> + interrupts = <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 623>; >> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; >> + resets = <&cpg 623>; >> + >> + renesas,fcp = <&fcpvd0>; >> + }; >> + >> fcpvd0: fcp@fea27000 { >> compatible = "renesas,fcpv"; >> reg = <0 0xfea27000 0 0x200>; >> @@ -1033,6 +1066,17 @@ >> resets = <&cpg 603>; >> }; >> >> + vspd1: vsp@fea28000 { >> + compatible = "renesas,vsp2"; >> + reg = <0 0xfea28000 0 0x4000>; > > Same here. > And here... > With this fixed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Collected. -- Kieran > >> + interrupts = <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 622>; >> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; >> + resets = <&cpg 622>; >> + >> + renesas,fcp = <&fcpvd1>; >> + }; >> + >> fcpvd1: fcp@fea2f000 { >> compatible = "renesas,fcpv"; >> reg = <0 0xfea2f000 0 0x200>; > >
WARNING: multiple messages have this Message-ID (diff)
From: kieran.bingham+renesas@ideasonboard.com (Kieran Bingham) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances Date: Fri, 27 Apr 2018 17:33:46 +0100 [thread overview] Message-ID: <81161c97-2be8-2b5a-14a2-3db8709f5ff7@ideasonboard.com> (raw) In-Reply-To: <1787243.JuNJAuBqMb@avalon> Hi Laurent, On 26/04/18 22:11, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday, 26 April 2018 19:53:40 EEST Kieran Bingham wrote: >> The r8a77965 has 4 VSP instances. >> >> Based on a similar patch of the R8A7796 device tree >> by Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>. >> >> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> >> [Kieran: Rebased to top of tree, fixed sort orders] >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >> --- >> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 44 +++++++++++++++++++++++ >> 1 file changed, 44 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi >> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index >> 1f44ed7c1b1c..e92e6b03333a 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi >> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi >> @@ -1009,6 +1009,17 @@ >> resets = <&cpg 615>; >> }; >> >> + vspb: vsp at fe960000 { >> + compatible = "renesas,vsp2"; >> + reg = <0 0xfe960000 0 0x8000>; >> + interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 626>; >> + power-domains = <&sysc R8A77965_PD_A3VP>; >> + resets = <&cpg 626>; >> + >> + renesas,fcp = <&fcpvb0>; >> + }; >> + >> fcpvb0: fcp at fe96f000 { >> compatible = "renesas,fcpv"; >> reg = <0 0xfe96f000 0 0x200>; >> @@ -1017,6 +1028,17 @@ >> resets = <&cpg 607>; >> }; >> >> + vspi0: vsp at fe9a0000 { >> + compatible = "renesas,vsp2"; >> + reg = <0 0xfe9a0000 0 0x8000>; >> + interrupts = <GIC_SPI 444 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 631>; >> + power-domains = <&sysc R8A77965_PD_A3VP>; >> + resets = <&cpg 631>; >> + >> + renesas,fcp = <&fcpvi0>; >> + }; >> + >> fcpvi0: fcp at fe9af000 { >> compatible = "renesas,fcpv"; >> reg = <0 0xfe9af000 0 0x200>; >> @@ -1025,6 +1047,17 @@ >> resets = <&cpg 611>; >> }; >> >> + vspd0: vsp at fea20000 { >> + compatible = "renesas,vsp2"; >> + reg = <0 0xfea20000 0 0x4000>; > > RFP2 has a CLUT so the register range needs to be extended. I'd recommend > covering the entire space (0x8000) even if no LUT or CLU module is present. Ah yes, of course. Updated. > >> + interrupts = <GIC_SPI 466 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 623>; >> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; >> + resets = <&cpg 623>; >> + >> + renesas,fcp = <&fcpvd0>; >> + }; >> + >> fcpvd0: fcp at fea27000 { >> compatible = "renesas,fcpv"; >> reg = <0 0xfea27000 0 0x200>; >> @@ -1033,6 +1066,17 @@ >> resets = <&cpg 603>; >> }; >> >> + vspd1: vsp at fea28000 { >> + compatible = "renesas,vsp2"; >> + reg = <0 0xfea28000 0 0x4000>; > > Same here. > And here... > With this fixed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Collected. -- Kieran > >> + interrupts = <GIC_SPI 467 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&cpg CPG_MOD 622>; >> + power-domains = <&sysc R8A77965_PD_ALWAYS_ON>; >> + resets = <&cpg 622>; >> + >> + renesas,fcp = <&fcpvd1>; >> + }; >> + >> fcpvd1: fcp at fea2f000 { >> compatible = "renesas,fcpv"; >> reg = <0 0xfea2f000 0 0x200>; > >
next prev parent reply other threads:[~2018-04-27 16:33 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-26 16:53 [PATCH 00/17] r8a77965: M3-N DU Enablement Kieran Bingham 2018-04-26 16:53 ` [PATCH 01/17] dt-bindings: display: renesas: du: Increase indent in output table Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:08 ` Laurent Pinchart 2018-04-26 20:08 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 02/17] dt-bindings: display: renesas: du: Document the R8A77965 bindings Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:57 ` Kieran Bingham 2018-04-26 16:57 ` Kieran Bingham 2018-04-26 20:10 ` Laurent Pinchart 2018-04-26 20:10 ` Laurent Pinchart 2018-04-27 8:40 ` Kieran Bingham 2018-04-27 8:40 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 03/17] pinctrl: sh-pfc: r8a77965: Add DU RGB output pins, groups and functions Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:16 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 04/17] drm: rcar-du: Use the correct naming for ODPM fields in DEFR6 Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:18 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 05/17] drm: rcar-du: Split CRTC handling to support hardware indexing Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:30 ` Laurent Pinchart 2018-04-26 20:30 ` Laurent Pinchart 2018-04-27 10:15 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 06/17] drm: rcar-du: Allow DU groups to work with " Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:36 ` Laurent Pinchart 2018-04-26 20:36 ` Laurent Pinchart 2018-04-27 10:10 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 07/17] drm: rcar-du: Add R8A77965 support Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:43 ` Laurent Pinchart 2018-04-26 20:43 ` Laurent Pinchart 2018-04-27 10:14 ` Kieran Bingham 2018-04-27 10:14 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 08/17] arm64: dts: r8a77965: Provide sysc header definitions Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 20:53 ` Laurent Pinchart 2018-04-26 20:53 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 09/17] arm64: dts: r8a77965: Use the correct CPG header Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:16 ` Laurent Pinchart 2018-04-26 21:16 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 10/17] arm64: dts: r8a77965: Add FCPF and FCPV instances Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:06 ` Laurent Pinchart 2018-04-26 21:06 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 11/17] arm64: dts: r8a77965: Add VSP instances Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:11 ` Laurent Pinchart 2018-04-26 21:11 ` Laurent Pinchart 2018-04-27 16:33 ` Kieran Bingham [this message] 2018-04-27 16:33 ` Kieran Bingham 2018-06-08 9:29 ` Geert Uytterhoeven 2018-06-08 9:29 ` Geert Uytterhoeven 2018-06-08 11:00 ` Laurent Pinchart 2018-06-08 11:00 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 12/17] arm64: dts: r8a77965: Populate the DU instance placeholder Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:15 ` Laurent Pinchart 2018-04-26 21:15 ` Laurent Pinchart 2018-04-27 16:34 ` Kieran Bingham 2018-04-27 16:34 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 13/17] arm64: dts: r8a77965: Add HDMI encoder instance Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:17 ` Laurent Pinchart 2018-04-26 21:17 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 14/17] arm64: dts: r8a77965-salvator-x: Add DU external dot clocks Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:18 ` Laurent Pinchart 2018-04-26 21:18 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:21 ` Laurent Pinchart 2018-04-26 21:21 ` Laurent Pinchart 2018-04-27 16:22 ` Kieran Bingham 2018-04-27 16:22 ` Kieran Bingham 2018-04-26 16:53 ` [PATCH 16/17] arm64: dts: r8a77965-salvator-xs: Add DU external dot clocks Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:22 ` Laurent Pinchart 2018-04-26 21:22 ` Laurent Pinchart 2018-04-26 16:53 ` [PATCH 17/17] arm64: dts: r8a77965-salvator-xs: Enable HDMI output Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 16:53 ` Kieran Bingham 2018-04-26 21:23 ` [PATCH 00/17] r8a77965: M3-N DU Enablement Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=81161c97-2be8-2b5a-14a2-3db8709f5ff7@ideasonboard.com \ --to=kieran.bingham+renesas@ideasonboard.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=horms@verge.net.au \ --cc=kieran.bingham@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=takeshi.kihara.df@renesas.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.