From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Jessica Zhang <quic_jesszhan@quicinc.com>, freedreno@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, dri-devel@lists.freedesktop.org, Konrad Dybcio <konrad.dybcio@linaro.org>, Marijn Suijten <marijn.suijten@somainline.org>, Sean Paul <sean@poorly.run> Subject: Re: [PATCH RFC 1/5] drm/display/dsc: Add flatness and initial scale value calculations Date: Thu, 30 Mar 2023 02:25:59 +0300 [thread overview] Message-ID: <5b713a38-2f3c-05b4-b243-6d9c0bd9e728@linaro.org> (raw) In-Reply-To: <20230329-rfc-msm-dsc-helper-v1-1-f3e479f59b6d@quicinc.com> On 30/03/2023 02:18, Jessica Zhang wrote: > Add helpers to calculate det_thresh_flatness and initial_scale_value as > these calculations are defined within the DSC spec. > > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > include/drm/display/drm_dsc_helper.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/drm/display/drm_dsc_helper.h b/include/drm/display/drm_dsc_helper.h > index 4448c482b092..63175650a45e 100644 > --- a/include/drm/display/drm_dsc_helper.h > +++ b/include/drm/display/drm_dsc_helper.h > @@ -17,6 +17,16 @@ enum drm_dsc_params_kind { > DRM_DSC_1_2_420, > }; > > +static inline int drm_dsc_calculate_initial_scale_value(struct drm_dsc_config *dsc) > +{ > + return 8 * dsc->rc_model_size / (dsc->rc_model_size - dsc->initial_offset); Just set this in drm_dsc_config, like other functions do. > +} > + > +static inline int drm_dsc_calculate_det_thresh_flatness(struct drm_dsc_config *dsc) > +{ > + return 2 << (dsc->bits_per_component - 8); > +} this is flatness_det_thresh, per the standard. Otherwise LGTM > + > void drm_dsc_dp_pps_header_init(struct dp_sdp_header *pps_header); > int drm_dsc_dp_rc_buffer_size(u8 rc_buffer_block_size, u8 rc_buffer_size); > void drm_dsc_pps_payload_pack(struct drm_dsc_picture_parameter_set *pps_sdp, > -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Jessica Zhang <quic_jesszhan@quicinc.com>, freedreno@lists.freedesktop.org Cc: Marijn Suijten <marijn.suijten@somainline.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Daniel Vetter <daniel@ffwll.ch>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Sean Paul <sean@poorly.run>, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH RFC 1/5] drm/display/dsc: Add flatness and initial scale value calculations Date: Thu, 30 Mar 2023 02:25:59 +0300 [thread overview] Message-ID: <5b713a38-2f3c-05b4-b243-6d9c0bd9e728@linaro.org> (raw) In-Reply-To: <20230329-rfc-msm-dsc-helper-v1-1-f3e479f59b6d@quicinc.com> On 30/03/2023 02:18, Jessica Zhang wrote: > Add helpers to calculate det_thresh_flatness and initial_scale_value as > these calculations are defined within the DSC spec. > > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> > --- > include/drm/display/drm_dsc_helper.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/drm/display/drm_dsc_helper.h b/include/drm/display/drm_dsc_helper.h > index 4448c482b092..63175650a45e 100644 > --- a/include/drm/display/drm_dsc_helper.h > +++ b/include/drm/display/drm_dsc_helper.h > @@ -17,6 +17,16 @@ enum drm_dsc_params_kind { > DRM_DSC_1_2_420, > }; > > +static inline int drm_dsc_calculate_initial_scale_value(struct drm_dsc_config *dsc) > +{ > + return 8 * dsc->rc_model_size / (dsc->rc_model_size - dsc->initial_offset); Just set this in drm_dsc_config, like other functions do. > +} > + > +static inline int drm_dsc_calculate_det_thresh_flatness(struct drm_dsc_config *dsc) > +{ > + return 2 << (dsc->bits_per_component - 8); > +} this is flatness_det_thresh, per the standard. Otherwise LGTM > + > void drm_dsc_dp_pps_header_init(struct dp_sdp_header *pps_header); > int drm_dsc_dp_rc_buffer_size(u8 rc_buffer_block_size, u8 rc_buffer_size); > void drm_dsc_pps_payload_pack(struct drm_dsc_picture_parameter_set *pps_sdp, > -- With best wishes Dmitry
next prev parent reply other threads:[~2023-03-29 23:26 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-29 23:18 [PATCH RFC 0/5] Introduce MSM-specific DSC helpers Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-29 23:18 ` [PATCH RFC 1/5] drm/display/dsc: Add flatness and initial scale value calculations Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-29 23:25 ` Dmitry Baryshkov [this message] 2023-03-29 23:25 ` Dmitry Baryshkov 2023-03-29 23:47 ` Jessica Zhang 2023-03-29 23:47 ` Jessica Zhang 2023-03-29 23:18 ` [PATCH RFC 2/5] drm/msm: Add MSM-specific DSC helper methods Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-30 0:40 ` Dmitry Baryshkov 2023-03-30 0:40 ` Dmitry Baryshkov 2023-03-30 23:06 ` [Freedreno] " Jessica Zhang 2023-03-30 23:06 ` Jessica Zhang 2023-03-30 0:49 ` Dmitry Baryshkov 2023-03-30 0:49 ` Dmitry Baryshkov 2023-03-29 23:18 ` [PATCH RFC 3/5] drm/msm/dpu: Use DRM DSC helper for det_thresh_flatness Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-29 23:31 ` Dmitry Baryshkov 2023-03-29 23:31 ` Dmitry Baryshkov 2023-03-29 23:45 ` Jessica Zhang 2023-03-29 23:45 ` Jessica Zhang 2023-03-29 23:51 ` Dmitry Baryshkov 2023-03-29 23:51 ` Dmitry Baryshkov 2023-03-29 23:18 ` [PATCH RFC 4/5] drm/msm/dpu: Fix slice_last_group_size calculation Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-29 23:33 ` Dmitry Baryshkov 2023-03-29 23:33 ` Dmitry Baryshkov 2023-03-29 23:18 ` [PATCH RFC 5/5] drm/msm/dsi: Use MSM and DRM DSC helper methods Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-29 23:48 ` Dmitry Baryshkov 2023-03-29 23:48 ` Dmitry Baryshkov 2023-03-30 22:49 ` Jessica Zhang 2023-03-30 22:49 ` Jessica Zhang 2023-03-30 23:14 ` Dmitry Baryshkov 2023-03-30 23:14 ` Dmitry Baryshkov 2023-03-31 0:07 ` Jessica Zhang 2023-03-31 0:07 ` Jessica Zhang 2023-03-31 0:16 ` Dmitry Baryshkov 2023-03-31 0:16 ` Dmitry Baryshkov 2023-03-31 1:12 ` Jessica Zhang 2023-03-31 1:12 ` Jessica Zhang 2023-03-31 1:18 ` Konrad Dybcio 2023-03-31 1:18 ` Konrad Dybcio 2023-03-31 1:25 ` Dmitry Baryshkov 2023-03-31 1:25 ` Dmitry Baryshkov 2023-03-31 1:31 ` Abhinav Kumar 2023-03-31 1:31 ` Abhinav Kumar 2023-03-31 1:33 ` [Freedreno] " Abhinav Kumar 2023-03-31 1:33 ` Abhinav Kumar 2023-03-31 2:47 ` Dmitry Baryshkov 2023-03-31 2:47 ` Dmitry Baryshkov 2023-03-31 4:57 ` Abhinav Kumar 2023-03-31 4:57 ` Abhinav Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5b713a38-2f3c-05b4-b243-6d9c0bd9e728@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=konrad.dybcio@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=marijn.suijten@somainline.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_jesszhan@quicinc.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.