From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Jessica Zhang <quic_jesszhan@quicinc.com>, freedreno@lists.freedesktop.org Cc: Marijn Suijten <marijn.suijten@somainline.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Daniel Vetter <daniel@ffwll.ch>, Rob Clark <robdclark@gmail.com>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Sean Paul <sean@poorly.run>, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH RFC 4/5] drm/msm/dpu: Fix slice_last_group_size calculation Date: Thu, 30 Mar 2023 02:33:29 +0300 [thread overview] Message-ID: <5b80d59c-7c61-44ca-19a0-d319433fd328@linaro.org> (raw) In-Reply-To: <20230329-rfc-msm-dsc-helper-v1-4-f3e479f59b6d@quicinc.com> On 30/03/2023 02:18, Jessica Zhang wrote: > Correct the math for slice_last_group_size so that it matches the > calculations downstream. > > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > index 648c530b5d05..1a1a0f6523f6 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > @@ -56,7 +56,11 @@ static void dpu_hw_dsc_config(struct dpu_hw_dsc *hw_dsc, > if (is_cmd_mode) > initial_lines += 1; > > - slice_last_group_size = 3 - (dsc->slice_width % 3); > + slice_last_group_size = dsc->slice_width % 3; > + > + if (slice_last_group_size == 0) > + slice_last_group_size = 3; > + > data = (initial_lines << 20); > data |= ((slice_last_group_size - 1) << 18); > /* bpp is 6.4 format, 4 LSBs bits are for fractional part */ > -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Jessica Zhang <quic_jesszhan@quicinc.com>, freedreno@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, dri-devel@lists.freedesktop.org, Konrad Dybcio <konrad.dybcio@linaro.org>, Marijn Suijten <marijn.suijten@somainline.org>, Sean Paul <sean@poorly.run> Subject: Re: [PATCH RFC 4/5] drm/msm/dpu: Fix slice_last_group_size calculation Date: Thu, 30 Mar 2023 02:33:29 +0300 [thread overview] Message-ID: <5b80d59c-7c61-44ca-19a0-d319433fd328@linaro.org> (raw) In-Reply-To: <20230329-rfc-msm-dsc-helper-v1-4-f3e479f59b6d@quicinc.com> On 30/03/2023 02:18, Jessica Zhang wrote: > Correct the math for slice_last_group_size so that it matches the > calculations downstream. > > Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com> Fixes: c110cfd1753e ("drm/msm/disp/dpu1: Add support for DSC") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > index 648c530b5d05..1a1a0f6523f6 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c > @@ -56,7 +56,11 @@ static void dpu_hw_dsc_config(struct dpu_hw_dsc *hw_dsc, > if (is_cmd_mode) > initial_lines += 1; > > - slice_last_group_size = 3 - (dsc->slice_width % 3); > + slice_last_group_size = dsc->slice_width % 3; > + > + if (slice_last_group_size == 0) > + slice_last_group_size = 3; > + > data = (initial_lines << 20); > data |= ((slice_last_group_size - 1) << 18); > /* bpp is 6.4 format, 4 LSBs bits are for fractional part */ > -- With best wishes Dmitry
next prev parent reply other threads:[~2023-03-29 23:33 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-29 23:18 [PATCH RFC 0/5] Introduce MSM-specific DSC helpers Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-29 23:18 ` [PATCH RFC 1/5] drm/display/dsc: Add flatness and initial scale value calculations Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-29 23:25 ` Dmitry Baryshkov 2023-03-29 23:25 ` Dmitry Baryshkov 2023-03-29 23:47 ` Jessica Zhang 2023-03-29 23:47 ` Jessica Zhang 2023-03-29 23:18 ` [PATCH RFC 2/5] drm/msm: Add MSM-specific DSC helper methods Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-30 0:40 ` Dmitry Baryshkov 2023-03-30 0:40 ` Dmitry Baryshkov 2023-03-30 23:06 ` [Freedreno] " Jessica Zhang 2023-03-30 23:06 ` Jessica Zhang 2023-03-30 0:49 ` Dmitry Baryshkov 2023-03-30 0:49 ` Dmitry Baryshkov 2023-03-29 23:18 ` [PATCH RFC 3/5] drm/msm/dpu: Use DRM DSC helper for det_thresh_flatness Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-29 23:31 ` Dmitry Baryshkov 2023-03-29 23:31 ` Dmitry Baryshkov 2023-03-29 23:45 ` Jessica Zhang 2023-03-29 23:45 ` Jessica Zhang 2023-03-29 23:51 ` Dmitry Baryshkov 2023-03-29 23:51 ` Dmitry Baryshkov 2023-03-29 23:18 ` [PATCH RFC 4/5] drm/msm/dpu: Fix slice_last_group_size calculation Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-29 23:33 ` Dmitry Baryshkov [this message] 2023-03-29 23:33 ` Dmitry Baryshkov 2023-03-29 23:18 ` [PATCH RFC 5/5] drm/msm/dsi: Use MSM and DRM DSC helper methods Jessica Zhang 2023-03-29 23:18 ` Jessica Zhang 2023-03-29 23:48 ` Dmitry Baryshkov 2023-03-29 23:48 ` Dmitry Baryshkov 2023-03-30 22:49 ` Jessica Zhang 2023-03-30 22:49 ` Jessica Zhang 2023-03-30 23:14 ` Dmitry Baryshkov 2023-03-30 23:14 ` Dmitry Baryshkov 2023-03-31 0:07 ` Jessica Zhang 2023-03-31 0:07 ` Jessica Zhang 2023-03-31 0:16 ` Dmitry Baryshkov 2023-03-31 0:16 ` Dmitry Baryshkov 2023-03-31 1:12 ` Jessica Zhang 2023-03-31 1:12 ` Jessica Zhang 2023-03-31 1:18 ` Konrad Dybcio 2023-03-31 1:18 ` Konrad Dybcio 2023-03-31 1:25 ` Dmitry Baryshkov 2023-03-31 1:25 ` Dmitry Baryshkov 2023-03-31 1:31 ` Abhinav Kumar 2023-03-31 1:31 ` Abhinav Kumar 2023-03-31 1:33 ` [Freedreno] " Abhinav Kumar 2023-03-31 1:33 ` Abhinav Kumar 2023-03-31 2:47 ` Dmitry Baryshkov 2023-03-31 2:47 ` Dmitry Baryshkov 2023-03-31 4:57 ` Abhinav Kumar 2023-03-31 4:57 ` Abhinav Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5b80d59c-7c61-44ca-19a0-d319433fd328@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=konrad.dybcio@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=marijn.suijten@somainline.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_jesszhan@quicinc.com \ --cc=robdclark@gmail.com \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.