Re: [kvm-unit-tests PATCH v2 6/5] x86/run: support accelerator controls

From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>, kvm@vger.kernel.org
Cc: Drew Jones <drjones@redhat.com>,
	Laurent Vivier <lvivier@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	David Hildenbrand <david@redhat.com>
Subject: Re: [kvm-unit-tests PATCH v2 6/5] x86/run: support accelerator controls
Date: Fri, 30 Jun 2017 12:42:14 +0200	[thread overview]
Message-ID: <5b88d828-ea64-5e28-a5bf-4156f2dc744c@redhat.com> (raw)
In-Reply-To: <20170629143215.13801-1-rkrcmar@redhat.com>

Applied both, thanks.

Paolo

On 29/06/2017 16:32, Radim Krčmář wrote:
> It's easy to support and we do have the option for other architectures.
> 
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
>  x86/run | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/x86/run b/x86/run
> index f319b68ef693..e59c6c590a20 100755
> --- a/x86/run
> +++ b/x86/run
> @@ -9,6 +9,9 @@ if [ -z "$STANDALONE" ]; then
>  	source scripts/arch-run.bash
>  fi
>  
> +ACCEL=$(get_qemu_accelerator) ||
> +	exit $?
> +
>  qemu=$(search_qemu_binary) ||
>  	exit $?
>  
> @@ -34,8 +37,8 @@ else
>  	pc_testdev="-device testdev,chardev=testlog -chardev file,id=testlog,path=msr.out"
>  fi
>  
> -command="${qemu} -nodefaults -enable-kvm $pc_testdev -vnc none -serial stdio $pci_testdev $hyperv_testdev"
> -command+=" -kernel"
> +command="${qemu} -nodefaults $pc_testdev -vnc none -serial stdio $pci_testdev $hyperv_testdev"
> +command+=" -machine accel=$ACCEL -kernel"
>  command="$(timeout_cmd) $command"
>  
>  run_qemu ${command} "$@"
> 