From: Andrew Jones <drjones@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 0/5] Minor fixes while getting rid of code duplication
Date: Thu, 29 Jun 2017 13:41:41 +0200 [thread overview]
Message-ID: <20170629114141.rd4d5ga755aezvzq@kamzik.brq.redhat.com> (raw)
In-Reply-To: <20170628200857.1718-1-rkrcmar@redhat.com>
On Wed, Jun 28, 2017 at 10:08:52PM +0200, Radim Krčmář wrote:
> The series isn't well split, so patches remove the code duplication and
> fix bugs at the same time. [3/5] is s390x+powerpc specific, but has
> dependency on [4/5], which affects all architectures, just like [1,5/5].
> [2/5] is unrelated, but was simple enough to include.
>
>
> Radim Krčmář (5):
> arch/run: simplify copy-paste of the command line
> run_tests: add summary to powerpc and s390
> s390+powerpc/run: improve output handling
> scripts/arch-run: fix qemu binary search failure path
> arch/run: unify accelerator detection
>
> arm/run | 28 +++------------------
> powerpc/run | 41 ++++--------------------------
> s390x/run | 38 +++-------------------------
> scripts/arch-run.bash | 69 +++++++++++++++++++++++++++++++++++++++++++++++----
> scripts/runtime.bash | 2 +-
> x86/run | 8 +++---
> 6 files changed, 81 insertions(+), 105 deletions(-)
>
> --
> 2.13.2
>
With Paolo's fixups, the series looks good to me. For the series
Reviewed-by: Andrew Jones <drjones@redhat.com>
prev parent reply other threads:[~2017-06-29 11:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 20:08 [kvm-unit-tests PATCH 0/5] Minor fixes while getting rid of code duplication Radim Krčmář
2017-06-28 20:08 ` [kvm-unit-tests PATCH 1/5] arch/run: simplify copy-paste of the command line Radim Krčmář
2017-06-28 20:08 ` [kvm-unit-tests PATCH 2/5] run_tests: add summary to powerpc and s390 Radim Krčmář
2017-06-29 5:30 ` Thomas Huth
2017-06-29 12:53 ` Radim Krčmář
2017-06-28 20:08 ` [kvm-unit-tests PATCH 3/5] s390+powerpc/run: improve output handling Radim Krčmář
2017-06-28 20:08 ` [kvm-unit-tests PATCH 4/5] scripts/arch-run: fix qemu binary search failure path Radim Krčmář
2017-06-28 20:46 ` Paolo Bonzini
2017-06-29 12:32 ` Radim Krčmář
2017-06-28 20:08 ` [kvm-unit-tests PATCH 5/5] arch/run: unify accelerator detection Radim Krčmář
2017-06-28 20:48 ` Paolo Bonzini
2017-06-29 12:45 ` Radim Krčmář
2017-06-29 13:46 ` Radim Krčmář
2017-06-29 13:49 ` Paolo Bonzini
2017-06-29 14:28 ` [kvm-unit-tests PATCH v2 " Radim Krčmář
2017-06-29 14:32 ` [kvm-unit-tests PATCH v2 6/5] x86/run: support accelerator controls Radim Krčmář
2017-06-30 10:42 ` Paolo Bonzini
2017-06-29 11:41 ` Andrew Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629114141.rd4d5ga755aezvzq@kamzik.brq.redhat.com \
--to=drjones@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.