From: Alexandre Torgue <alexandre.torgue@st.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com
Cc: devicetree@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@st.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/4] Add support of STM32 hwspinlock
Date: Mon, 3 Dec 2018 09:46:03 +0100 [thread overview]
Message-ID: <5c137862-e8fa-abb4-d931-f5c63db50649@st.com> (raw)
In-Reply-To: <20181112152342.6561-1-benjamin.gaignard@st.com>
Hi Benjamin,
On 11/12/18 4:23 PM, Benjamin Gaignard wrote:
> This serie adds the support of the hardware semaphore block for stm32mp1 SoC.
>
> version 3:
> - fix clock name in properties description.
> - use postcore_initcall() instead of module_platform_driver()
>
> version 2:
> - fix comments done by Bjorn about clock naming, license terms in header,
> alphabetic ordering in Makefile and Kconfig and remove function
> - Do not push test module in this version while waiting for feedbacks about it
>
>
> Benjamin Gaignard (4):
> dt-bindings: hwlock: Document STM32 hwspinlock bindings
> hwspinlock: add STM32 hwspinlock device
> ARM: dts: stm32: Add hwspinlock node for stm32mp157 SoC
> ARM: dts: stm32: enable hwspinlock on stm32mp157c-ed1
>
> .../bindings/hwlock/st,stm32-hwspinlock.txt | 23 +++
> arch/arm/boot/dts/stm32mp157c-ed1.dts | 4 +
> arch/arm/boot/dts/stm32mp157c.dtsi | 9 ++
> drivers/hwspinlock/Kconfig | 9 ++
> drivers/hwspinlock/Makefile | 1 +
> drivers/hwspinlock/stm32_hwspinlock.c | 156 +++++++++++++++++++++
> 6 files changed, 202 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt
> create mode 100644 drivers/hwspinlock/stm32_hwspinlock.c
>
There is a (strong) dependency between pinctrl and hsem.
As our pin controller is enabled by default, it's better to enable also
your hwspinlock device by default. It will avoid pin controller probe
defer and a no stable behavior. So, I gonna remove DT patches from
stm32-next. Those Dt patches will not be included in my 4.20 pull-request.
regards
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Torgue <alexandre.torgue@st.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
<ohad@wizery.com>, <bjorn.andersson@linaro.org>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>
Cc: <devicetree@vger.kernel.org>,
Benjamin Gaignard <benjamin.gaignard@st.com>,
<linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 0/4] Add support of STM32 hwspinlock
Date: Mon, 3 Dec 2018 09:46:03 +0100 [thread overview]
Message-ID: <5c137862-e8fa-abb4-d931-f5c63db50649@st.com> (raw)
In-Reply-To: <20181112152342.6561-1-benjamin.gaignard@st.com>
Hi Benjamin,
On 11/12/18 4:23 PM, Benjamin Gaignard wrote:
> This serie adds the support of the hardware semaphore block for stm32mp1 SoC.
>
> version 3:
> - fix clock name in properties description.
> - use postcore_initcall() instead of module_platform_driver()
>
> version 2:
> - fix comments done by Bjorn about clock naming, license terms in header,
> alphabetic ordering in Makefile and Kconfig and remove function
> - Do not push test module in this version while waiting for feedbacks about it
>
>
> Benjamin Gaignard (4):
> dt-bindings: hwlock: Document STM32 hwspinlock bindings
> hwspinlock: add STM32 hwspinlock device
> ARM: dts: stm32: Add hwspinlock node for stm32mp157 SoC
> ARM: dts: stm32: enable hwspinlock on stm32mp157c-ed1
>
> .../bindings/hwlock/st,stm32-hwspinlock.txt | 23 +++
> arch/arm/boot/dts/stm32mp157c-ed1.dts | 4 +
> arch/arm/boot/dts/stm32mp157c.dtsi | 9 ++
> drivers/hwspinlock/Kconfig | 9 ++
> drivers/hwspinlock/Makefile | 1 +
> drivers/hwspinlock/stm32_hwspinlock.c | 156 +++++++++++++++++++++
> 6 files changed, 202 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt
> create mode 100644 drivers/hwspinlock/stm32_hwspinlock.c
>
There is a (strong) dependency between pinctrl and hsem.
As our pin controller is enabled by default, it's better to enable also
your hwspinlock device by default. It will avoid pin controller probe
defer and a no stable behavior. So, I gonna remove DT patches from
stm32-next. Those Dt patches will not be included in my 4.20 pull-request.
regards
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Torgue <alexandre.torgue@st.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>,
<ohad@wizery.com>, <bjorn.andersson@linaro.org>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@st.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 0/4] Add support of STM32 hwspinlock
Date: Mon, 3 Dec 2018 09:46:03 +0100 [thread overview]
Message-ID: <5c137862-e8fa-abb4-d931-f5c63db50649@st.com> (raw)
In-Reply-To: <20181112152342.6561-1-benjamin.gaignard@st.com>
Hi Benjamin,
On 11/12/18 4:23 PM, Benjamin Gaignard wrote:
> This serie adds the support of the hardware semaphore block for stm32mp1 SoC.
>
> version 3:
> - fix clock name in properties description.
> - use postcore_initcall() instead of module_platform_driver()
>
> version 2:
> - fix comments done by Bjorn about clock naming, license terms in header,
> alphabetic ordering in Makefile and Kconfig and remove function
> - Do not push test module in this version while waiting for feedbacks about it
>
>
> Benjamin Gaignard (4):
> dt-bindings: hwlock: Document STM32 hwspinlock bindings
> hwspinlock: add STM32 hwspinlock device
> ARM: dts: stm32: Add hwspinlock node for stm32mp157 SoC
> ARM: dts: stm32: enable hwspinlock on stm32mp157c-ed1
>
> .../bindings/hwlock/st,stm32-hwspinlock.txt | 23 +++
> arch/arm/boot/dts/stm32mp157c-ed1.dts | 4 +
> arch/arm/boot/dts/stm32mp157c.dtsi | 9 ++
> drivers/hwspinlock/Kconfig | 9 ++
> drivers/hwspinlock/Makefile | 1 +
> drivers/hwspinlock/stm32_hwspinlock.c | 156 +++++++++++++++++++++
> 6 files changed, 202 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwlock/st,stm32-hwspinlock.txt
> create mode 100644 drivers/hwspinlock/stm32_hwspinlock.c
>
There is a (strong) dependency between pinctrl and hsem.
As our pin controller is enabled by default, it's better to enable also
your hwspinlock device by default. It will avoid pin controller probe
defer and a no stable behavior. So, I gonna remove DT patches from
stm32-next. Those Dt patches will not be included in my 4.20 pull-request.
regards
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-03 8:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 15:23 [PATCH v3 0/4] Add support of STM32 hwspinlock Benjamin Gaignard
2018-11-12 15:23 ` Benjamin Gaignard
2018-11-12 15:23 ` [PATCH v3 1/4] dt-bindings: hwlock: Document STM32 hwspinlock bindings Benjamin Gaignard
2018-11-12 15:23 ` Benjamin Gaignard
2018-11-13 2:13 ` Rob Herring
2018-11-13 2:13 ` Rob Herring
2018-11-13 17:13 ` Bjorn Andersson
2018-11-13 17:13 ` Bjorn Andersson
2018-11-13 2:13 ` Rob Herring
2018-11-13 2:13 ` Rob Herring
2018-11-12 15:23 ` [PATCH v3 2/4] hwspinlock: add STM32 hwspinlock device Benjamin Gaignard
2018-11-12 15:23 ` Benjamin Gaignard
2018-11-12 15:23 ` [PATCH v3 3/4] ARM: dts: stm32: Add hwspinlock node for stm32mp157 SoC Benjamin Gaignard
2018-11-12 15:23 ` Benjamin Gaignard
2018-11-12 15:23 ` [PATCH v3 4/4] ARM: dts: stm32: enable hwspinlock on stm32mp157c-ed1 Benjamin Gaignard
2018-11-12 15:23 ` Benjamin Gaignard
2018-11-13 8:09 ` [PATCH v3 0/4] Add support of STM32 hwspinlock Alexandre Torgue
2018-11-13 8:09 ` Alexandre Torgue
2018-11-13 8:09 ` Alexandre Torgue
2018-12-03 8:46 ` Alexandre Torgue [this message]
2018-12-03 8:46 ` Alexandre Torgue
2018-12-03 8:46 ` Alexandre Torgue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c137862-e8fa-abb4-d931-f5c63db50649@st.com \
--to=alexandre.torgue@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=benjamin.gaignard@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.