All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Bin Liu <b-liu@ti.com>, Mark Rutland <mark.rutland@arm.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, od@zcrc.me
Subject: Re: [PATCH 1/3] dt-bindings: usb: Add usb-phy property to the jz4740-musb node
Date: Sun, 31 Mar 2019 01:41:15 -0500	[thread overview]
Message-ID: <5ca0610d.1c69fb81.44d14.2fff@mx.google.com> (raw)
In-Reply-To: <20190321150956.6629-1-paul@crapouillou.net>

On Thu, Mar 21, 2019 at 04:09:54PM +0100, Paul Cercueil wrote:
> Add a required 'usb-phy' property, to obtain a phandle to the USB PHY
> from devicetree.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  Documentation/devicetree/bindings/usb/ingenic,jz4740-musb.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ingenic,jz4740-musb.txt b/Documentation/devicetree/bindings/usb/ingenic,jz4740-musb.txt
> index 620355cee63f..23213779f193 100644
> --- a/Documentation/devicetree/bindings/usb/ingenic,jz4740-musb.txt
> +++ b/Documentation/devicetree/bindings/usb/ingenic,jz4740-musb.txt
> @@ -8,9 +8,15 @@ Required properties:
>  - interrupt-names: must be "mc"
>  - clocks: phandle to the "udc" clock
>  - clock-names: must be "udc"
> +- usb-phy: phandle to the USB PHY

'phys' is the standard property name now.

>  
>  Example:
>  
> +usb_phy: usb-phy@0 {
> +	compatible = "usb-nop-xceiv";
> +	#phy-cells = <0>;
> +};
> +
>  udc: usb@13040000 {
>  	compatible = "ingenic,jz4740-musb";
>  	reg = <0x13040000 0x10000>;
> @@ -21,4 +27,6 @@ udc: usb@13040000 {
>  
>  	clocks = <&cgu JZ4740_CLK_UDC>;
>  	clock-names = "udc";
> +
> +	usb-phy = <&usb_phy>;
>  };
> -- 
> 2.11.0
> 


WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Bin Liu <b-liu@ti.com>, Mark Rutland <mark.rutland@arm.com>,
	linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, od@zcrc.me
Subject: [1/3] dt-bindings: usb: Add usb-phy property to the jz4740-musb node
Date: Sun, 31 Mar 2019 01:41:15 -0500	[thread overview]
Message-ID: <5ca0610d.1c69fb81.44d14.2fff@mx.google.com> (raw)

On Thu, Mar 21, 2019 at 04:09:54PM +0100, Paul Cercueil wrote:
> Add a required 'usb-phy' property, to obtain a phandle to the USB PHY
> from devicetree.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  Documentation/devicetree/bindings/usb/ingenic,jz4740-musb.txt | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ingenic,jz4740-musb.txt b/Documentation/devicetree/bindings/usb/ingenic,jz4740-musb.txt
> index 620355cee63f..23213779f193 100644
> --- a/Documentation/devicetree/bindings/usb/ingenic,jz4740-musb.txt
> +++ b/Documentation/devicetree/bindings/usb/ingenic,jz4740-musb.txt
> @@ -8,9 +8,15 @@ Required properties:
>  - interrupt-names: must be "mc"
>  - clocks: phandle to the "udc" clock
>  - clock-names: must be "udc"
> +- usb-phy: phandle to the USB PHY

'phys' is the standard property name now.

>  
>  Example:
>  
> +usb_phy: usb-phy@0 {
> +	compatible = "usb-nop-xceiv";
> +	#phy-cells = <0>;
> +};
> +
>  udc: usb@13040000 {
>  	compatible = "ingenic,jz4740-musb";
>  	reg = <0x13040000 0x10000>;
> @@ -21,4 +27,6 @@ udc: usb@13040000 {
>  
>  	clocks = <&cgu JZ4740_CLK_UDC>;
>  	clock-names = "udc";
> +
> +	usb-phy = <&usb_phy>;
>  };
> -- 
> 2.11.0
>

  parent reply	other threads:[~2019-03-31  6:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 15:09 [PATCH 1/3] dt-bindings: usb: Add usb-phy property to the jz4740-musb node Paul Cercueil
2019-03-21 15:09 ` [1/3] " Paul Cercueil
2019-03-21 15:09 ` [PATCH 2/3] usb: musb: jz4740: Let the platform probe the PHY Paul Cercueil
2019-03-21 15:09   ` [2/3] " Paul Cercueil
2019-03-21 15:09 ` [PATCH 3/3] usb: musb: jz4740: obtain USB PHY from devicetree Paul Cercueil
2019-03-21 15:09   ` [3/3] " Paul Cercueil
2019-03-31  6:41 ` Rob Herring [this message]
2019-03-31  6:41   ` [1/3] dt-bindings: usb: Add usb-phy property to the jz4740-musb node Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ca0610d.1c69fb81.44d14.2fff@mx.google.com \
    --to=robh@kernel.org \
    --cc=b-liu@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=od@zcrc.me \
    --cc=paul@crapouillou.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.