From: Paul Cercueil <paul@crapouillou.net> To: Bin Liu <b-liu@ti.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me, Paul Cercueil <paul@crapouillou.net> Subject: [PATCH 2/3] usb: musb: jz4740: Let the platform probe the PHY Date: Thu, 21 Mar 2019 16:09:55 +0100 [thread overview] Message-ID: <20190321150956.6629-2-paul@crapouillou.net> (raw) In-Reply-To: <20190321150956.6629-1-paul@crapouillou.net> By registering a generic USB PHY from within the driver, we may shadow the USB PHY registered by the platform, which might be different. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/usb/musb/jz4740.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c index a60627bf7be3..ad35e09f90bd 100644 --- a/drivers/usb/musb/jz4740.c +++ b/drivers/usb/musb/jz4740.c @@ -74,7 +74,6 @@ static struct musb_hdrc_platform_data jz4740_musb_platform_data = { static int jz4740_musb_init(struct musb *musb) { - usb_phy_generic_register(); musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2); if (IS_ERR(musb->xceiv)) { pr_err("HS UDC: no transceiver configured\n"); @@ -183,7 +182,6 @@ static int jz4740_remove(struct platform_device *pdev) struct jz4740_glue *glue = platform_get_drvdata(pdev); platform_device_unregister(glue->musb); - usb_phy_generic_unregister(pdev); clk_disable_unprepare(glue->clk); return 0; -- 2.11.0
WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net> To: Bin Liu <b-liu@ti.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me, Paul Cercueil <paul@crapouillou.net> Subject: [2/3] usb: musb: jz4740: Let the platform probe the PHY Date: Thu, 21 Mar 2019 16:09:55 +0100 [thread overview] Message-ID: <20190321150956.6629-2-paul@crapouillou.net> (raw) By registering a generic USB PHY from within the driver, we may shadow the USB PHY registered by the platform, which might be different. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/usb/musb/jz4740.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/musb/jz4740.c b/drivers/usb/musb/jz4740.c index a60627bf7be3..ad35e09f90bd 100644 --- a/drivers/usb/musb/jz4740.c +++ b/drivers/usb/musb/jz4740.c @@ -74,7 +74,6 @@ static struct musb_hdrc_platform_data jz4740_musb_platform_data = { static int jz4740_musb_init(struct musb *musb) { - usb_phy_generic_register(); musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2); if (IS_ERR(musb->xceiv)) { pr_err("HS UDC: no transceiver configured\n"); @@ -183,7 +182,6 @@ static int jz4740_remove(struct platform_device *pdev) struct jz4740_glue *glue = platform_get_drvdata(pdev); platform_device_unregister(glue->musb); - usb_phy_generic_unregister(pdev); clk_disable_unprepare(glue->clk); return 0;
next prev parent reply other threads:[~2019-03-21 15:10 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-21 15:09 [PATCH 1/3] dt-bindings: usb: Add usb-phy property to the jz4740-musb node Paul Cercueil 2019-03-21 15:09 ` [1/3] " Paul Cercueil 2019-03-21 15:09 ` Paul Cercueil [this message] 2019-03-21 15:09 ` [2/3] usb: musb: jz4740: Let the platform probe the PHY Paul Cercueil 2019-03-21 15:09 ` [PATCH 3/3] usb: musb: jz4740: obtain USB PHY from devicetree Paul Cercueil 2019-03-21 15:09 ` [3/3] " Paul Cercueil 2019-03-31 6:41 ` [PATCH 1/3] dt-bindings: usb: Add usb-phy property to the jz4740-musb node Rob Herring 2019-03-31 6:41 ` [1/3] " Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190321150956.6629-2-paul@crapouillou.net \ --to=paul@crapouillou.net \ --cc=b-liu@ti.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=od@zcrc.me \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.