From: Christophe Leroy <christophe.leroy@csgroup.eu> To: Sathvika Vasireddy <sv@linux.ibm.com>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org> Cc: "jpoimboe@redhat.com" <jpoimboe@redhat.com>, "peterz@infradead.org" <peterz@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "aik@ozlabs.ru" <aik@ozlabs.ru>, "mpe@ellerman.id.au" <mpe@ellerman.id.au>, "mingo@redhat.com" <mingo@redhat.com>, "rostedt@goodmis.org" <rostedt@goodmis.org>, "mbenes@suse.cz" <mbenes@suse.cz>, "npiggin@gmail.com" <npiggin@gmail.com>, "chenzhongjin@huawei.com" <chenzhongjin@huawei.com>, "naveen.n.rao@linux.vnet.ibm.com" <naveen.n.rao@linux.vnet.ibm.com> Subject: Re: [PATCH v2 16/16] objtool/powerpc: Add --mcount specific implementation Date: Wed, 31 Aug 2022 12:50:07 +0000 [thread overview] Message-ID: <5da86617-53f1-d899-336a-53fe691e76ae@csgroup.eu> (raw) In-Reply-To: <20220829055223.24767-17-sv@linux.ibm.com> Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > This patch enables objtool --mcount on powerpc, and > adds implementation specific to powerpc. > > Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com> > --- > arch/powerpc/Kconfig | 1 + > tools/objtool/arch/powerpc/decode.c | 22 +++++++++++++++++++ > tools/objtool/arch/powerpc/include/arch/elf.h | 2 ++ > 3 files changed, 25 insertions(+) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index dc05cd23c233..6be2e68fa9eb 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -238,6 +238,7 @@ config PPC > select HAVE_NMI if PERF_EVENTS || (PPC64 && PPC_BOOK3S) > select HAVE_OPTPROBES > select HAVE_OBJTOOL if PPC32 || MPROFILE_KERNEL > + select HAVE_OBJTOOL_MCOUNT if HAVE_OBJTOOL > select HAVE_PERF_EVENTS > select HAVE_PERF_EVENTS_NMI if PPC64 > select HAVE_PERF_REGS > diff --git a/tools/objtool/arch/powerpc/decode.c b/tools/objtool/arch/powerpc/decode.c > index 8b6a14680da7..b71c265ed503 100644 > --- a/tools/objtool/arch/powerpc/decode.c > +++ b/tools/objtool/arch/powerpc/decode.c > @@ -9,6 +9,14 @@ > #include <objtool/builtin.h> > #include <objtool/endianness.h> > > +bool arch_ftrace_match(char *name) > +{ > + if (!strcmp(name, "_mcount")) > + return true; > + > + return false; > +} > + > unsigned long arch_dest_reloc_offset(int addend) > { > return addend; > @@ -41,12 +49,26 @@ int arch_decode_instruction(struct objtool_file *file, const struct section *sec > struct list_head *ops_list) > { > u32 insn; > + unsigned int opcode; > > *immediate = 0; > insn = bswap_if_needed(file->elf, *(u32 *)(sec->data->d_buf + offset)); > *len = 4; > *type = INSN_OTHER; > > + opcode = insn >> 26; > + > + switch (opcode) { > + case 18: /* bl */ case 18 is more than 'bl', it includes also 'b'. In both cases, the calculation of *immediate is the same. It would therefore be more correct to perform the calculation and setup of *immediate outside the 'if ((insn & 3) == 1)', that would avoid unnecessary churn the day we add support for branches without link. > + if ((insn & 3) == 1) { > + *type = INSN_CALL; > + *immediate = insn & 0x3fffffc; > + if (*immediate & 0x2000000) > + *immediate -= 0x4000000; > + } > + break; > + } > + > return 0; > } > > diff --git a/tools/objtool/arch/powerpc/include/arch/elf.h b/tools/objtool/arch/powerpc/include/arch/elf.h > index 3c8ebb7d2a6b..73f9ae172fe5 100644 > --- a/tools/objtool/arch/powerpc/include/arch/elf.h > +++ b/tools/objtool/arch/powerpc/include/arch/elf.h > @@ -4,5 +4,7 @@ > #define _OBJTOOL_ARCH_ELF > > #define R_NONE R_PPC_NONE > +#define R_ABS64 R_PPC64_ADDR64 > +#define R_ABS32 R_PPC_ADDR32 > > #endif /* _OBJTOOL_ARCH_ELF */
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu> To: Sathvika Vasireddy <sv@linux.ibm.com>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org> Cc: "peterz@infradead.org" <peterz@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "rostedt@goodmis.org" <rostedt@goodmis.org>, "aik@ozlabs.ru" <aik@ozlabs.ru>, "mingo@redhat.com" <mingo@redhat.com>, "npiggin@gmail.com" <npiggin@gmail.com>, "jpoimboe@redhat.com" <jpoimboe@redhat.com>, "naveen.n.rao@linux.vnet.ibm.com" <naveen.n.rao@linux.vnet.ibm.com>, "mbenes@suse.cz" <mbenes@suse.cz>, "chenzhongjin@huawei.com" <chenzhongjin@huawei.com> Subject: Re: [PATCH v2 16/16] objtool/powerpc: Add --mcount specific implementation Date: Wed, 31 Aug 2022 12:50:07 +0000 [thread overview] Message-ID: <5da86617-53f1-d899-336a-53fe691e76ae@csgroup.eu> (raw) In-Reply-To: <20220829055223.24767-17-sv@linux.ibm.com> Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : > This patch enables objtool --mcount on powerpc, and > adds implementation specific to powerpc. > > Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com> > --- > arch/powerpc/Kconfig | 1 + > tools/objtool/arch/powerpc/decode.c | 22 +++++++++++++++++++ > tools/objtool/arch/powerpc/include/arch/elf.h | 2 ++ > 3 files changed, 25 insertions(+) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index dc05cd23c233..6be2e68fa9eb 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -238,6 +238,7 @@ config PPC > select HAVE_NMI if PERF_EVENTS || (PPC64 && PPC_BOOK3S) > select HAVE_OPTPROBES > select HAVE_OBJTOOL if PPC32 || MPROFILE_KERNEL > + select HAVE_OBJTOOL_MCOUNT if HAVE_OBJTOOL > select HAVE_PERF_EVENTS > select HAVE_PERF_EVENTS_NMI if PPC64 > select HAVE_PERF_REGS > diff --git a/tools/objtool/arch/powerpc/decode.c b/tools/objtool/arch/powerpc/decode.c > index 8b6a14680da7..b71c265ed503 100644 > --- a/tools/objtool/arch/powerpc/decode.c > +++ b/tools/objtool/arch/powerpc/decode.c > @@ -9,6 +9,14 @@ > #include <objtool/builtin.h> > #include <objtool/endianness.h> > > +bool arch_ftrace_match(char *name) > +{ > + if (!strcmp(name, "_mcount")) > + return true; > + > + return false; > +} > + > unsigned long arch_dest_reloc_offset(int addend) > { > return addend; > @@ -41,12 +49,26 @@ int arch_decode_instruction(struct objtool_file *file, const struct section *sec > struct list_head *ops_list) > { > u32 insn; > + unsigned int opcode; > > *immediate = 0; > insn = bswap_if_needed(file->elf, *(u32 *)(sec->data->d_buf + offset)); > *len = 4; > *type = INSN_OTHER; > > + opcode = insn >> 26; > + > + switch (opcode) { > + case 18: /* bl */ case 18 is more than 'bl', it includes also 'b'. In both cases, the calculation of *immediate is the same. It would therefore be more correct to perform the calculation and setup of *immediate outside the 'if ((insn & 3) == 1)', that would avoid unnecessary churn the day we add support for branches without link. > + if ((insn & 3) == 1) { > + *type = INSN_CALL; > + *immediate = insn & 0x3fffffc; > + if (*immediate & 0x2000000) > + *immediate -= 0x4000000; > + } > + break; > + } > + > return 0; > } > > diff --git a/tools/objtool/arch/powerpc/include/arch/elf.h b/tools/objtool/arch/powerpc/include/arch/elf.h > index 3c8ebb7d2a6b..73f9ae172fe5 100644 > --- a/tools/objtool/arch/powerpc/include/arch/elf.h > +++ b/tools/objtool/arch/powerpc/include/arch/elf.h > @@ -4,5 +4,7 @@ > #define _OBJTOOL_ARCH_ELF > > #define R_NONE R_PPC_NONE > +#define R_ABS64 R_PPC64_ADDR64 > +#define R_ABS32 R_PPC_ADDR32 > > #endif /* _OBJTOOL_ARCH_ELF */
next prev parent reply other threads:[~2022-08-31 12:50 UTC|newest] Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-29 5:52 [PATCH v2 00/16] objtool: Enable and implement --mcount option on powerpc Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-29 5:52 ` [PATCH v2 01/16] powerpc: Replace unreachable() with it's builtin variant in __WARN_FLAGS() Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:15 ` Christophe Leroy 2022-08-30 6:15 ` Christophe Leroy 2022-09-05 10:18 ` Naveen N. Rao 2022-09-05 10:18 ` Naveen N. Rao 2022-08-29 5:52 ` [PATCH v2 02/16] powerpc: override __ALIGN() and __ALIGN_STR() macros Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-29 13:26 ` Christophe Leroy 2022-08-29 13:26 ` Christophe Leroy 2022-08-29 14:39 ` Sathvika Vasireddy 2022-08-29 14:39 ` Sathvika Vasireddy 2022-08-31 3:24 ` Nicholas Piggin 2022-08-31 3:24 ` Nicholas Piggin 2022-08-31 7:22 ` Michael Ellerman 2022-08-31 7:22 ` Michael Ellerman 2022-09-05 11:03 ` Peter Zijlstra 2022-09-05 11:03 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 03/16] powerpc: Fix objtool unannotated intra-function call warnings Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:16 ` Christophe Leroy 2022-08-30 6:16 ` Christophe Leroy 2022-08-30 12:42 ` Christophe Leroy 2022-08-30 12:42 ` Christophe Leroy 2022-09-05 11:02 ` Peter Zijlstra 2022-09-05 11:02 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 04/16] powerpc: Curb objtool unannotated intra-function warnings Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:26 ` Christophe Leroy 2022-08-30 6:26 ` Christophe Leroy 2022-08-29 5:52 ` [PATCH v2 05/16] powerpc: Skip objtool from running on drivers/crypto/vmx/aesp8-ppc.o Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:26 ` Christophe Leroy 2022-08-30 6:26 ` Christophe Leroy 2022-09-01 19:17 ` Peter Zijlstra 2022-09-01 19:17 ` Peter Zijlstra 2022-09-05 10:47 ` Naveen N. Rao 2022-09-05 10:47 ` Naveen N. Rao 2022-08-29 5:52 ` [PATCH v2 06/16] powerpc: Fix objtool unannotated intra-function call warnings on PPC32 Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-29 5:52 ` [PATCH v2 07/16] powerpc: Skip objtool from running on VDSO files Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:27 ` Christophe Leroy 2022-08-30 6:27 ` Christophe Leroy 2022-09-01 19:19 ` Peter Zijlstra 2022-09-01 19:19 ` Peter Zijlstra 2022-09-02 7:40 ` Michael Ellerman 2022-09-02 7:40 ` Michael Ellerman 2022-08-29 5:52 ` [PATCH v2 08/16] objtool: Fix SEGFAULT Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-09-01 19:20 ` Peter Zijlstra 2022-09-01 19:20 ` Peter Zijlstra 2022-09-02 8:06 ` Christophe Leroy 2022-09-02 8:06 ` Christophe Leroy 2022-09-02 8:42 ` Peter Zijlstra 2022-09-02 8:42 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 09/16] objtool: Use target file endianness instead of a compiled constant Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-09-01 19:22 ` Peter Zijlstra 2022-09-01 19:22 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 10/16] objtool: Use target file class size " Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-09-01 19:23 ` Peter Zijlstra 2022-09-01 19:23 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 11/16] objtool: Add --mnop as an option to --mcount Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:28 ` Christophe Leroy 2022-08-30 6:28 ` Christophe Leroy 2022-09-01 19:25 ` Peter Zijlstra 2022-09-01 19:25 ` Peter Zijlstra 2022-09-05 10:55 ` Naveen N. Rao 2022-09-05 10:55 ` Naveen N. Rao 2022-08-29 5:52 ` [PATCH v2 12/16] objtool: Read special sections with alts only when specific options are selected Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:31 ` Christophe Leroy 2022-08-30 6:31 ` Christophe Leroy 2022-08-29 5:52 ` [PATCH v2 13/16] objtool: Use macros to define arch specific reloc types Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:33 ` Christophe Leroy 2022-08-30 6:33 ` Christophe Leroy 2022-09-01 19:28 ` Peter Zijlstra 2022-09-01 19:28 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 14/16] objtool: Add arch specific function arch_ftrace_match() Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:36 ` Christophe Leroy 2022-08-30 6:36 ` Christophe Leroy 2022-08-29 5:52 ` [PATCH v2 15/16] objtool/powerpc: Enable objtool to be built on ppc Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:41 ` Christophe Leroy 2022-08-30 6:41 ` Christophe Leroy 2022-09-05 10:37 ` Naveen N. Rao 2022-09-05 10:37 ` Naveen N. Rao 2023-02-04 8:19 ` Randy Dunlap 2023-02-04 8:19 ` Randy Dunlap 2023-02-04 8:21 ` Randy Dunlap 2023-02-04 8:21 ` Randy Dunlap 2023-02-04 8:30 ` Randy Dunlap 2023-02-04 8:30 ` Randy Dunlap 2023-02-04 11:55 ` Christophe Leroy 2023-02-04 11:55 ` Christophe Leroy 2023-02-04 13:10 ` Christophe Leroy 2023-02-04 13:10 ` Christophe Leroy 2023-02-04 15:47 ` Josh Poimboeuf 2023-02-04 15:47 ` Josh Poimboeuf 2022-09-01 9:32 ` Christophe Leroy 2022-09-01 9:32 ` Christophe Leroy 2022-09-01 15:11 ` Segher Boessenkool 2022-09-01 15:11 ` Segher Boessenkool 2022-09-01 16:38 ` Christophe Leroy 2022-09-01 16:38 ` Christophe Leroy 2022-09-01 19:01 ` Peter Zijlstra 2022-09-01 19:01 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 16/16] objtool/powerpc: Add --mcount specific implementation Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:44 ` Christophe Leroy 2022-08-30 6:44 ` Christophe Leroy 2022-08-31 12:50 ` Christophe Leroy [this message] 2022-08-31 12:50 ` Christophe Leroy 2022-08-31 17:51 ` Segher Boessenkool 2022-08-31 17:51 ` Segher Boessenkool 2022-09-05 10:45 ` Naveen N. Rao 2022-09-05 10:45 ` Naveen N. Rao 2022-09-05 20:43 ` Segher Boessenkool 2022-09-05 20:43 ` Segher Boessenkool 2022-09-06 6:22 ` Christophe Leroy 2022-09-06 6:22 ` Christophe Leroy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5da86617-53f1-d899-336a-53fe691e76ae@csgroup.eu \ --to=christophe.leroy@csgroup.eu \ --cc=aik@ozlabs.ru \ --cc=chenzhongjin@huawei.com \ --cc=jpoimboe@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mbenes@suse.cz \ --cc=mingo@redhat.com \ --cc=mpe@ellerman.id.au \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=npiggin@gmail.com \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=sv@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.