From: Christophe Leroy <christophe.leroy@csgroup.eu> To: Segher Boessenkool <segher@kernel.crashing.org> Cc: Sathvika Vasireddy <sv@linux.ibm.com>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, "peterz@infradead.org" <peterz@infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "rostedt@goodmis.org" <rostedt@goodmis.org>, "aik@ozlabs.ru" <aik@ozlabs.ru>, "mingo@redhat.com" <mingo@redhat.com>, "npiggin@gmail.com" <npiggin@gmail.com>, "jpoimboe@redhat.com" <jpoimboe@redhat.com>, "naveen.n.rao@linux.vnet.ibm.com" <naveen.n.rao@linux.vnet.ibm.com>, "mbenes@suse.cz" <mbenes@suse.cz>, "chenzhongjin@huawei.com" <chenzhongjin@huawei.com> Subject: Re: [PATCH v2 15/16] objtool/powerpc: Enable objtool to be built on ppc Date: Thu, 1 Sep 2022 16:38:52 +0000 [thread overview] Message-ID: <e0540fc2-9d38-2fd9-c8c1-a766dfc577d6@csgroup.eu> (raw) In-Reply-To: <20220901151117.GE25951@gate.crashing.org> Le 01/09/2022 à 17:11, Segher Boessenkool a écrit : > On Thu, Sep 01, 2022 at 09:32:46AM +0000, Christophe Leroy wrote: >> Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : >>> +int arch_decode_instruction(struct objtool_file *file, const struct section *sec, >>> + unsigned long offset, unsigned int maxlen, >>> + unsigned int *len, enum insn_type *type, >>> + unsigned long *immediate, >>> + struct list_head *ops_list) >>> +{ >>> + u32 insn; >>> + >>> + *immediate = 0; >>> + insn = bswap_if_needed(file->elf, *(u32 *)(sec->data->d_buf + offset)); >>> + *len = 4; >> >> Should be *len = 8 when insn >> 26 == 1. > > But please use ppc_inst_prefixed(). And just use ppc_inst_len() here? objtool is a userland app, there is no access to kernel headers here. > > Not having convenience abstraction functions like that will give you > much more work in the future -- currently all prefix insns use primary > opcode 1, sure, and nothing else does; but this can change. > Yes most likely. Then we have to rebuild some light abstraction for objtool. Christophe
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@csgroup.eu> To: Segher Boessenkool <segher@kernel.crashing.org> Cc: "peterz@infradead.org" <peterz@infradead.org>, "chenzhongjin@huawei.com" <chenzhongjin@huawei.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "rostedt@goodmis.org" <rostedt@goodmis.org>, "aik@ozlabs.ru" <aik@ozlabs.ru>, "mingo@redhat.com" <mingo@redhat.com>, Sathvika Vasireddy <sv@linux.ibm.com>, "npiggin@gmail.com" <npiggin@gmail.com>, "jpoimboe@redhat.com" <jpoimboe@redhat.com>, "naveen.n.rao@linux.vnet.ibm.com" <naveen.n.rao@linux.vnet.ibm.com>, "mbenes@suse.cz" <mbenes@suse.cz>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org> Subject: Re: [PATCH v2 15/16] objtool/powerpc: Enable objtool to be built on ppc Date: Thu, 1 Sep 2022 16:38:52 +0000 [thread overview] Message-ID: <e0540fc2-9d38-2fd9-c8c1-a766dfc577d6@csgroup.eu> (raw) In-Reply-To: <20220901151117.GE25951@gate.crashing.org> Le 01/09/2022 à 17:11, Segher Boessenkool a écrit : > On Thu, Sep 01, 2022 at 09:32:46AM +0000, Christophe Leroy wrote: >> Le 29/08/2022 à 07:52, Sathvika Vasireddy a écrit : >>> +int arch_decode_instruction(struct objtool_file *file, const struct section *sec, >>> + unsigned long offset, unsigned int maxlen, >>> + unsigned int *len, enum insn_type *type, >>> + unsigned long *immediate, >>> + struct list_head *ops_list) >>> +{ >>> + u32 insn; >>> + >>> + *immediate = 0; >>> + insn = bswap_if_needed(file->elf, *(u32 *)(sec->data->d_buf + offset)); >>> + *len = 4; >> >> Should be *len = 8 when insn >> 26 == 1. > > But please use ppc_inst_prefixed(). And just use ppc_inst_len() here? objtool is a userland app, there is no access to kernel headers here. > > Not having convenience abstraction functions like that will give you > much more work in the future -- currently all prefix insns use primary > opcode 1, sure, and nothing else does; but this can change. > Yes most likely. Then we have to rebuild some light abstraction for objtool. Christophe
next prev parent reply other threads:[~2022-09-01 16:39 UTC|newest] Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-29 5:52 [PATCH v2 00/16] objtool: Enable and implement --mcount option on powerpc Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-29 5:52 ` [PATCH v2 01/16] powerpc: Replace unreachable() with it's builtin variant in __WARN_FLAGS() Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:15 ` Christophe Leroy 2022-08-30 6:15 ` Christophe Leroy 2022-09-05 10:18 ` Naveen N. Rao 2022-09-05 10:18 ` Naveen N. Rao 2022-08-29 5:52 ` [PATCH v2 02/16] powerpc: override __ALIGN() and __ALIGN_STR() macros Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-29 13:26 ` Christophe Leroy 2022-08-29 13:26 ` Christophe Leroy 2022-08-29 14:39 ` Sathvika Vasireddy 2022-08-29 14:39 ` Sathvika Vasireddy 2022-08-31 3:24 ` Nicholas Piggin 2022-08-31 3:24 ` Nicholas Piggin 2022-08-31 7:22 ` Michael Ellerman 2022-08-31 7:22 ` Michael Ellerman 2022-09-05 11:03 ` Peter Zijlstra 2022-09-05 11:03 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 03/16] powerpc: Fix objtool unannotated intra-function call warnings Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:16 ` Christophe Leroy 2022-08-30 6:16 ` Christophe Leroy 2022-08-30 12:42 ` Christophe Leroy 2022-08-30 12:42 ` Christophe Leroy 2022-09-05 11:02 ` Peter Zijlstra 2022-09-05 11:02 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 04/16] powerpc: Curb objtool unannotated intra-function warnings Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:26 ` Christophe Leroy 2022-08-30 6:26 ` Christophe Leroy 2022-08-29 5:52 ` [PATCH v2 05/16] powerpc: Skip objtool from running on drivers/crypto/vmx/aesp8-ppc.o Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:26 ` Christophe Leroy 2022-08-30 6:26 ` Christophe Leroy 2022-09-01 19:17 ` Peter Zijlstra 2022-09-01 19:17 ` Peter Zijlstra 2022-09-05 10:47 ` Naveen N. Rao 2022-09-05 10:47 ` Naveen N. Rao 2022-08-29 5:52 ` [PATCH v2 06/16] powerpc: Fix objtool unannotated intra-function call warnings on PPC32 Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-29 5:52 ` [PATCH v2 07/16] powerpc: Skip objtool from running on VDSO files Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:27 ` Christophe Leroy 2022-08-30 6:27 ` Christophe Leroy 2022-09-01 19:19 ` Peter Zijlstra 2022-09-01 19:19 ` Peter Zijlstra 2022-09-02 7:40 ` Michael Ellerman 2022-09-02 7:40 ` Michael Ellerman 2022-08-29 5:52 ` [PATCH v2 08/16] objtool: Fix SEGFAULT Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-09-01 19:20 ` Peter Zijlstra 2022-09-01 19:20 ` Peter Zijlstra 2022-09-02 8:06 ` Christophe Leroy 2022-09-02 8:06 ` Christophe Leroy 2022-09-02 8:42 ` Peter Zijlstra 2022-09-02 8:42 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 09/16] objtool: Use target file endianness instead of a compiled constant Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-09-01 19:22 ` Peter Zijlstra 2022-09-01 19:22 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 10/16] objtool: Use target file class size " Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-09-01 19:23 ` Peter Zijlstra 2022-09-01 19:23 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 11/16] objtool: Add --mnop as an option to --mcount Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:28 ` Christophe Leroy 2022-08-30 6:28 ` Christophe Leroy 2022-09-01 19:25 ` Peter Zijlstra 2022-09-01 19:25 ` Peter Zijlstra 2022-09-05 10:55 ` Naveen N. Rao 2022-09-05 10:55 ` Naveen N. Rao 2022-08-29 5:52 ` [PATCH v2 12/16] objtool: Read special sections with alts only when specific options are selected Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:31 ` Christophe Leroy 2022-08-30 6:31 ` Christophe Leroy 2022-08-29 5:52 ` [PATCH v2 13/16] objtool: Use macros to define arch specific reloc types Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:33 ` Christophe Leroy 2022-08-30 6:33 ` Christophe Leroy 2022-09-01 19:28 ` Peter Zijlstra 2022-09-01 19:28 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 14/16] objtool: Add arch specific function arch_ftrace_match() Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:36 ` Christophe Leroy 2022-08-30 6:36 ` Christophe Leroy 2022-08-29 5:52 ` [PATCH v2 15/16] objtool/powerpc: Enable objtool to be built on ppc Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:41 ` Christophe Leroy 2022-08-30 6:41 ` Christophe Leroy 2022-09-05 10:37 ` Naveen N. Rao 2022-09-05 10:37 ` Naveen N. Rao 2023-02-04 8:19 ` Randy Dunlap 2023-02-04 8:19 ` Randy Dunlap 2023-02-04 8:21 ` Randy Dunlap 2023-02-04 8:21 ` Randy Dunlap 2023-02-04 8:30 ` Randy Dunlap 2023-02-04 8:30 ` Randy Dunlap 2023-02-04 11:55 ` Christophe Leroy 2023-02-04 11:55 ` Christophe Leroy 2023-02-04 13:10 ` Christophe Leroy 2023-02-04 13:10 ` Christophe Leroy 2023-02-04 15:47 ` Josh Poimboeuf 2023-02-04 15:47 ` Josh Poimboeuf 2022-09-01 9:32 ` Christophe Leroy 2022-09-01 9:32 ` Christophe Leroy 2022-09-01 15:11 ` Segher Boessenkool 2022-09-01 15:11 ` Segher Boessenkool 2022-09-01 16:38 ` Christophe Leroy [this message] 2022-09-01 16:38 ` Christophe Leroy 2022-09-01 19:01 ` Peter Zijlstra 2022-09-01 19:01 ` Peter Zijlstra 2022-08-29 5:52 ` [PATCH v2 16/16] objtool/powerpc: Add --mcount specific implementation Sathvika Vasireddy 2022-08-29 5:52 ` Sathvika Vasireddy 2022-08-30 6:44 ` Christophe Leroy 2022-08-30 6:44 ` Christophe Leroy 2022-08-31 12:50 ` Christophe Leroy 2022-08-31 12:50 ` Christophe Leroy 2022-08-31 17:51 ` Segher Boessenkool 2022-08-31 17:51 ` Segher Boessenkool 2022-09-05 10:45 ` Naveen N. Rao 2022-09-05 10:45 ` Naveen N. Rao 2022-09-05 20:43 ` Segher Boessenkool 2022-09-05 20:43 ` Segher Boessenkool 2022-09-06 6:22 ` Christophe Leroy 2022-09-06 6:22 ` Christophe Leroy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e0540fc2-9d38-2fd9-c8c1-a766dfc577d6@csgroup.eu \ --to=christophe.leroy@csgroup.eu \ --cc=aik@ozlabs.ru \ --cc=chenzhongjin@huawei.com \ --cc=jpoimboe@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mbenes@suse.cz \ --cc=mingo@redhat.com \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=npiggin@gmail.com \ --cc=peterz@infradead.org \ --cc=rostedt@goodmis.org \ --cc=segher@kernel.crashing.org \ --cc=sv@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.