From: Robin Murphy <robin.murphy@arm.com> To: Huacai Chen <chenhc@lemote.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Fuxin Zhang <zhangfx@lemote.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [V5, 2/3] mm: dmapool: Align to ARCH_DMA_MINALIGN in non-coherent DMA mode Date: Mon, 18 Sep 2017 10:44:54 +0100 [thread overview] Message-ID: <601437ae-2860-c48a-aa7c-4da37aeb6256@arm.com> (raw) In-Reply-To: <1505708548-4750-1-git-send-email-chenhc@lemote.com> On 18/09/17 05:22, Huacai Chen wrote: > In non-coherent DMA mode, kernel uses cache flushing operations to > maintain I/O coherency, so the dmapool objects should be aligned to > ARCH_DMA_MINALIGN. Otherwise, it will cause data corruption, at least > on MIPS: > > Step 1, dma_map_single > Step 2, cache_invalidate (no writeback) > Step 3, dma_from_device > Step 4, dma_unmap_single This is a massive red warning flag for the whole series, because DMA pools don't work like that. At best, this will do nothing, and at worst it is papering over egregious bugs elsewhere. Streaming mappings of coherent allocations means completely broken code. > If a DMA buffer and a kernel structure share a same cache line, and if > the kernel structure has dirty data, cache_invalidate (no writeback) > will cause data lost. DMA pools are backed by coherent allocations, and those should already be at *page* granularity, so this doubly cannot happen for correct code. More generally, the whole point of having the DMA APIs is that drivers and subsystems should not have to be aware of details like hardware coherency. Besides, cache line sharing that could pose a correctness issue for non-hardware-coherent systems could still be a performance issue in the presence of hardware coherency (due to unnecessary line migration), so there's still an argument for not treating them differently. Robin. > Cc: stable@vger.kernel.org > Signed-off-by: Huacai Chen <chenhc@lemote.com> > --- > mm/dmapool.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/dmapool.c b/mm/dmapool.c > index 4d90a64..6263905 100644 > --- a/mm/dmapool.c > +++ b/mm/dmapool.c > @@ -140,6 +140,9 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, > else if (align & (align - 1)) > return NULL; > > + if (!device_is_coherent(dev)) > + align = max_t(size_t, align, dma_get_cache_alignment()); > + > if (size == 0) > return NULL; > else if (size < 4) >
WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com> To: Huacai Chen <chenhc@lemote.com> Cc: Andrew Morton <akpm@linux-foundation.org>, Fuxin Zhang <zhangfx@lemote.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [V5, 2/3] mm: dmapool: Align to ARCH_DMA_MINALIGN in non-coherent DMA mode Date: Mon, 18 Sep 2017 10:44:54 +0100 [thread overview] Message-ID: <601437ae-2860-c48a-aa7c-4da37aeb6256@arm.com> (raw) In-Reply-To: <1505708548-4750-1-git-send-email-chenhc@lemote.com> On 18/09/17 05:22, Huacai Chen wrote: > In non-coherent DMA mode, kernel uses cache flushing operations to > maintain I/O coherency, so the dmapool objects should be aligned to > ARCH_DMA_MINALIGN. Otherwise, it will cause data corruption, at least > on MIPS: > > Step 1, dma_map_single > Step 2, cache_invalidate (no writeback) > Step 3, dma_from_device > Step 4, dma_unmap_single This is a massive red warning flag for the whole series, because DMA pools don't work like that. At best, this will do nothing, and at worst it is papering over egregious bugs elsewhere. Streaming mappings of coherent allocations means completely broken code. > If a DMA buffer and a kernel structure share a same cache line, and if > the kernel structure has dirty data, cache_invalidate (no writeback) > will cause data lost. DMA pools are backed by coherent allocations, and those should already be at *page* granularity, so this doubly cannot happen for correct code. More generally, the whole point of having the DMA APIs is that drivers and subsystems should not have to be aware of details like hardware coherency. Besides, cache line sharing that could pose a correctness issue for non-hardware-coherent systems could still be a performance issue in the presence of hardware coherency (due to unnecessary line migration), so there's still an argument for not treating them differently. Robin. > Cc: stable@vger.kernel.org > Signed-off-by: Huacai Chen <chenhc@lemote.com> > --- > mm/dmapool.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/dmapool.c b/mm/dmapool.c > index 4d90a64..6263905 100644 > --- a/mm/dmapool.c > +++ b/mm/dmapool.c > @@ -140,6 +140,9 @@ struct dma_pool *dma_pool_create(const char *name, struct device *dev, > else if (align & (align - 1)) > return NULL; > > + if (!device_is_coherent(dev)) > + align = max_t(size_t, align, dma_get_cache_alignment()); > + > if (size == 0) > return NULL; > else if (size < 4) > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-18 9:45 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-18 4:22 [PATCH V5 2/3] mm: dmapool: Align to ARCH_DMA_MINALIGN in non-coherent DMA mode Huacai Chen 2017-09-18 4:22 ` Huacai Chen 2017-09-18 5:22 ` Christoph Hellwig 2017-09-18 5:22 ` Christoph Hellwig 2017-09-18 6:55 ` [PATCH V5 2/3] mm: dmapool: Align to ARCH_DMA_MINALIGN innon-coherent " 陈华才 2017-09-18 9:44 ` Robin Murphy [this message] 2017-09-18 9:44 ` [V5, 2/3] mm: dmapool: Align to ARCH_DMA_MINALIGN in non-coherent " Robin Murphy 2017-09-18 15:51 ` Christoph Hellwig 2017-09-18 15:51 ` Christoph Hellwig 2017-09-19 2:23 ` [V5, 2/3] mm: dmapool: Align to ARCH_DMA_MINALIGN innon-coherent " 陈华才 2017-09-18 15:45 ` [PATCH V5 2/3] mm: dmapool: Align to ARCH_DMA_MINALIGN in non-coherent " Christoph Hellwig 2017-09-18 15:45 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=601437ae-2860-c48a-aa7c-4da37aeb6256@arm.com \ --to=robin.murphy@arm.com \ --cc=akpm@linux-foundation.org \ --cc=chenhc@lemote.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=stable@vger.kernel.org \ --cc=zhangfx@lemote.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.