From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com> To: Jayesh Choudhary <j-choudhary@ti.com>, robh+dt@kernel.org Cc: lgirdwood@gmail.com, broonie@kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Date: Fri, 28 Jan 2022 22:18:52 +0200 [thread overview] Message-ID: <609b03e1-66e0-9bfd-cbe1-810d816df659@gmail.com> (raw) In-Reply-To: <f2bf4959-af15-04ad-78c3-aca883173d65@ti.com> On 1/17/22 12:07, Jayesh Choudhary wrote: >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - ti,dm646x-mcasp-audio >>>> + - ti,da830-mcasp-audio >>>> + - ti,am33xx-mcasp-audio >>>> + - ti,dra7-mcasp-audio >>>> + - ti,omap4-mcasp-audio >> >> This is the only thing which bugs me: the pointless '-audio' postfix for >> the compatible string... >> > > Removing the postfix would also require a lot of dts changes which might > be backward incompatible. So it is probably not a good idea. My plan was to not convert the ti,*-mcasp-audio txt file to yaml in the first place, but do it right with as ti,*-mcasp One of the outstanding issue is the multiple serializer support. It should be in core as things are just working by luck atm when more than one serializer is in use (via the card node). > Should we still consider this? Since we are officially documenting the -mcasp-audio, I don't think it would be a good idea to introduce different binding for the very same IP just for the sake of it. The new (and imho correct) binding would require quite a bit of work in the driver and in the core level (plus the simple-card family), but I'm afraid, I will not have time for it. -- Péter
WARNING: multiple messages have this Message-ID (diff)
From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com> To: Jayesh Choudhary <j-choudhary@ti.com>, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Date: Fri, 28 Jan 2022 22:18:52 +0200 [thread overview] Message-ID: <609b03e1-66e0-9bfd-cbe1-810d816df659@gmail.com> (raw) In-Reply-To: <f2bf4959-af15-04ad-78c3-aca883173d65@ti.com> On 1/17/22 12:07, Jayesh Choudhary wrote: >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - ti,dm646x-mcasp-audio >>>> + - ti,da830-mcasp-audio >>>> + - ti,am33xx-mcasp-audio >>>> + - ti,dra7-mcasp-audio >>>> + - ti,omap4-mcasp-audio >> >> This is the only thing which bugs me: the pointless '-audio' postfix for >> the compatible string... >> > > Removing the postfix would also require a lot of dts changes which might > be backward incompatible. So it is probably not a good idea. My plan was to not convert the ti,*-mcasp-audio txt file to yaml in the first place, but do it right with as ti,*-mcasp One of the outstanding issue is the multiple serializer support. It should be in core as things are just working by luck atm when more than one serializer is in use (via the card node). > Should we still consider this? Since we are officially documenting the -mcasp-audio, I don't think it would be a good idea to introduce different binding for the very same IP just for the sake of it. The new (and imho correct) binding would require quite a bit of work in the driver and in the core level (plus the simple-card family), but I'm afraid, I will not have time for it. -- Péter
next prev parent reply other threads:[~2022-01-28 20:13 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-03 7:44 [PATCH v5] ASoC: dt-bindings: davinci-mcasp: convert McASP bindings to yaml schema Jayesh Choudhary 2022-01-03 7:44 ` Jayesh Choudhary 2022-01-03 13:58 ` Rob Herring 2022-01-03 13:58 ` Rob Herring 2022-01-10 7:21 ` Jayesh Choudhary 2022-01-10 7:21 ` Jayesh Choudhary 2022-01-10 4:43 ` kernel test robot 2022-01-11 2:28 ` Rob Herring 2022-01-11 2:28 ` Rob Herring 2022-01-11 19:21 ` Péter Ujfalusi 2022-01-11 19:21 ` Péter Ujfalusi 2022-01-11 19:43 ` Péter Ujfalusi 2022-01-11 19:43 ` Péter Ujfalusi 2022-01-17 10:07 ` Jayesh Choudhary 2022-01-17 10:07 ` Jayesh Choudhary 2022-01-28 20:18 ` Péter Ujfalusi [this message] 2022-01-28 20:18 ` Péter Ujfalusi 2022-02-08 16:20 ` Jayesh Choudhary 2022-02-08 16:20 ` Jayesh Choudhary
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=609b03e1-66e0-9bfd-cbe1-810d816df659@gmail.com \ --to=peter.ujfalusi@gmail.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=j-choudhary@ti.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.