All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: ML dri-devel <dri-devel@lists.freedesktop.org>,
	linux-usb@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v2 03/10] drm/client: Add drm_client_framebuffer_flush()
Date: Wed, 3 Jun 2020 14:19:21 +0200	[thread overview]
Message-ID: <61eba989-4a3d-9208-5e5c-1fb587a36cb6@tronnes.org> (raw)
In-Reply-To: <CACvgo51Cq1ipV_K-NLk9QZ7d1Pweebz2ST6anqrT1q09r0+QEw@mail.gmail.com>



Den 28.05.2020 15.48, skrev Emil Velikov:
> Hi all,
> 
> I realise this has landed, so a small FYI comment.
> 
> On Sat, 9 May 2020 at 15:16, Noralf Trønnes <noralf@tronnes.org> wrote:
> 
>> +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect)
>> +{
>> +       if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty)
> 
> Hmm cannot think of a good reason why anyone would call this with
> !buffer || !buffer->fb?
> Might be a good idea to WARN in those cases - otherwise the user is
> given false sense to security.
> 

I agree, I'll send a fixup when I get through my backlog.

Noralf.

> Looking at the upcoming user (drm/gud) it already has both - so it's
> perfectly safe.
> 
> -Emil
> 

WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	linux-usb@vger.kernel.org,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	Lee Jones <lee.jones@linaro.org>, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v2 03/10] drm/client: Add drm_client_framebuffer_flush()
Date: Wed, 3 Jun 2020 14:19:21 +0200	[thread overview]
Message-ID: <61eba989-4a3d-9208-5e5c-1fb587a36cb6@tronnes.org> (raw)
In-Reply-To: <CACvgo51Cq1ipV_K-NLk9QZ7d1Pweebz2ST6anqrT1q09r0+QEw@mail.gmail.com>



Den 28.05.2020 15.48, skrev Emil Velikov:
> Hi all,
> 
> I realise this has landed, so a small FYI comment.
> 
> On Sat, 9 May 2020 at 15:16, Noralf Trønnes <noralf@tronnes.org> wrote:
> 
>> +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect)
>> +{
>> +       if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty)
> 
> Hmm cannot think of a good reason why anyone would call this with
> !buffer || !buffer->fb?
> Might be a good idea to WARN in those cases - otherwise the user is
> given false sense to security.
> 

I agree, I'll send a fixup when I get through my backlog.

Noralf.

> Looking at the upcoming user (drm/gud) it already has both - so it's
> perfectly safe.
> 
> -Emil
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-03 12:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-09 14:16 [PATCH v2 00/10] Generic USB Display driver Noralf Trønnes
2020-05-09 14:16 ` Noralf Trønnes
2020-05-09 14:16 ` [PATCH v2 01/10] backlight: Add backlight_device_get_by_name() Noralf Trønnes
2020-05-09 14:16   ` Noralf Trønnes
2020-05-10 21:44   ` Jingoo Han
2020-05-10 21:44     ` Jingoo Han
2020-05-11  6:40   ` Lee Jones
2020-05-11  6:40     ` Lee Jones
2020-05-09 14:16 ` [PATCH v2 02/10] drm/client: Add drm_client_init_from_id() Noralf Trønnes
2020-05-09 14:16   ` Noralf Trønnes
2020-05-09 14:16 ` [PATCH v2 03/10] drm/client: Add drm_client_framebuffer_flush() Noralf Trønnes
2020-05-09 14:16   ` Noralf Trønnes
2020-05-28 13:48   ` Emil Velikov
2020-05-28 13:48     ` Emil Velikov
2020-06-03 12:19     ` Noralf Trønnes [this message]
2020-06-03 12:19       ` Noralf Trønnes
2020-05-09 14:16 ` [PATCH v2 04/10] drm/client: Add drm_client_modeset_check() Noralf Trønnes
2020-05-09 14:16   ` Noralf Trønnes
2020-05-09 14:16 ` [PATCH v2 05/10] drm/client: Add drm_client_modeset_disable() Noralf Trønnes
2020-05-09 14:16   ` Noralf Trønnes
2020-05-09 14:16 ` [PATCH v2 06/10] drm/client: Add a way to set modeset, properties and rotation Noralf Trønnes
2020-05-09 14:16   ` Noralf Trønnes
2020-05-09 14:16 ` [PATCH v2 07/10] drm/format-helper: Add drm_fb_swab() Noralf Trønnes
2020-05-09 14:16   ` Noralf Trønnes
2020-05-09 14:16 ` [PATCH v2 08/10] drm: Add Generic USB Display driver Noralf Trønnes
2020-05-09 14:16   ` Noralf Trønnes
2020-05-09 14:16 ` [PATCH v2 09/10] drm/gud: Add functionality for the USB gadget side Noralf Trønnes
2020-05-09 14:16   ` Noralf Trønnes
2020-05-09 14:16 ` [PATCH v2 10/10] usb: gadget: function: Add Generic USB Display support Noralf Trønnes
2020-05-09 14:16   ` Noralf Trønnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61eba989-4a3d-9208-5e5c-1fb587a36cb6@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=daniel.thompson@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.