From: "Noralf Trønnes" <noralf@tronnes.org> To: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, lee.jones@linaro.org Cc: sam@ravnborg.org, daniel.thompson@linaro.org, jingoohan1@gmail.com, "Noralf Trønnes" <noralf@tronnes.org> Subject: [PATCH v2 03/10] drm/client: Add drm_client_framebuffer_flush() Date: Sat, 9 May 2020 16:16:12 +0200 [thread overview] Message-ID: <20200509141619.32970-4-noralf@tronnes.org> (raw) In-Reply-To: <20200509141619.32970-1-noralf@tronnes.org> Some drivers need explicit flushing of buffer changes, add a function that does that. v2: - Put all clip rect stuff inside if statement (Sam) Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Noralf Trønnes <noralf@tronnes.org> --- drivers/gpu/drm/drm_client.c | 33 +++++++++++++++++++++++++++++++++ include/drm/drm_client.h | 1 + 2 files changed, 34 insertions(+) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index 12787915db01..827ee6422dd2 100644 --- a/drivers/gpu/drm/drm_client.c +++ b/drivers/gpu/drm/drm_client.c @@ -483,6 +483,39 @@ void drm_client_framebuffer_delete(struct drm_client_buffer *buffer) } EXPORT_SYMBOL(drm_client_framebuffer_delete); +/** + * drm_client_framebuffer_flush - Manually flush client framebuffer + * @buffer: DRM client buffer (can be NULL) + * @rect: Damage rectangle (if NULL flushes all) + * + * This calls &drm_framebuffer_funcs->dirty (if present) to flush buffer changes + * for drivers that need it. + * + * Returns: + * Zero on success or negative error code on failure. + */ +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect) +{ + if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty) + return 0; + + if (rect) { + struct drm_clip_rect clip = { + .x1 = rect->x1, + .y1 = rect->y1, + .x2 = rect->x2, + .y2 = rect->y2, + }; + + return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file, + 0, 0, &clip, 1); + } + + return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file, + 0, 0, NULL, 0); +} +EXPORT_SYMBOL(drm_client_framebuffer_flush); + #ifdef CONFIG_DEBUG_FS static int drm_client_debugfs_internal_clients(struct seq_file *m, void *data) { diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h index 96ebc7523aa0..9737dd7b147f 100644 --- a/include/drm/drm_client.h +++ b/include/drm/drm_client.h @@ -156,6 +156,7 @@ struct drm_client_buffer { struct drm_client_buffer * drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format); void drm_client_framebuffer_delete(struct drm_client_buffer *buffer); +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect); void *drm_client_buffer_vmap(struct drm_client_buffer *buffer); void drm_client_buffer_vunmap(struct drm_client_buffer *buffer); -- 2.23.0
WARNING: multiple messages have this Message-ID (diff)
From: "Noralf Trønnes" <noralf@tronnes.org> To: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, lee.jones@linaro.org Cc: jingoohan1@gmail.com, daniel.thompson@linaro.org, sam@ravnborg.org Subject: [PATCH v2 03/10] drm/client: Add drm_client_framebuffer_flush() Date: Sat, 9 May 2020 16:16:12 +0200 [thread overview] Message-ID: <20200509141619.32970-4-noralf@tronnes.org> (raw) In-Reply-To: <20200509141619.32970-1-noralf@tronnes.org> Some drivers need explicit flushing of buffer changes, add a function that does that. v2: - Put all clip rect stuff inside if statement (Sam) Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Noralf Trønnes <noralf@tronnes.org> --- drivers/gpu/drm/drm_client.c | 33 +++++++++++++++++++++++++++++++++ include/drm/drm_client.h | 1 + 2 files changed, 34 insertions(+) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index 12787915db01..827ee6422dd2 100644 --- a/drivers/gpu/drm/drm_client.c +++ b/drivers/gpu/drm/drm_client.c @@ -483,6 +483,39 @@ void drm_client_framebuffer_delete(struct drm_client_buffer *buffer) } EXPORT_SYMBOL(drm_client_framebuffer_delete); +/** + * drm_client_framebuffer_flush - Manually flush client framebuffer + * @buffer: DRM client buffer (can be NULL) + * @rect: Damage rectangle (if NULL flushes all) + * + * This calls &drm_framebuffer_funcs->dirty (if present) to flush buffer changes + * for drivers that need it. + * + * Returns: + * Zero on success or negative error code on failure. + */ +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect) +{ + if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty) + return 0; + + if (rect) { + struct drm_clip_rect clip = { + .x1 = rect->x1, + .y1 = rect->y1, + .x2 = rect->x2, + .y2 = rect->y2, + }; + + return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file, + 0, 0, &clip, 1); + } + + return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file, + 0, 0, NULL, 0); +} +EXPORT_SYMBOL(drm_client_framebuffer_flush); + #ifdef CONFIG_DEBUG_FS static int drm_client_debugfs_internal_clients(struct seq_file *m, void *data) { diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h index 96ebc7523aa0..9737dd7b147f 100644 --- a/include/drm/drm_client.h +++ b/include/drm/drm_client.h @@ -156,6 +156,7 @@ struct drm_client_buffer { struct drm_client_buffer * drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format); void drm_client_framebuffer_delete(struct drm_client_buffer *buffer); +int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect); void *drm_client_buffer_vmap(struct drm_client_buffer *buffer); void drm_client_buffer_vunmap(struct drm_client_buffer *buffer); -- 2.23.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-05-09 14:16 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-09 14:16 [PATCH v2 00/10] Generic USB Display driver Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes 2020-05-09 14:16 ` [PATCH v2 01/10] backlight: Add backlight_device_get_by_name() Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes 2020-05-10 21:44 ` Jingoo Han 2020-05-10 21:44 ` Jingoo Han 2020-05-11 6:40 ` Lee Jones 2020-05-11 6:40 ` Lee Jones 2020-05-09 14:16 ` [PATCH v2 02/10] drm/client: Add drm_client_init_from_id() Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes [this message] 2020-05-09 14:16 ` [PATCH v2 03/10] drm/client: Add drm_client_framebuffer_flush() Noralf Trønnes 2020-05-28 13:48 ` Emil Velikov 2020-05-28 13:48 ` Emil Velikov 2020-06-03 12:19 ` Noralf Trønnes 2020-06-03 12:19 ` Noralf Trønnes 2020-05-09 14:16 ` [PATCH v2 04/10] drm/client: Add drm_client_modeset_check() Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes 2020-05-09 14:16 ` [PATCH v2 05/10] drm/client: Add drm_client_modeset_disable() Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes 2020-05-09 14:16 ` [PATCH v2 06/10] drm/client: Add a way to set modeset, properties and rotation Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes 2020-05-09 14:16 ` [PATCH v2 07/10] drm/format-helper: Add drm_fb_swab() Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes 2020-05-09 14:16 ` [PATCH v2 08/10] drm: Add Generic USB Display driver Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes 2020-05-09 14:16 ` [PATCH v2 09/10] drm/gud: Add functionality for the USB gadget side Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes 2020-05-09 14:16 ` [PATCH v2 10/10] usb: gadget: function: Add Generic USB Display support Noralf Trønnes 2020-05-09 14:16 ` Noralf Trønnes
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200509141619.32970-4-noralf@tronnes.org \ --to=noralf@tronnes.org \ --cc=daniel.thompson@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jingoohan1@gmail.com \ --cc=lee.jones@linaro.org \ --cc=linux-usb@vger.kernel.org \ --cc=sam@ravnborg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.