All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Biju Das <biju.das@bp.renesas.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Simon Horman <horms@verge.net.au>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH 4/4] drm: rcar-du: lvds: Add r8a774a1 support
Date: Fri, 12 Apr 2019 13:06:45 +0100	[thread overview]
Message-ID: <644bcaa0-6cc3-3e22-a728-79e5754d26e4@ideasonboard.com> (raw)
In-Reply-To: <1554993271-29523-5-git-send-email-biju.das@bp.renesas.com>

Hi Biju,

On 11/04/2019 15:34, Biju Das wrote:
> The LVDS encoders on RZ/G2M SoC is similar to R-Car M3-W. Add support for
> RZ/G2M (R8A774A1) SoC to the LVDS encoder driver.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

This one seems to be ok using the gen3 as far as I can tell, the PLL
configuration and layout match.

We're lacking the TCON, but that's not supported currently anyway, and
shouldn't matter here.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>


> ---
>  drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 7ef97b2..819561e 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -857,6 +857,7 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = {
>  static const struct of_device_id rcar_lvds_of_table[] = {
>  	{ .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
>  	{ .compatible = "renesas,r8a7744-lvds", .data = &rcar_lvds_gen2_info },
> +	{ .compatible = "renesas,r8a774a1-lvds", .data = &rcar_lvds_gen3_info },
>  	{ .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info },
>  	{ .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info },
>  	{ .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
> 


WARNING: multiple messages have this Message-ID (diff)
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Biju Das <biju.das@bp.renesas.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Simon Horman <horms@verge.net.au>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 4/4] drm: rcar-du: lvds: Add r8a774a1 support
Date: Fri, 12 Apr 2019 13:06:45 +0100	[thread overview]
Message-ID: <644bcaa0-6cc3-3e22-a728-79e5754d26e4@ideasonboard.com> (raw)
In-Reply-To: <1554993271-29523-5-git-send-email-biju.das@bp.renesas.com>

Hi Biju,

On 11/04/2019 15:34, Biju Das wrote:
> The LVDS encoders on RZ/G2M SoC is similar to R-Car M3-W. Add support for
> RZ/G2M (R8A774A1) SoC to the LVDS encoder driver.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

This one seems to be ok using the gen3 as far as I can tell, the PLL
configuration and layout match.

We're lacking the TCON, but that's not supported currently anyway, and
shouldn't matter here.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>


> ---
>  drivers/gpu/drm/rcar-du/rcar_lvds.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> index 7ef97b2..819561e 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
> @@ -857,6 +857,7 @@ static const struct rcar_lvds_device_info rcar_lvds_r8a77995_info = {
>  static const struct of_device_id rcar_lvds_of_table[] = {
>  	{ .compatible = "renesas,r8a7743-lvds", .data = &rcar_lvds_gen2_info },
>  	{ .compatible = "renesas,r8a7744-lvds", .data = &rcar_lvds_gen2_info },
> +	{ .compatible = "renesas,r8a774a1-lvds", .data = &rcar_lvds_gen3_info },
>  	{ .compatible = "renesas,r8a774c0-lvds", .data = &rcar_lvds_r8a77990_info },
>  	{ .compatible = "renesas,r8a7790-lvds", .data = &rcar_lvds_r8a7790_info },
>  	{ .compatible = "renesas,r8a7791-lvds", .data = &rcar_lvds_gen2_info },
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-04-12 12:06 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 14:34 [PATCH 0/4] Add RZ/G2M DU support Biju Das
2019-04-11 14:34 ` Biju Das
2019-04-11 14:34 ` [PATCH 1/4] dt-bindings: display: renesas: du: Document the r8a774a1 bindings Biju Das
2019-04-11 14:34   ` Biju Das
2019-04-12  9:54   ` Kieran Bingham
2019-04-12  9:54     ` Kieran Bingham
2019-04-12 10:06     ` Biju Das
2019-04-12 10:06       ` Biju Das
2019-04-11 14:34 ` [PATCH 2/4] dt-bindings: display: renesas: lvds: Document " Biju Das
2019-04-11 14:34   ` Biju Das
2019-04-12 10:33   ` Kieran Bingham
2019-04-12 10:33     ` Kieran Bingham
2019-04-11 14:34 ` [PATCH 3/4] drm: rcar-du: Add R8A774A1 support Biju Das
2019-04-11 14:34   ` Biju Das
2019-04-12 11:47   ` Kieran Bingham
2019-04-12 11:47     ` Kieran Bingham
2019-04-12 12:03     ` Biju Das
2019-04-12 12:03       ` Biju Das
2019-04-11 14:34 ` [PATCH 4/4] drm: rcar-du: lvds: Add r8a774a1 support Biju Das
2019-04-11 14:34   ` Biju Das
2019-04-12 12:06   ` Kieran Bingham [this message]
2019-04-12 12:06     ` Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=644bcaa0-6cc3-3e22-a728-79e5754d26e4@ideasonboard.com \
    --to=kieran.bingham+renesas@ideasonboard.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=airlied@linux.ie \
    --cc=biju.das@bp.renesas.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.