All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Biju Das <biju.das@bp.renesas.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Simon Horman <horms@verge.net.au>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
Date: Fri, 12 Apr 2019 12:47:21 +0100	[thread overview]
Message-ID: <9476e97f-380a-7285-b169-72085dfe0eca@ideasonboard.com> (raw)
In-Reply-To: <1554993271-29523-4-git-send-email-biju.das@bp.renesas.com>

Hi Biju,

On 11/04/2019 15:34, Biju Das wrote:
> Add support for the R8A774A1 DU (which is very similar to the R8A7796 DU);
> it has one RGB output, one LVDS output and one HDMI output.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

I see Figure 35.1b across the two datasheets does show some differences
between these two parts, but the layout defined by the
rcar_du_r8a7796_info structure is compatible based on the current state
of the driver...

However, if support for the TCON/CMM is added to the DU driver - then I
think this will need to be separated.

I have seen patches this month which are trying to upstream a CMM
implementation.

With that in mind - perhaps it would be worth creating a new structure
for this part?

Otherwise the CMM would end up being enabled when it doesn't exist and
could cause problems.

--
Regards

Kieran


> ---
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> index 75ab17a..f7a5314 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -386,6 +386,7 @@ static const struct of_device_id rcar_du_of_table[] = {
>  	{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
>  	{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
>  	{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> +	{ .compatible = "renesas,du-r8a774a1", .data = &rcar_du_r8a7796_info },
>  	{ .compatible = "renesas,du-r8a774c0", .data = &rcar_du_r8a774c0_info },
>  	{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
>  	{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> 


WARNING: multiple messages have this Message-ID (diff)
From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: Biju Das <biju.das@bp.renesas.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	dri-devel@lists.freedesktop.org,
	linux-renesas-soc@vger.kernel.org,
	Simon Horman <horms@verge.net.au>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
Date: Fri, 12 Apr 2019 12:47:21 +0100	[thread overview]
Message-ID: <9476e97f-380a-7285-b169-72085dfe0eca@ideasonboard.com> (raw)
In-Reply-To: <1554993271-29523-4-git-send-email-biju.das@bp.renesas.com>

Hi Biju,

On 11/04/2019 15:34, Biju Das wrote:
> Add support for the R8A774A1 DU (which is very similar to the R8A7796 DU);
> it has one RGB output, one LVDS output and one HDMI output.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

I see Figure 35.1b across the two datasheets does show some differences
between these two parts, but the layout defined by the
rcar_du_r8a7796_info structure is compatible based on the current state
of the driver...

However, if support for the TCON/CMM is added to the DU driver - then I
think this will need to be separated.

I have seen patches this month which are trying to upstream a CMM
implementation.

With that in mind - perhaps it would be worth creating a new structure
for this part?

Otherwise the CMM would end up being enabled when it doesn't exist and
could cause problems.

--
Regards

Kieran


> ---
>  drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> index 75ab17a..f7a5314 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -386,6 +386,7 @@ static const struct of_device_id rcar_du_of_table[] = {
>  	{ .compatible = "renesas,du-r8a7744", .data = &rzg1_du_r8a7743_info },
>  	{ .compatible = "renesas,du-r8a7745", .data = &rzg1_du_r8a7745_info },
>  	{ .compatible = "renesas,du-r8a77470", .data = &rzg1_du_r8a77470_info },
> +	{ .compatible = "renesas,du-r8a774a1", .data = &rcar_du_r8a7796_info },
>  	{ .compatible = "renesas,du-r8a774c0", .data = &rcar_du_r8a774c0_info },
>  	{ .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info },
>  	{ .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info },
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-04-12 11:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-11 14:34 [PATCH 0/4] Add RZ/G2M DU support Biju Das
2019-04-11 14:34 ` Biju Das
2019-04-11 14:34 ` [PATCH 1/4] dt-bindings: display: renesas: du: Document the r8a774a1 bindings Biju Das
2019-04-11 14:34   ` Biju Das
2019-04-12  9:54   ` Kieran Bingham
2019-04-12  9:54     ` Kieran Bingham
2019-04-12 10:06     ` Biju Das
2019-04-12 10:06       ` Biju Das
2019-04-11 14:34 ` [PATCH 2/4] dt-bindings: display: renesas: lvds: Document " Biju Das
2019-04-11 14:34   ` Biju Das
2019-04-12 10:33   ` Kieran Bingham
2019-04-12 10:33     ` Kieran Bingham
2019-04-11 14:34 ` [PATCH 3/4] drm: rcar-du: Add R8A774A1 support Biju Das
2019-04-11 14:34   ` Biju Das
2019-04-12 11:47   ` Kieran Bingham [this message]
2019-04-12 11:47     ` Kieran Bingham
2019-04-12 12:03     ` Biju Das
2019-04-12 12:03       ` Biju Das
2019-04-11 14:34 ` [PATCH 4/4] drm: rcar-du: lvds: Add r8a774a1 support Biju Das
2019-04-11 14:34   ` Biju Das
2019-04-12 12:06   ` Kieran Bingham
2019-04-12 12:06     ` Kieran Bingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9476e97f-380a-7285-b169-72085dfe0eca@ideasonboard.com \
    --to=kieran.bingham+renesas@ideasonboard.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=airlied@linux.ie \
    --cc=biju.das@bp.renesas.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.