All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'
@ 2017-04-03  9:15 ` Colin King
  0 siblings, 0 replies; 7+ messages in thread
From: Colin King @ 2017-04-03  9:15 UTC (permalink / raw)
  To: Kalle Valo, linux-wireless, netdev; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

trivial fix to spelling mistake in wl1271_warning error message

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
index 58e148d7bc7b..416080adc181 100644
--- a/drivers/net/wireless/ti/wlcore/debugfs.c
+++ b/drivers/net/wireless/ti/wlcore/debugfs.c
@@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file,
 	}
 
 	if (wl->conf.fwlog.output == 0) {
-		wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf");
+		wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf");
 		return -EINVAL;
 	}
 
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'
@ 2017-04-03  9:15 ` Colin King
  0 siblings, 0 replies; 7+ messages in thread
From: Colin King @ 2017-04-03  9:15 UTC (permalink / raw)
  To: Kalle Valo, linux-wireless, netdev; +Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

trivial fix to spelling mistake in wl1271_warning error message

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
index 58e148d7bc7b..416080adc181 100644
--- a/drivers/net/wireless/ti/wlcore/debugfs.c
+++ b/drivers/net/wireless/ti/wlcore/debugfs.c
@@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file,
 	}
 
 	if (wl->conf.fwlog.output = 0) {
-		wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf");
+		wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf");
 		return -EINVAL;
 	}
 
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'
@ 2017-04-03  9:20   ` Joe Perches
  0 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2017-04-03  9:20 UTC (permalink / raw)
  To: Colin King, Kalle Valo, linux-wireless, netdev
  Cc: kernel-janitors, linux-kernel

On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> trivial fix to spelling mistake in wl1271_warning error message
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
> index 58e148d7bc7b..416080adc181 100644
> --- a/drivers/net/wireless/ti/wlcore/debugfs.c
> +++ b/drivers/net/wireless/ti/wlcore/debugfs.c
> @@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file,
>  	}
>  
>  	if (wl->conf.fwlog.output == 0) {
> -		wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf");
> +		wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf");

Hi Colin.

When you do these would you please fix all the typos on the
same line?  opperation -> operation

Also, generally, invalid is a better word choice than illegal
for these situations.

Thanks and cheers, Joe

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'
@ 2017-04-03  9:20   ` Joe Perches
  0 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2017-04-03  9:20 UTC (permalink / raw)
  To: Colin King, Kalle Valo, linux-wireless-u79uwXL29TY76Z2rM5mHXA,
	netdev-u79uwXL29TY76Z2rM5mHXA
  Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote:
> From: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> 
> trivial fix to spelling mistake in wl1271_warning error message
> 
> Signed-off-by: Colin Ian King <colin.king-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
> ---
>  drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
> index 58e148d7bc7b..416080adc181 100644
> --- a/drivers/net/wireless/ti/wlcore/debugfs.c
> +++ b/drivers/net/wireless/ti/wlcore/debugfs.c
> @@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file,
>  	}
>  
>  	if (wl->conf.fwlog.output == 0) {
> -		wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf");
> +		wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf");

Hi Colin.

When you do these would you please fix all the typos on the
same line?  opperation -> operation

Also, generally, invalid is a better word choice than illegal
for these situations.

Thanks and cheers, Joe

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'
@ 2017-04-03  9:20   ` Joe Perches
  0 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2017-04-03  9:20 UTC (permalink / raw)
  To: Colin King, Kalle Valo, linux-wireless, netdev
  Cc: kernel-janitors, linux-kernel

On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> trivial fix to spelling mistake in wl1271_warning error message
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
> index 58e148d7bc7b..416080adc181 100644
> --- a/drivers/net/wireless/ti/wlcore/debugfs.c
> +++ b/drivers/net/wireless/ti/wlcore/debugfs.c
> @@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file,
>  	}
>  
>  	if (wl->conf.fwlog.output = 0) {
> -		wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf");
> +		wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf");

Hi Colin.

When you do these would you please fix all the typos on the
same line?  opperation -> operation

Also, generally, invalid is a better word choice than illegal
for these situations.

Thanks and cheers, Joe


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'
  2017-04-03  9:20   ` Joe Perches
@ 2017-04-03  9:44     ` Colin Ian King
  -1 siblings, 0 replies; 7+ messages in thread
From: Colin Ian King @ 2017-04-03  9:44 UTC (permalink / raw)
  To: Joe Perches, Kalle Valo, linux-wireless, netdev
  Cc: kernel-janitors, linux-kernel

On 03/04/17 10:20, Joe Perches wrote:
> On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> trivial fix to spelling mistake in wl1271_warning error message
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>  drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
>> index 58e148d7bc7b..416080adc181 100644
>> --- a/drivers/net/wireless/ti/wlcore/debugfs.c
>> +++ b/drivers/net/wireless/ti/wlcore/debugfs.c
>> @@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file,
>>  	}
>>  
>>  	if (wl->conf.fwlog.output == 0) {
>> -		wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf");
>> +		wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf");
> 
> Hi Colin.
> 
> When you do these would you please fix all the typos on the
> same line?  opperation -> operation

Sure, I stupidly missed that.

> 
> Also, generally, invalid is a better word choice than illegal
> for these situations.

Good point.
> 
> Thanks and cheers, Joe
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal'
@ 2017-04-03  9:44     ` Colin Ian King
  0 siblings, 0 replies; 7+ messages in thread
From: Colin Ian King @ 2017-04-03  9:44 UTC (permalink / raw)
  To: Joe Perches, Kalle Valo, linux-wireless, netdev
  Cc: kernel-janitors, linux-kernel

On 03/04/17 10:20, Joe Perches wrote:
> On Mon, 2017-04-03 at 10:15 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> trivial fix to spelling mistake in wl1271_warning error message
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>>  drivers/net/wireless/ti/wlcore/debugfs.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c
>> index 58e148d7bc7b..416080adc181 100644
>> --- a/drivers/net/wireless/ti/wlcore/debugfs.c
>> +++ b/drivers/net/wireless/ti/wlcore/debugfs.c
>> @@ -1249,7 +1249,7 @@ static ssize_t fw_logger_write(struct file *file,
>>  	}
>>  
>>  	if (wl->conf.fwlog.output = 0) {
>> -		wl1271_warning("iligal opperation - fw logger disabled by default, please change mode via wlconf");
>> +		wl1271_warning("illegal opperation - fw logger disabled by default, please change mode via wlconf");
> 
> Hi Colin.
> 
> When you do these would you please fix all the typos on the
> same line?  opperation -> operation

Sure, I stupidly missed that.

> 
> Also, generally, invalid is a better word choice than illegal
> for these situations.

Good point.
> 
> Thanks and cheers, Joe
> 


^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-04-03  9:44 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-03  9:15 [PATCH] wlcore: fix spelling mistake in wl1271_warning 'iligal' -> 'illegal' Colin King
2017-04-03  9:15 ` Colin King
2017-04-03  9:20 ` Joe Perches
2017-04-03  9:20   ` Joe Perches
2017-04-03  9:20   ` Joe Perches
2017-04-03  9:44   ` Colin Ian King
2017-04-03  9:44     ` Colin Ian King

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.