From: Vladimir Zapolskiy <vz@mleia.com> To: Dmitry Osipenko <digetx@gmail.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Stephen Warren <swarren@wwwdotorg.org> Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>, linux-media@vger.kernel.org Subject: Re: [PATCH v4 2/5] media: dt: bindings: Add binding for NVIDIA Tegra Video Decoder Engine Date: Sat, 11 Nov 2017 16:21:07 +0200 [thread overview] Message-ID: <6492d1af-19fa-253f-2b75-2c37ccd44cbe@mleia.com> (raw) In-Reply-To: <bf5b91666229f9e46ed8c73d6ca2e4b65f86b5ab.1508448293.git.digetx@gmail.com> Hi Dmitry, On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > Add binding documentation for the Video Decoder Engine which is found > on NVIDIA Tegra20/30/114/124/132 SoC's. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > .../devicetree/bindings/media/nvidia,tegra-vde.txt | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > > diff --git a/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt b/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > new file mode 100644 > index 000000000000..470237ed6fe5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > @@ -0,0 +1,55 @@ > +NVIDIA Tegra Video Decoder Engine > + > +Required properties: > +- compatible : Must contain one of the following values: > + - "nvidia,tegra20-vde" > + - "nvidia,tegra30-vde" > + - "nvidia,tegra114-vde" > + - "nvidia,tegra124-vde" > + - "nvidia,tegra132-vde" > +- reg : Must contain an entry for each entry in reg-names. > +- reg-names : Must include the following entries: > + - sxe > + - bsev > + - mbe > + - ppe > + - mce > + - tfe > + - ppb > + - vdma > + - frameid I've already mentioned it in my review of the driver code, but the version from v3 with a single region is more preferable. Also it implies that "reg-names" property will be removed. > +- iram : Must contain phandle to the mmio-sram device node that represents > + IRAM region used by VDE. > +- interrupts : Must contain an entry for each entry in interrupt-names. > +- interrupt-names : Must include the following entries: > + - sync-token > + - bsev > + - sxe > +- clocks : Must include the following entries: > + - vde > +- resets : Must include the following entries: > + - vde > + > +Example: > + > +video-codec@6001a000 { > + compatible = "nvidia,tegra20-vde"; > + reg = <0x6001a000 0x1000 /* Syntax Engine */ > + 0x6001b000 0x1000 /* Video Bitstream Engine */ > + 0x6001c000 0x100 /* Macroblock Engine */ > + 0x6001c200 0x100 /* Post-processing Engine */ > + 0x6001c400 0x100 /* Motion Compensation Engine */ > + 0x6001c600 0x100 /* Transform Engine */ > + 0x6001c800 0x100 /* Pixel prediction block */ > + 0x6001ca00 0x100 /* Video DMA */ > + 0x6001d800 0x300 /* Video frame controls */>; > + reg-names = "sxe", "bsev", "mbe", "ppe", "mce", > + "tfe", "ppb", "vdma", "frameid"; > + iram = <&vde_pool>; /* IRAM region */ > + interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, /* Sync token interrupt */ > + <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, /* BSE-V interrupt */ > + <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; /* SXE interrupt */ > + interrupt-names = "sync-token", "bsev", "sxe"; > + clocks = <&tegra_car TEGRA20_CLK_VDE>; > + resets = <&tegra_car 61>; > +}; > -- With best wishes, Vladimir
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Zapolskiy <vz@mleia.com> To: Dmitry Osipenko <digetx@gmail.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rob Herring <robh+dt@kernel.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Stephen Warren <swarren@wwwdotorg.org> Cc: Dan Carpenter <dan.carpenter@oracle.com>, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/5] media: dt: bindings: Add binding for NVIDIA Tegra Video Decoder Engine Date: Sat, 11 Nov 2017 16:21:07 +0200 [thread overview] Message-ID: <6492d1af-19fa-253f-2b75-2c37ccd44cbe@mleia.com> (raw) In-Reply-To: <bf5b91666229f9e46ed8c73d6ca2e4b65f86b5ab.1508448293.git.digetx@gmail.com> Hi Dmitry, On 10/20/2017 12:34 AM, Dmitry Osipenko wrote: > Add binding documentation for the Video Decoder Engine which is found > on NVIDIA Tegra20/30/114/124/132 SoC's. > > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > .../devicetree/bindings/media/nvidia,tegra-vde.txt | 55 ++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > > diff --git a/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt b/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > new file mode 100644 > index 000000000000..470237ed6fe5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/nvidia,tegra-vde.txt > @@ -0,0 +1,55 @@ > +NVIDIA Tegra Video Decoder Engine > + > +Required properties: > +- compatible : Must contain one of the following values: > + - "nvidia,tegra20-vde" > + - "nvidia,tegra30-vde" > + - "nvidia,tegra114-vde" > + - "nvidia,tegra124-vde" > + - "nvidia,tegra132-vde" > +- reg : Must contain an entry for each entry in reg-names. > +- reg-names : Must include the following entries: > + - sxe > + - bsev > + - mbe > + - ppe > + - mce > + - tfe > + - ppb > + - vdma > + - frameid I've already mentioned it in my review of the driver code, but the version from v3 with a single region is more preferable. Also it implies that "reg-names" property will be removed. > +- iram : Must contain phandle to the mmio-sram device node that represents > + IRAM region used by VDE. > +- interrupts : Must contain an entry for each entry in interrupt-names. > +- interrupt-names : Must include the following entries: > + - sync-token > + - bsev > + - sxe > +- clocks : Must include the following entries: > + - vde > +- resets : Must include the following entries: > + - vde > + > +Example: > + > +video-codec@6001a000 { > + compatible = "nvidia,tegra20-vde"; > + reg = <0x6001a000 0x1000 /* Syntax Engine */ > + 0x6001b000 0x1000 /* Video Bitstream Engine */ > + 0x6001c000 0x100 /* Macroblock Engine */ > + 0x6001c200 0x100 /* Post-processing Engine */ > + 0x6001c400 0x100 /* Motion Compensation Engine */ > + 0x6001c600 0x100 /* Transform Engine */ > + 0x6001c800 0x100 /* Pixel prediction block */ > + 0x6001ca00 0x100 /* Video DMA */ > + 0x6001d800 0x300 /* Video frame controls */>; > + reg-names = "sxe", "bsev", "mbe", "ppe", "mce", > + "tfe", "ppb", "vdma", "frameid"; > + iram = <&vde_pool>; /* IRAM region */ > + interrupts = <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH>, /* Sync token interrupt */ > + <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>, /* BSE-V interrupt */ > + <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>; /* SXE interrupt */ > + interrupt-names = "sync-token", "bsev", "sxe"; > + clocks = <&tegra_car TEGRA20_CLK_VDE>; > + resets = <&tegra_car 61>; > +}; > -- With best wishes, Vladimir
next prev parent reply other threads:[~2017-11-11 14:21 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-19 21:34 [PATCH v4 0/5] NVIDIA Tegra20 video decoder driver Dmitry Osipenko 2017-10-19 21:34 ` Dmitry Osipenko 2017-10-19 21:34 ` [PATCH v4 1/5] ARM: tegra: Add device tree node to describe IRAM Dmitry Osipenko 2017-10-19 21:34 ` Dmitry Osipenko [not found] ` <8ce696bc2b4b1808f6c7f7a967a3dacd954d2a4e.1508448293.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-11-11 14:18 ` Vladimir Zapolskiy 2017-11-11 14:18 ` Vladimir Zapolskiy 2017-11-12 16:28 ` Dmitry Osipenko 2017-11-12 16:28 ` Dmitry Osipenko 2017-10-19 21:34 ` [PATCH v4 2/5] media: dt: bindings: Add binding for NVIDIA Tegra Video Decoder Engine Dmitry Osipenko 2017-10-19 21:34 ` Dmitry Osipenko [not found] ` <bf5b91666229f9e46ed8c73d6ca2e4b65f86b5ab.1508448293.git.digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2017-10-27 1:01 ` Rob Herring 2017-10-27 1:01 ` Rob Herring 2017-11-11 14:21 ` Vladimir Zapolskiy [this message] 2017-11-11 14:21 ` Vladimir Zapolskiy [not found] ` <6492d1af-19fa-253f-2b75-2c37ccd44cbe-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org> 2017-11-12 16:19 ` Dmitry Osipenko 2017-11-12 16:19 ` Dmitry Osipenko 2017-10-19 21:34 ` [PATCH v4 3/5] staging: Introduce NVIDIA Tegra video decoder driver Dmitry Osipenko 2017-10-19 21:34 ` Dmitry Osipenko 2017-11-11 14:06 ` Vladimir Zapolskiy 2017-11-11 14:06 ` Vladimir Zapolskiy 2017-11-12 16:17 ` Dmitry Osipenko 2017-11-12 16:17 ` Dmitry Osipenko 2017-11-13 8:16 ` Dan Carpenter 2017-11-13 8:16 ` Dan Carpenter 2017-12-04 14:04 ` Hans Verkuil 2017-12-04 14:04 ` Hans Verkuil [not found] ` <ad2da9f4-8899-7db3-493f-5aa15297c33c-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2017-12-05 12:17 ` Dmitry Osipenko 2017-12-05 12:17 ` Dmitry Osipenko 2017-12-05 13:03 ` Hans Verkuil 2017-12-05 13:03 ` Hans Verkuil 2017-12-10 18:56 ` Dmitry Osipenko 2017-12-10 18:56 ` Dmitry Osipenko 2017-12-10 19:29 ` Nicolas Dufresne [not found] ` <1512934179.4281.15.camel-dDhyB4GVkw9AFePFGvp55w@public.gmane.org> 2017-12-11 0:12 ` Dmitry Osipenko 2017-12-11 0:12 ` Dmitry Osipenko 2017-12-12 12:54 ` Hans Verkuil 2017-12-12 12:54 ` Hans Verkuil 2017-10-19 21:34 ` [PATCH v4 4/5] ARM: dts: tegra20: Add video decoder node Dmitry Osipenko 2017-10-19 21:34 ` Dmitry Osipenko 2017-10-19 21:34 ` [PATCH v4 5/5] ARM: defconfig: tegra: Enable Video Decoder driver Dmitry Osipenko 2017-10-19 21:34 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6492d1af-19fa-253f-2b75-2c37ccd44cbe@mleia.com \ --to=vz@mleia.com \ --cc=dan.carpenter@oracle.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=digetx@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=jonathanh@nvidia.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ --cc=swarren@wwwdotorg.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.