All of lore.kernel.org
 help / color / mirror / Atom feed
From: gengdongjiu <gengdongjiu@huawei.com>
To: Beata Michalska <beata.michalska@linaro.org>
Cc: Xiang Zheng <zhengxiang9@huawei.com>, <pbonzini@redhat.com>,
	<mst@redhat.com>, Igor Mammedov <imammedo@redhat.com>,
	<shannon.zhaosl@gmail.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	"Laszlo Ersek" <lersek@redhat.com>, <james.morse@arm.com>,
	<mtosatti@redhat.com>, <rth@twiddle.net>, <ehabkost@redhat.com>,
	<jonathan.cameron@huawei.com>, <xuwei5@huawei.com>,
	<kvm@vger.kernel.org>, <qemu-devel@nongnu.org>,
	<qemu-arm@nongnu.org>, <linuxarm@huawei.com>,
	<wanghaibin.wang@huawei.com>
Subject: Re: [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM
Date: Mon, 9 Dec 2019 22:12:33 +0800	[thread overview]
Message-ID: <650e26cf-e007-1e31-cd0a-4042bb9fa6a8@huawei.com> (raw)
In-Reply-To: <CADSWDzvFvS6mYiMhXu2J+u+sUxZaKcCE78EuSggv-VOY7zEN_w@mail.gmail.com>



On 2019/12/9 21:05, Beata Michalska wrote:
>> Here we set the FnV to not valid, not to set it to valid.
>> because Guest will use the physical address that recorded in APEI table.
>>
> To be precise : the FnV is  giving the status of FAR - so what you are setting
> here is status of 0b0 which means FAR is valid, not FnV on it's own.
> And my point was that you are changing the prototype for syn_data_abort_no_iss
> just for this case only so I was just thinking that it might not be
> worth that, instead
> you could just set it here ... or to be more flexible , provide a way
> to set specific bits
> on demand.

No, I set the FnV to 0b1, not 0b0, the whole esr_el1's value is 0x96000410, as shown below log:
I remember changing the prototype for syn_data_abort_no_iss is suggested by Peter Maydell.


[1]:
[   62.851830] Internal error: synchronous external abort: 96000410 [#1] PREEMPT SMP
[   62.854465] Modules linked in:



> 


WARNING: multiple messages have this Message-ID (diff)
From: gengdongjiu <gengdongjiu@huawei.com>
To: Beata Michalska <beata.michalska@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
	wanghaibin.wang@huawei.com, mtosatti@redhat.com,
	qemu-devel@nongnu.org, linuxarm@huawei.com,
	shannon.zhaosl@gmail.com, Xiang Zheng <zhengxiang9@huawei.com>,
	qemu-arm@nongnu.org, james.morse@arm.com,
	jonathan.cameron@huawei.com, Igor Mammedov <imammedo@redhat.com>,
	pbonzini@redhat.com, xuwei5@huawei.com,
	Laszlo Ersek <lersek@redhat.com>,
	rth@twiddle.net
Subject: Re: [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM
Date: Mon, 9 Dec 2019 22:12:33 +0800	[thread overview]
Message-ID: <650e26cf-e007-1e31-cd0a-4042bb9fa6a8@huawei.com> (raw)
In-Reply-To: <CADSWDzvFvS6mYiMhXu2J+u+sUxZaKcCE78EuSggv-VOY7zEN_w@mail.gmail.com>



On 2019/12/9 21:05, Beata Michalska wrote:
>> Here we set the FnV to not valid, not to set it to valid.
>> because Guest will use the physical address that recorded in APEI table.
>>
> To be precise : the FnV is  giving the status of FAR - so what you are setting
> here is status of 0b0 which means FAR is valid, not FnV on it's own.
> And my point was that you are changing the prototype for syn_data_abort_no_iss
> just for this case only so I was just thinking that it might not be
> worth that, instead
> you could just set it here ... or to be more flexible , provide a way
> to set specific bits
> on demand.

No, I set the FnV to 0b1, not 0b0, the whole esr_el1's value is 0x96000410, as shown below log:
I remember changing the prototype for syn_data_abort_no_iss is suggested by Peter Maydell.


[1]:
[   62.851830] Internal error: synchronous external abort: 96000410 [#1] PREEMPT SMP
[   62.854465] Modules linked in:



> 



  reply	other threads:[~2019-12-09 14:12 UTC|newest]

Thread overview: 82+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11  1:40 [RESEND PATCH v21 0/6] Add ARMv8 RAS virtualization support in QEMU Xiang Zheng
2019-11-11  1:40 ` Xiang Zheng
2019-11-11  1:40 ` [RESEND PATCH v21 1/6] hw/arm/virt: Introduce a RAS machine option Xiang Zheng
2019-11-11  1:40   ` Xiang Zheng
2019-12-02 18:22   ` Peter Maydell
2019-12-02 18:22     ` Peter Maydell
2019-12-07 12:10     ` gengdongjiu
2019-12-07 12:10       ` gengdongjiu
2019-11-11  1:40 ` [RESEND PATCH v21 2/6] docs: APEI GHES generation and CPER record description Xiang Zheng
2019-11-11  1:40   ` Xiang Zheng
2019-11-15  9:44   ` Igor Mammedov
2019-11-15  9:44     ` Igor Mammedov
2019-11-27  1:37     ` Xiang Zheng
2019-11-27  1:37       ` Xiang Zheng
2019-11-27  8:12       ` Igor Mammedov
2019-11-27  8:12         ` Igor Mammedov
2019-11-11  1:40 ` [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support Xiang Zheng
2019-11-11  1:40   ` Xiang Zheng
2019-11-15  9:38   ` Igor Mammedov
2019-11-15  9:38     ` Igor Mammedov
2019-11-18 12:49     ` gengdongjiu
2019-11-18 12:49       ` gengdongjiu
2019-11-18 13:18       ` gengdongjiu
2019-11-18 13:18         ` gengdongjiu
2019-11-18 13:21         ` Michael S. Tsirkin
2019-11-18 13:21           ` Michael S. Tsirkin
2019-11-18 13:57           ` gengdongjiu
2019-11-18 13:57             ` gengdongjiu
2019-11-25  9:48           ` Igor Mammedov
2019-11-25  9:48             ` Igor Mammedov
2019-11-27 11:16             ` gengdongjiu
2019-11-27 11:16               ` gengdongjiu
2019-11-22 15:44       ` Beata Michalska
2019-11-22 15:44         ` Beata Michalska
2019-11-22 15:42   ` Beata Michalska
2019-11-22 15:42     ` Beata Michalska
2019-11-25  9:23     ` Igor Mammedov
2019-11-25  9:23       ` Igor Mammedov
2019-11-11  1:40 ` [RESEND PATCH v21 4/6] KVM: Move hwpoison page related functions into kvm-all.c Xiang Zheng
2019-11-11  1:40   ` Xiang Zheng
2019-12-02 18:23   ` Peter Maydell
2019-12-02 18:23     ` Peter Maydell
2019-11-11  1:40 ` [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Xiang Zheng
2019-11-11  1:40   ` Xiang Zheng
2019-11-15 16:37   ` Igor Mammedov
2019-11-15 16:37     ` Igor Mammedov
2019-11-22 15:47     ` Beata Michalska
2019-11-22 15:47       ` Beata Michalska
2019-11-25  9:37       ` Igor Mammedov
2019-11-25  9:37         ` Igor Mammedov
2019-11-27  1:40     ` Xiang Zheng
2019-11-27  1:40       ` Xiang Zheng
2019-11-27 10:43       ` Igor Mammedov
2019-11-27 10:43         ` Igor Mammedov
2019-12-21 12:35     ` gengdongjiu
2019-12-21 12:35       ` gengdongjiu
2019-11-22 15:47   ` Beata Michalska
2019-11-22 15:47     ` Beata Michalska
2019-11-27 12:47     ` Xiang Zheng
2019-11-27 12:47       ` Xiang Zheng
2019-11-27 13:02       ` Igor Mammedov
2019-11-27 13:02         ` Igor Mammedov
2019-11-27 14:17         ` Beata Michalska
2019-11-27 14:17           ` Beata Michalska
2019-12-03  3:35           ` Xiang Zheng
2019-12-03  3:35             ` Xiang Zheng
2019-11-27 14:17       ` Beata Michalska
2019-11-27 14:17         ` Beata Michalska
2019-12-03  3:35         ` Xiang Zheng
2019-12-03  3:35           ` Xiang Zheng
2019-12-07  9:33     ` gengdongjiu
2019-12-07  9:33       ` gengdongjiu
2019-12-09 13:05       ` Beata Michalska
2019-12-09 13:05         ` Beata Michalska
2019-12-09 14:12         ` gengdongjiu [this message]
2019-12-09 14:12           ` gengdongjiu
2019-11-11  1:40 ` [RESEND PATCH v21 6/6] MAINTAINERS: Add APCI/APEI/GHES entries Xiang Zheng
2019-11-11  1:40   ` Xiang Zheng
2019-12-02 18:27 ` [RESEND PATCH v21 0/6] Add ARMv8 RAS virtualization support in QEMU Peter Maydell
2019-12-02 18:27   ` Peter Maydell
2019-12-03  2:09   ` gengdongjiu
2019-12-03  2:09     ` gengdongjiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=650e26cf-e007-1e31-cd0a-4042bb9fa6a8@huawei.com \
    --to=gengdongjiu@huawei.com \
    --cc=beata.michalska@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=james.morse@arm.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kvm@vger.kernel.org \
    --cc=lersek@redhat.com \
    --cc=linuxarm@huawei.com \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=shannon.zhaosl@gmail.com \
    --cc=wanghaibin.wang@huawei.com \
    --cc=xuwei5@huawei.com \
    --cc=zhengxiang9@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.