From: gengdongjiu <gengdongjiu@huawei.com> To: Igor Mammedov <imammedo@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com> Cc: <peter.maydell@linaro.org>, <ehabkost@redhat.com>, <kvm@vger.kernel.org>, <wanghaibin.wang@huawei.com>, <mtosatti@redhat.com>, <qemu-devel@nongnu.org>, <linuxarm@huawei.com>, <shannon.zhaosl@gmail.com>, Xiang Zheng <zhengxiang9@huawei.com>, <qemu-arm@nongnu.org>, <james.morse@arm.com>, <jonathan.cameron@huawei.com>, <pbonzini@redhat.com>, <xuwei5@huawei.com>, <lersek@redhat.com>, <rth@twiddle.net> Subject: Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support Date: Wed, 27 Nov 2019 19:16:46 +0800 [thread overview] Message-ID: <6a4bcef4-41f2-af5d-3cce-75718da23719@huawei.com> (raw) In-Reply-To: <20191125104859.70047602@redhat.com> On 2019/11/25 17:48, Igor Mammedov wrote: >>> ...... >>> bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE, >>> ACPI_GHES_ERROR_STATUS_ADDRESS_OFFSET(hest_start, source_id), >>> sizeof(uint64_t), ACPI_GHES_ERRORS_FW_CFG_FILE, >>> source_id * sizeof(uint64_t)); >>> ....... >>> } >>> >>> My previous series patch support 2 error sources, but now only enable 'SEA' type Error Source >> I'd try to merge this, worry about extending things later. >> This is at v21 and the simpler you can keep things, >> the faster it'll go in. > I don't think the series is ready for merging yet. > It has a number of issues (not stylistic ones) that need to be fixed first. > > As for extending, I think I've suggested to simplify series > to account for single error source only in some places so it > would be easier on author and reviewers and worry about extending > it later. sure, thanks for the review, we are preparing another series which will fix the issues that you mentioned. >
WARNING: multiple messages have this Message-ID (diff)
From: gengdongjiu <gengdongjiu@huawei.com> To: Igor Mammedov <imammedo@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com> Cc: peter.maydell@linaro.org, ehabkost@redhat.com, kvm@vger.kernel.org, pbonzini@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, linuxarm@huawei.com, shannon.zhaosl@gmail.com, Xiang Zheng <zhengxiang9@huawei.com>, qemu-arm@nongnu.org, james.morse@arm.com, xuwei5@huawei.com, jonathan.cameron@huawei.com, wanghaibin.wang@huawei.com, lersek@redhat.com, rth@twiddle.net Subject: Re: [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support Date: Wed, 27 Nov 2019 19:16:46 +0800 [thread overview] Message-ID: <6a4bcef4-41f2-af5d-3cce-75718da23719@huawei.com> (raw) In-Reply-To: <20191125104859.70047602@redhat.com> On 2019/11/25 17:48, Igor Mammedov wrote: >>> ...... >>> bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE, >>> ACPI_GHES_ERROR_STATUS_ADDRESS_OFFSET(hest_start, source_id), >>> sizeof(uint64_t), ACPI_GHES_ERRORS_FW_CFG_FILE, >>> source_id * sizeof(uint64_t)); >>> ....... >>> } >>> >>> My previous series patch support 2 error sources, but now only enable 'SEA' type Error Source >> I'd try to merge this, worry about extending things later. >> This is at v21 and the simpler you can keep things, >> the faster it'll go in. > I don't think the series is ready for merging yet. > It has a number of issues (not stylistic ones) that need to be fixed first. > > As for extending, I think I've suggested to simplify series > to account for single error source only in some places so it > would be easier on author and reviewers and worry about extending > it later. sure, thanks for the review, we are preparing another series which will fix the issues that you mentioned. >
next prev parent reply other threads:[~2019-11-27 11:16 UTC|newest] Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-11 1:40 [RESEND PATCH v21 0/6] Add ARMv8 RAS virtualization support in QEMU Xiang Zheng 2019-11-11 1:40 ` Xiang Zheng 2019-11-11 1:40 ` [RESEND PATCH v21 1/6] hw/arm/virt: Introduce a RAS machine option Xiang Zheng 2019-11-11 1:40 ` Xiang Zheng 2019-12-02 18:22 ` Peter Maydell 2019-12-02 18:22 ` Peter Maydell 2019-12-07 12:10 ` gengdongjiu 2019-12-07 12:10 ` gengdongjiu 2019-11-11 1:40 ` [RESEND PATCH v21 2/6] docs: APEI GHES generation and CPER record description Xiang Zheng 2019-11-11 1:40 ` Xiang Zheng 2019-11-15 9:44 ` Igor Mammedov 2019-11-15 9:44 ` Igor Mammedov 2019-11-27 1:37 ` Xiang Zheng 2019-11-27 1:37 ` Xiang Zheng 2019-11-27 8:12 ` Igor Mammedov 2019-11-27 8:12 ` Igor Mammedov 2019-11-11 1:40 ` [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support Xiang Zheng 2019-11-11 1:40 ` Xiang Zheng 2019-11-15 9:38 ` Igor Mammedov 2019-11-15 9:38 ` Igor Mammedov 2019-11-18 12:49 ` gengdongjiu 2019-11-18 12:49 ` gengdongjiu 2019-11-18 13:18 ` gengdongjiu 2019-11-18 13:18 ` gengdongjiu 2019-11-18 13:21 ` Michael S. Tsirkin 2019-11-18 13:21 ` Michael S. Tsirkin 2019-11-18 13:57 ` gengdongjiu 2019-11-18 13:57 ` gengdongjiu 2019-11-25 9:48 ` Igor Mammedov 2019-11-25 9:48 ` Igor Mammedov 2019-11-27 11:16 ` gengdongjiu [this message] 2019-11-27 11:16 ` gengdongjiu 2019-11-22 15:44 ` Beata Michalska 2019-11-22 15:44 ` Beata Michalska 2019-11-22 15:42 ` Beata Michalska 2019-11-22 15:42 ` Beata Michalska 2019-11-25 9:23 ` Igor Mammedov 2019-11-25 9:23 ` Igor Mammedov 2019-11-11 1:40 ` [RESEND PATCH v21 4/6] KVM: Move hwpoison page related functions into kvm-all.c Xiang Zheng 2019-11-11 1:40 ` Xiang Zheng 2019-12-02 18:23 ` Peter Maydell 2019-12-02 18:23 ` Peter Maydell 2019-11-11 1:40 ` [RESEND PATCH v21 5/6] target-arm: kvm64: handle SIGBUS signal from kernel or KVM Xiang Zheng 2019-11-11 1:40 ` Xiang Zheng 2019-11-15 16:37 ` Igor Mammedov 2019-11-15 16:37 ` Igor Mammedov 2019-11-22 15:47 ` Beata Michalska 2019-11-22 15:47 ` Beata Michalska 2019-11-25 9:37 ` Igor Mammedov 2019-11-25 9:37 ` Igor Mammedov 2019-11-27 1:40 ` Xiang Zheng 2019-11-27 1:40 ` Xiang Zheng 2019-11-27 10:43 ` Igor Mammedov 2019-11-27 10:43 ` Igor Mammedov 2019-12-21 12:35 ` gengdongjiu 2019-12-21 12:35 ` gengdongjiu 2019-11-22 15:47 ` Beata Michalska 2019-11-22 15:47 ` Beata Michalska 2019-11-27 12:47 ` Xiang Zheng 2019-11-27 12:47 ` Xiang Zheng 2019-11-27 13:02 ` Igor Mammedov 2019-11-27 13:02 ` Igor Mammedov 2019-11-27 14:17 ` Beata Michalska 2019-11-27 14:17 ` Beata Michalska 2019-12-03 3:35 ` Xiang Zheng 2019-12-03 3:35 ` Xiang Zheng 2019-11-27 14:17 ` Beata Michalska 2019-11-27 14:17 ` Beata Michalska 2019-12-03 3:35 ` Xiang Zheng 2019-12-03 3:35 ` Xiang Zheng 2019-12-07 9:33 ` gengdongjiu 2019-12-07 9:33 ` gengdongjiu 2019-12-09 13:05 ` Beata Michalska 2019-12-09 13:05 ` Beata Michalska 2019-12-09 14:12 ` gengdongjiu 2019-12-09 14:12 ` gengdongjiu 2019-11-11 1:40 ` [RESEND PATCH v21 6/6] MAINTAINERS: Add APCI/APEI/GHES entries Xiang Zheng 2019-11-11 1:40 ` Xiang Zheng 2019-12-02 18:27 ` [RESEND PATCH v21 0/6] Add ARMv8 RAS virtualization support in QEMU Peter Maydell 2019-12-02 18:27 ` Peter Maydell 2019-12-03 2:09 ` gengdongjiu 2019-12-03 2:09 ` gengdongjiu 2019-11-15 14:32 [RESEND PATCH v21 3/6] ACPI: Add APEI GHES table generation support gengdongjiu 2019-11-15 14:32 ` gengdongjiu 2019-11-15 14:55 ` Igor Mammedov 2019-11-15 14:55 ` Igor Mammedov 2019-11-16 0:58 gengdongjiu 2019-11-16 0:58 ` gengdongjiu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6a4bcef4-41f2-af5d-3cce-75718da23719@huawei.com \ --to=gengdongjiu@huawei.com \ --cc=ehabkost@redhat.com \ --cc=imammedo@redhat.com \ --cc=james.morse@arm.com \ --cc=jonathan.cameron@huawei.com \ --cc=kvm@vger.kernel.org \ --cc=lersek@redhat.com \ --cc=linuxarm@huawei.com \ --cc=mst@redhat.com \ --cc=mtosatti@redhat.com \ --cc=pbonzini@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=shannon.zhaosl@gmail.com \ --cc=wanghaibin.wang@huawei.com \ --cc=xuwei5@huawei.com \ --cc=zhengxiang9@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.