All of lore.kernel.org
 help / color / mirror / Atom feed
From: Satoru Moriya <satoru.moriya@hds.com>
To: Satoru Moriya <satoru.moriya@hds.com>,
	KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	Jerome Marchand <jmarchan@redhat.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	"jweiner@redhat.com" <jweiner@redhat.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"riel@redhat.com" <riel@redhat.com>,
	"lwoodman@redhat.com" <lwoodman@redhat.com>,
	"dle-develop@lists.sourceforge.net" 
	<dle-develop@lists.sourceforge.net>,
	Seiji Aguchi <seiji.aguchi@hds.com>
Subject: RE: [RFC][PATCH] avoid swapping out with swappiness==0
Date: Fri, 11 May 2012 17:11:35 -0400	[thread overview]
Message-ID: <65795E11DBF1E645A09CEC7EAEE94B9C01583B4D7C@USINDEVS02.corp.hds.com> (raw)
In-Reply-To: <65795E11DBF1E645A09CEC7EAEE94B9C014575D8CF@USINDEVS02.corp.hds.com>

On 04/20/2012 08:21 PM, Satoru Moriya wrote:
> On 04/04/2012 01:38 PM, KOSAKI Motohiro wrote:
>> (4/3/12 4:25 AM), Jerome Marchand wrote:
>>> On 04/02/2012 07:10 PM, KOSAKI Motohiro wrote:
>>>> 2012/3/30 Satoru Moriya<satoru.moriya@hds.com>:
>>>>> So the kernel reclaims pages like following.
>>>>>
>>>>> nr_free + nr_filebacked>= watermark_high: reclaim only filebacked pages
>>>>> nr_free + nr_filebacked<   watermark_high: reclaim only anonymous pages
>>>>
>>>> How?
>>>
>>> get_scan_count() checks that case explicitly:
>>>
>>>     if (global_reclaim(sc)) {
>>>         free  = zone_page_state(mz->zone, NR_FREE_PAGES);
>>>         /* If we have very few page cache pages,
>>>            force-scan anon pages. */
>>>         if (unlikely(file + free<= high_wmark_pages(mz->zone))) {
>>>             fraction[0] = 1;
>>>             fraction[1] = 0;
>>>             denominator = 1;
>>>             goto out;
>>>         }
>>>     }
>>
>> Eek. This is silly. Nowaday many people enabled THP and it increase zone watermark.
>> so, high watermask is not good threshold anymore.
> 
> Ah yes, it is not so small now.
> On 4GB server, without THP min_free_kbytes is 8113 but with THP it is 
> 67584.
> 
> How about using low watermark or min watermark?
> Are they still big?
> 
> ...or should we use other value? 

What do you think of the idea above?

By the way, I'd like to discuss this topic in other thread
because discussion about optimal threshold where the kernel
changes its reclaim policy does not affect only swappiness==0
case but also all other settings. 

So, I propose that we start with applying this patch first
and then discuss/improve the threshold.

The patch may not be perfect but, at least, we can improve
the kernel behavior in the enough filebacked memory case
with this patch. I believe it's better than nothing.

Regards,
Satoru

WARNING: multiple messages have this Message-ID (diff)
From: Satoru Moriya <satoru.moriya@hds.com>
To: Satoru Moriya <satoru.moriya@hds.com>,
	KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
	Jerome Marchand <jmarchan@redhat.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	"jweiner@redhat.com" <jweiner@redhat.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"riel@redhat.com" <riel@redhat.com>,
	"lwoodman@redhat.com" <lwoodman@redhat.com>,
	"dle-develop@lists.sourceforge.net"
	<dle-develop@lists.sourceforge.net>,
	Seiji Aguchi <seiji.aguchi@hds.com>
Subject: RE: [RFC][PATCH] avoid swapping out with swappiness==0
Date: Fri, 11 May 2012 17:11:35 -0400	[thread overview]
Message-ID: <65795E11DBF1E645A09CEC7EAEE94B9C01583B4D7C@USINDEVS02.corp.hds.com> (raw)
In-Reply-To: <65795E11DBF1E645A09CEC7EAEE94B9C014575D8CF@USINDEVS02.corp.hds.com>

On 04/20/2012 08:21 PM, Satoru Moriya wrote:
> On 04/04/2012 01:38 PM, KOSAKI Motohiro wrote:
>> (4/3/12 4:25 AM), Jerome Marchand wrote:
>>> On 04/02/2012 07:10 PM, KOSAKI Motohiro wrote:
>>>> 2012/3/30 Satoru Moriya<satoru.moriya@hds.com>:
>>>>> So the kernel reclaims pages like following.
>>>>>
>>>>> nr_free + nr_filebacked>= watermark_high: reclaim only filebacked pages
>>>>> nr_free + nr_filebacked<   watermark_high: reclaim only anonymous pages
>>>>
>>>> How?
>>>
>>> get_scan_count() checks that case explicitly:
>>>
>>>     if (global_reclaim(sc)) {
>>>         free  = zone_page_state(mz->zone, NR_FREE_PAGES);
>>>         /* If we have very few page cache pages,
>>>            force-scan anon pages. */
>>>         if (unlikely(file + free<= high_wmark_pages(mz->zone))) {
>>>             fraction[0] = 1;
>>>             fraction[1] = 0;
>>>             denominator = 1;
>>>             goto out;
>>>         }
>>>     }
>>
>> Eek. This is silly. Nowaday many people enabled THP and it increase zone watermark.
>> so, high watermask is not good threshold anymore.
> 
> Ah yes, it is not so small now.
> On 4GB server, without THP min_free_kbytes is 8113 but with THP it is 
> 67584.
> 
> How about using low watermark or min watermark?
> Are they still big?
> 
> ...or should we use other value? 

What do you think of the idea above?

By the way, I'd like to discuss this topic in other thread
because discussion about optimal threshold where the kernel
changes its reclaim policy does not affect only swappiness==0
case but also all other settings. 

So, I propose that we start with applying this patch first
and then discuss/improve the threshold.

The patch may not be perfect but, at least, we can improve
the kernel behavior in the enough filebacked memory case
with this patch. I believe it's better than nothing.

Regards,
Satoru

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-05-11 21:11 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 17:36 [RFC][PATCH] avoid swapping out with swappiness==0 Satoru Moriya
2012-03-02 17:36 ` Satoru Moriya
2012-03-02 22:47 ` Rik van Riel
2012-03-02 22:47   ` Rik van Riel
2012-03-02 23:43   ` Satoru Moriya
2012-03-02 23:43     ` Satoru Moriya
2012-03-03  2:29   ` Hillf Danton
2012-03-03  2:29     ` Hillf Danton
2012-03-04  6:57 ` Minchan Kim
2012-03-04  6:57   ` Minchan Kim
2012-03-05 21:38   ` Satoru Moriya
2012-03-05 21:38     ` Satoru Moriya
2012-03-05 13:49 ` Rik van Riel
2012-03-05 13:49   ` Rik van Riel
2012-03-05 21:56 ` Johannes Weiner
2012-03-05 21:56   ` Johannes Weiner
2012-03-07 17:19   ` KOSAKI Motohiro
2012-03-07 17:19     ` KOSAKI Motohiro
2012-03-07 18:18     ` Satoru Moriya
2012-03-07 18:18       ` Satoru Moriya
2012-03-30 22:44       ` Satoru Moriya
2012-03-30 22:44         ` Satoru Moriya
2012-04-02 17:10         ` KOSAKI Motohiro
2012-04-02 17:10           ` KOSAKI Motohiro
2012-04-03 11:25           ` Jerome Marchand
2012-04-03 11:25             ` Jerome Marchand
2012-04-03 15:15             ` Satoru Moriya
2012-04-03 15:15               ` Satoru Moriya
2012-04-04 17:38             ` KOSAKI Motohiro
2012-04-04 17:38               ` KOSAKI Motohiro
2012-04-21  0:21               ` Satoru Moriya
2012-04-21  0:21                 ` Satoru Moriya
2012-05-11 21:11                 ` Satoru Moriya [this message]
2012-05-11 21:11                   ` Satoru Moriya
2012-05-12 22:21                   ` Rik van Riel
2012-05-12 22:21                     ` Rik van Riel
2012-04-24  8:20       ` Richard Davies
2012-04-24  8:20         ` Richard Davies
2012-04-24 22:14         ` Satoru Moriya
2012-04-24 22:14           ` Satoru Moriya
2012-04-26 14:26           ` Richard Davies
2012-04-26 14:26             ` Richard Davies
2012-04-26 15:41             ` KOSAKI Motohiro
2012-04-26 15:41               ` KOSAKI Motohiro
2012-05-07 20:09               ` Rik van Riel
2012-05-07 20:09                 ` Rik van Riel
2012-05-08  0:05                 ` Minchan Kim
2012-05-08  0:05                   ` Minchan Kim
2012-05-21  7:12                 ` Richard Davies
2012-05-21  7:12                   ` Richard Davies
2012-05-21 13:39                   ` Satoru Moriya
2012-05-21 13:39                     ` Satoru Moriya
2012-04-26 14:50         ` Christoph Lameter
2012-04-26 14:50           ` Christoph Lameter
2012-04-26 15:37           ` KOSAKI Motohiro
2012-04-26 15:37             ` KOSAKI Motohiro
2012-04-26 16:08             ` Richard Davies
2012-04-26 16:08               ` Richard Davies
2012-04-26 18:20             ` Christoph Lameter
2012-04-26 18:20               ` Christoph Lameter
2012-04-27 13:55           ` Rik van Riel
2012-04-27 13:55             ` Rik van Riel
2012-05-07 20:11 ` Rik van Riel
2012-05-07 20:11   ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65795E11DBF1E645A09CEC7EAEE94B9C01583B4D7C@USINDEVS02.corp.hds.com \
    --to=satoru.moriya@hds.com \
    --cc=dle-develop@lists.sourceforge.net \
    --cc=jmarchan@redhat.com \
    --cc=jweiner@redhat.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lwoodman@redhat.com \
    --cc=riel@redhat.com \
    --cc=seiji.aguchi@hds.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.