From: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Marc Zyngier <maz@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
gregkh <gregkh@linuxfoundation.org>, <quic_psodagud@quicinc.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
Prasad Sodagudi <psodagud@codeaurora.org>
Subject: Re: [PATCHv6 4/5] tracing: Add register read/write tracing support
Date: Sat, 15 Jan 2022 18:48:00 +0530 [thread overview]
Message-ID: <65fa7fdb-1af9-152b-32a2-8388921be565@quicinc.com> (raw)
In-Reply-To: <b36d92de-ae0b-243d-f2de-e12fe730f6c4@quicinc.com>
On 1/8/2022 11:04 AM, Sai Prakash Ranjan wrote:
> Hi,
>
> On 1/7/2022 8:26 PM, Steven Rostedt wrote:
>> On Fri, 7 Jan 2022 10:40:05 +0530
>> Sai Prakash Ranjan <quic_saipraka@quicinc.com> wrote:
>>
>>> Hi Steve,
>>>
>>> On 1/6/2022 11:48 PM, Steven Rostedt wrote:
>>>> This should not be in the kernel/trace directory. It should be in the
>>> Hmm these are called from low level generic io header file
>>> (include/asm-generic/) where
>>> we wouldn't have any Kconfig to control this feature flexibly and as we
>>> can have this as
>>> a generic feature selectable by other architectures, wouldn't this be
>>> suited in kernel/trace?
>> Isn't there a place for generic rwmmio code?
>
> I am thinking of moving it to lib/ similar to an interface of
> logic_iomem.c which
> Arnd had initially suggested to look at.
>
>>> I thought you were ok with the folder structure in the initial versions
>>> of the series?
>> Sorry, I missed the C file in kernel/trace. The files in kernel/trace
>> tend
>> to be specific for the internals of tracing. This C file is more to hold
>> helper functions for mmio, which to me should be someplace for mmio
>> code.
>> Perhaps in mm/ ?
>>
>
> Oh ok, mm would not be the right fit as it is memory management and
> this is about
> memory mapped IO, let me try and move it to lib/ as done for
> logic_iomem.c
>
> Thanks,
> Sai
Posted v7 -
https://lore.kernel.org/lkml/cover.1642233364.git.quic_saipraka@quicinc.com/
Thanks,
Sai
WARNING: multiple messages have this Message-ID (diff)
From: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Will Deacon <will@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Marc Zyngier <maz@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
gregkh <gregkh@linuxfoundation.org>, <quic_psodagud@quicinc.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
Prasad Sodagudi <psodagud@codeaurora.org>
Subject: Re: [PATCHv6 4/5] tracing: Add register read/write tracing support
Date: Sat, 15 Jan 2022 18:48:00 +0530 [thread overview]
Message-ID: <65fa7fdb-1af9-152b-32a2-8388921be565@quicinc.com> (raw)
In-Reply-To: <b36d92de-ae0b-243d-f2de-e12fe730f6c4@quicinc.com>
On 1/8/2022 11:04 AM, Sai Prakash Ranjan wrote:
> Hi,
>
> On 1/7/2022 8:26 PM, Steven Rostedt wrote:
>> On Fri, 7 Jan 2022 10:40:05 +0530
>> Sai Prakash Ranjan <quic_saipraka@quicinc.com> wrote:
>>
>>> Hi Steve,
>>>
>>> On 1/6/2022 11:48 PM, Steven Rostedt wrote:
>>>> This should not be in the kernel/trace directory. It should be in the
>>> Hmm these are called from low level generic io header file
>>> (include/asm-generic/) where
>>> we wouldn't have any Kconfig to control this feature flexibly and as we
>>> can have this as
>>> a generic feature selectable by other architectures, wouldn't this be
>>> suited in kernel/trace?
>> Isn't there a place for generic rwmmio code?
>
> I am thinking of moving it to lib/ similar to an interface of
> logic_iomem.c which
> Arnd had initially suggested to look at.
>
>>> I thought you were ok with the folder structure in the initial versions
>>> of the series?
>> Sorry, I missed the C file in kernel/trace. The files in kernel/trace
>> tend
>> to be specific for the internals of tracing. This C file is more to hold
>> helper functions for mmio, which to me should be someplace for mmio
>> code.
>> Perhaps in mm/ ?
>>
>
> Oh ok, mm would not be the right fit as it is memory management and
> this is about
> memory mapped IO, let me try and move it to lib/ as done for
> logic_iomem.c
>
> Thanks,
> Sai
Posted v7 -
https://lore.kernel.org/lkml/cover.1642233364.git.quic_saipraka@quicinc.com/
Thanks,
Sai
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-15 13:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 6:54 [PATCHv6 0/5] tracing/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan
2021-12-07 6:54 ` Sai Prakash Ranjan
2021-12-07 6:54 ` [PATCHv6 1/5] arm64: io: Use asm-generic high level MMIO accessors Sai Prakash Ranjan
2021-12-07 6:54 ` Sai Prakash Ranjan
2021-12-10 18:16 ` Catalin Marinas
2021-12-10 18:16 ` Catalin Marinas
2021-12-10 18:23 ` Catalin Marinas
2021-12-10 18:23 ` Catalin Marinas
2021-12-07 6:54 ` [PATCHv6 2/5] irqchip/tegra: Fix overflow implicit truncation warnings Sai Prakash Ranjan
2021-12-07 6:54 ` Sai Prakash Ranjan
2021-12-07 6:54 ` [PATCHv6 3/5] drm/meson: " Sai Prakash Ranjan
2021-12-07 6:54 ` Sai Prakash Ranjan
2021-12-07 6:54 ` [PATCHv6 4/5] tracing: Add register read/write tracing support Sai Prakash Ranjan
2021-12-07 6:54 ` Sai Prakash Ranjan
2022-01-06 18:18 ` Steven Rostedt
2022-01-06 18:18 ` Steven Rostedt
2022-01-07 5:10 ` Sai Prakash Ranjan
2022-01-07 5:10 ` Sai Prakash Ranjan
2022-01-07 14:56 ` Steven Rostedt
2022-01-07 14:56 ` Steven Rostedt
2022-01-08 5:34 ` Sai Prakash Ranjan
2022-01-08 5:34 ` Sai Prakash Ranjan
2022-01-15 13:18 ` Sai Prakash Ranjan [this message]
2022-01-15 13:18 ` Sai Prakash Ranjan
2021-12-07 6:54 ` [PATCHv6 5/5] asm-generic/io: Add logging support for MMIO accessors Sai Prakash Ranjan
2021-12-07 6:54 ` Sai Prakash Ranjan
2021-12-13 3:28 ` [PATCHv6 0/5] tracing/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan
2021-12-13 3:28 ` Sai Prakash Ranjan
2022-01-03 5:41 ` Sai Prakash Ranjan
2022-01-03 5:41 ` Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65fa7fdb-1af9-152b-32a2-8388921be565@quicinc.com \
--to=quic_saipraka@quicinc.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=psodagud@codeaurora.org \
--cc=quic_psodagud@quicinc.com \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.