From: David Lechner <david@lechnology.com> To: Jonathan Cameron <jic23@kernel.org>, devicetree@vger.kernel.org, linux-iio@vger.kernel.org Cc: Hartmut Knaack <knaack.h@gmx.de>, Lars-Peter Clausen <lars@metafoo.de>, Peter Meerwald-Stadler <pmeerw@pmeerw.net>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] DT/bindings: Add bindings for TI ADS7950 A/DC chips Date: Sat, 14 Jan 2017 12:00:11 -0600 [thread overview] Message-ID: <662a48e1-39fc-4fb7-a3b9-b671d2e40029@lechnology.com> (raw) In-Reply-To: <f1e845c4-7db0-c6fe-fbd2-420902110be9@kernel.org> On 01/14/2017 06:53 AM, Jonathan Cameron wrote: > On 11/01/17 17:52, David Lechner wrote: >> This adds device tree bindings for the TI ADS7950 family of A/DC chips. >> >> Signed-off-by: David Lechner <david@lechnology.com> > This is in of itself good, but we may need to have some deprecated > elements to continue supporting what was implicitly happening with > the missnaming so as to avoid accidentally breaking someone's device > tree. > As I mentioned in my cover letter, this driver, as far as I can tell, only exists in your testing branch, so I find it highly unlikely that we would be breaking anyone. It is not in mainline and it is not even in linux-next. > Jonathan >> --- >> .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> new file mode 100644 >> index 0000000..e77a6f7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> @@ -0,0 +1,23 @@ >> +* Texas Instruments ADS7950 family of A/DC chips >> + >> +Required properties: >> + - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952", >> + "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957", >> + "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961" >> + - reg: SPI chip select number for the device >> + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt >> + - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V >> + reference voltage >> + >> +Recommended properties: >> + - spi-max-frequency: Definition as per >> + Documentation/devicetree/bindings/spi/spi-bus.txt >> + >> +Example: >> +adc@0 { >> + compatible = "ti,ads7957"; >> + reg = <0>; >> + #io-channel-cells = <1>; >> + vref-supply = <&refin_supply>; >> + spi-max-frequency = <10000000>; >> +}; >> >
WARNING: multiple messages have this Message-ID (diff)
From: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> To: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Hartmut Knaack <knaack.h-Mmb7MZpHnFY@public.gmane.org>, Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>, Peter Meerwald-Stadler <pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 1/3] DT/bindings: Add bindings for TI ADS7950 A/DC chips Date: Sat, 14 Jan 2017 12:00:11 -0600 [thread overview] Message-ID: <662a48e1-39fc-4fb7-a3b9-b671d2e40029@lechnology.com> (raw) In-Reply-To: <f1e845c4-7db0-c6fe-fbd2-420902110be9-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> On 01/14/2017 06:53 AM, Jonathan Cameron wrote: > On 11/01/17 17:52, David Lechner wrote: >> This adds device tree bindings for the TI ADS7950 family of A/DC chips. >> >> Signed-off-by: David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> > This is in of itself good, but we may need to have some deprecated > elements to continue supporting what was implicitly happening with > the missnaming so as to avoid accidentally breaking someone's device > tree. > As I mentioned in my cover letter, this driver, as far as I can tell, only exists in your testing branch, so I find it highly unlikely that we would be breaking anyone. It is not in mainline and it is not even in linux-next. > Jonathan >> --- >> .../devicetree/bindings/iio/adc/ti-ads7950.txt | 23 ++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> new file mode 100644 >> index 0000000..e77a6f7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/ti-ads7950.txt >> @@ -0,0 +1,23 @@ >> +* Texas Instruments ADS7950 family of A/DC chips >> + >> +Required properties: >> + - compatible: Must be one of "ti,ads7950", "ti,ads7951", "ti,ads7952", >> + "ti,ads7953", "ti,ads7954", "ti,ads7955", "ti,ads7956", "ti,ads7957", >> + "ti,ads7958", "ti,ads7959", "ti,ads7960", or "ti,ads7961" >> + - reg: SPI chip select number for the device >> + - #io-channel-cells: Must be 1 as per ../iio-bindings.txt >> + - vref-supply: phandle to a regulator node that supplies the 2.5V or 5V >> + reference voltage >> + >> +Recommended properties: >> + - spi-max-frequency: Definition as per >> + Documentation/devicetree/bindings/spi/spi-bus.txt >> + >> +Example: >> +adc@0 { >> + compatible = "ti,ads7957"; >> + reg = <0>; >> + #io-channel-cells = <1>; >> + vref-supply = <&refin_supply>; >> + spi-max-frequency = <10000000>; >> +}; >> >
next prev parent reply other threads:[~2017-01-14 18:00 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-01-11 17:52 [PATCH 0/3] ti,ads7950 device tree bindings David Lechner 2017-01-11 17:52 ` [PATCH 1/3] DT/bindings: Add bindings for TI ADS7950 A/DC chips David Lechner 2017-01-14 12:53 ` Jonathan Cameron 2017-01-14 12:53 ` Jonathan Cameron 2017-01-14 18:00 ` David Lechner [this message] 2017-01-14 18:00 ` David Lechner 2017-01-15 13:52 ` Jonathan Cameron 2017-01-18 19:54 ` Rob Herring 2017-01-18 19:54 ` Rob Herring 2017-01-11 17:52 ` [PATCH 2/3] iio: adc: ti-ads7950: Drop "ti-" prefix from module name David Lechner 2017-01-14 12:49 ` Jonathan Cameron 2017-01-14 12:49 ` Jonathan Cameron 2017-01-14 18:07 ` David Lechner 2017-01-15 13:54 ` Jonathan Cameron 2017-01-11 17:52 ` [PATCH 3/3] iio: adc: ti-ads7950: Change regulator matching string to "vref" David Lechner 2017-01-14 12:52 ` Jonathan Cameron 2017-01-14 12:52 ` Jonathan Cameron 2017-01-14 18:09 ` David Lechner 2017-01-14 18:09 ` David Lechner 2017-01-15 13:55 ` Jonathan Cameron 2017-01-15 13:58 ` [PATCH 0/3] ti,ads7950 device tree bindings Jonathan Cameron 2017-01-15 13:58 ` Jonathan Cameron 2017-01-15 23:44 ` David Lechner 2017-01-15 23:44 ` David Lechner 2017-01-21 15:08 ` Jonathan Cameron 2017-01-21 15:08 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=662a48e1-39fc-4fb7-a3b9-b671d2e40029@lechnology.com \ --to=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pmeerw@pmeerw.net \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.