From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Viorel Suman <viorel.suman@oss.nxp.com>
Cc: Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Viorel Suman <viorel.suman@nxp.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0
Date: Fri, 16 Sep 2022 11:30:13 +0100 [thread overview]
Message-ID: <66a057d4-8c52-6a64-c23f-ba4a4428efb5@linaro.org> (raw)
In-Reply-To: <20220916101738.xn7xx7ipf7p5dbok@fsr-ub1664-116>
On 16/09/2022 11:17, Viorel Suman wrote:
> On 22-09-16 10:38:30, Krzysztof Kozlowski wrote:
>> On 15/09/2022 19:18, Viorel Suman (OSS) wrote:
>>> From: Viorel Suman <viorel.suman@nxp.com>
>>>
>>> Sync defines with the latest available SCFW kit version 1.13.0,
>>> may be found at the address below:
>>>
>>> https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.0&appType=license
>>>
>>> Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
>>> ---
>>> include/dt-bindings/firmware/imx/rsrc.h | 299 ++++++++++++++++--------
>>> 1 file changed, 203 insertions(+), 96 deletions(-)
>>>
>>> diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h
>>> index 43885056557c..a4c68f394986 100644
>>> --- a/include/dt-bindings/firmware/imx/rsrc.h
>>> +++ b/include/dt-bindings/firmware/imx/rsrc.h
>>> @@ -13,34 +13,38 @@
>>> * never be changed or removed (only added to at the end of the list).
>>> */
>>>
>>> -#define IMX_SC_R_A53 0
>>> -#define IMX_SC_R_A53_0 1
>>
>> You cannot change binding constants... Aren't you breaking all possible
>> boards and users?
>
> Hi Krzysztof,
>
> There is a backward compatibility section added in the end of the patch,
> it follows the same approach as in SCFW kit v1.13.0:
>
> +/*
> + * Compatibility defines for sc_rsrc_t
> + */
> +#define IMX_SC_R_A35 IMX_SC_R_AP_2
Then it looks fine, except someone would need to compare/test the numbers...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Viorel Suman <viorel.suman@oss.nxp.com>
Cc: Abel Vesa <abelvesa@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Viorel Suman <viorel.suman@nxp.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0
Date: Fri, 16 Sep 2022 11:30:13 +0100 [thread overview]
Message-ID: <66a057d4-8c52-6a64-c23f-ba4a4428efb5@linaro.org> (raw)
In-Reply-To: <20220916101738.xn7xx7ipf7p5dbok@fsr-ub1664-116>
On 16/09/2022 11:17, Viorel Suman wrote:
> On 22-09-16 10:38:30, Krzysztof Kozlowski wrote:
>> On 15/09/2022 19:18, Viorel Suman (OSS) wrote:
>>> From: Viorel Suman <viorel.suman@nxp.com>
>>>
>>> Sync defines with the latest available SCFW kit version 1.13.0,
>>> may be found at the address below:
>>>
>>> https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.0&appType=license
>>>
>>> Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
>>> ---
>>> include/dt-bindings/firmware/imx/rsrc.h | 299 ++++++++++++++++--------
>>> 1 file changed, 203 insertions(+), 96 deletions(-)
>>>
>>> diff --git a/include/dt-bindings/firmware/imx/rsrc.h b/include/dt-bindings/firmware/imx/rsrc.h
>>> index 43885056557c..a4c68f394986 100644
>>> --- a/include/dt-bindings/firmware/imx/rsrc.h
>>> +++ b/include/dt-bindings/firmware/imx/rsrc.h
>>> @@ -13,34 +13,38 @@
>>> * never be changed or removed (only added to at the end of the list).
>>> */
>>>
>>> -#define IMX_SC_R_A53 0
>>> -#define IMX_SC_R_A53_0 1
>>
>> You cannot change binding constants... Aren't you breaking all possible
>> boards and users?
>
> Hi Krzysztof,
>
> There is a backward compatibility section added in the end of the patch,
> it follows the same approach as in SCFW kit v1.13.0:
>
> +/*
> + * Compatibility defines for sc_rsrc_t
> + */
> +#define IMX_SC_R_A35 IMX_SC_R_AP_2
Then it looks fine, except someone would need to compare/test the numbers...
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-09-16 10:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 18:18 [PATCH 0/2] sync SCFW defines with SCFW kit v1.13.0 Viorel Suman (OSS)
2022-09-15 18:18 ` Viorel Suman (OSS)
2022-09-15 18:18 ` [PATCH 1/2] dt-bindings: firmware: imx: sync " Viorel Suman (OSS)
2022-09-15 18:18 ` Viorel Suman (OSS)
2022-09-16 6:30 ` Alexander Stein
2022-09-16 6:30 ` Alexander Stein
[not found] ` <20220916110936.jmxgjps5zrcndjxn@fsr-ub1664-116>
2022-09-16 13:03 ` Alexander Stein
2022-09-16 13:03 ` Alexander Stein
2022-09-16 7:43 ` Ahmad Fatoum
2022-09-16 7:43 ` Ahmad Fatoum
2022-09-16 10:36 ` Viorel Suman
2022-09-16 10:36 ` Viorel Suman
2022-09-16 9:38 ` Krzysztof Kozlowski
2022-09-16 9:38 ` Krzysztof Kozlowski
2022-09-16 10:17 ` Viorel Suman
2022-09-16 10:17 ` Viorel Suman
2022-09-16 10:30 ` Krzysztof Kozlowski [this message]
2022-09-16 10:30 ` Krzysztof Kozlowski
2022-09-15 18:18 ` [PATCH 2/2] clk: imx8qm: " Viorel Suman (OSS)
2022-09-15 18:18 ` Viorel Suman (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66a057d4-8c52-6a64-c23f-ba4a4428efb5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=abelvesa@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=viorel.suman@nxp.com \
--cc=viorel.suman@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.