From: Christophe Kerello <christophe.kerello@foss.st.com> To: Tudor Ambarus <tudor.ambarus@linaro.org>, Miquel Raynal <miquel.raynal@bootlin.com> Cc: <richard@nod.at>, <vigneshr@ti.com>, <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com> Subject: Re: [PATCH v2 2/2] mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min Date: Tue, 28 Mar 2023 09:27:55 +0200 [thread overview] Message-ID: <6759a843-409b-d9fe-8a00-ed6d69144aaf@foss.st.com> (raw) In-Reply-To: <70d0a8b6-62c2-fa3e-df5c-f86ba75484d0@linaro.org> Hello Miquel, On 3/27/23 13:06, Tudor Ambarus wrote: > > > On 3/27/23 11:43, Miquel Raynal wrote: >> Hi Tudor, >> >> tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100: >> >>> On 3/27/23 10:47, Christophe Kerello wrote: >>>> This patch is using timings.mode value instead of checking tRC_min timing >>>> for EDO mode support. >>>> >>> >>> Fixes and Cc to stable here too, as you'd like to have this backported >>> as well, don't you? >> >> Actually the reason why Christophe split this into two patches is >> because timings.mode was introduced rather lately, he wanted the same >> patch to apply on all stable kernels, he actually asked for that split >> and I agreed (another solution would have been to send this current >> patch to Linus and have the other version sent to stable, but it >> requires a bit of scheduling on both ends). >> >> Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13/T/#t > > Right, I understood that from the beginning. If it were to me, I would > Cc: stable@vger.kernel.org #v5.4+ for the first patch and > Cc: stable@vger.kernel.org #v5.10+ for the second. > > So first would be alone just in v5.4, and starting with v5.10 we'll have > both and we'll mimic what we currently have in upstream mainline. > I can send a V3 with cc tag added as per Tudor's suggestion. Or cc tag will be added when the patches will be applied? Regards, Christophe Kerello. >> >>> >>>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> >>> >>> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> >>> >>>> --- >>>> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>> index 3abb63d00a0b..9e74bcd90aaa 100644 >>>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>> @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, >>>> if (IS_ERR(sdrt)) >>>> return PTR_ERR(sdrt); >>>> >>>> - if (sdrt->tRC_min < 30000) >>>> + if (conf->timings.mode > 3) >>>> return -EOPNOTSUPP; >>>> >>>> if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) >> >> >> Thanks, >> Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Kerello <christophe.kerello@foss.st.com> To: Tudor Ambarus <tudor.ambarus@linaro.org>, Miquel Raynal <miquel.raynal@bootlin.com> Cc: <richard@nod.at>, <vigneshr@ti.com>, <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com> Subject: Re: [PATCH v2 2/2] mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min Date: Tue, 28 Mar 2023 09:27:55 +0200 [thread overview] Message-ID: <6759a843-409b-d9fe-8a00-ed6d69144aaf@foss.st.com> (raw) In-Reply-To: <70d0a8b6-62c2-fa3e-df5c-f86ba75484d0@linaro.org> Hello Miquel, On 3/27/23 13:06, Tudor Ambarus wrote: > > > On 3/27/23 11:43, Miquel Raynal wrote: >> Hi Tudor, >> >> tudor.ambarus@linaro.org wrote on Mon, 27 Mar 2023 11:30:51 +0100: >> >>> On 3/27/23 10:47, Christophe Kerello wrote: >>>> This patch is using timings.mode value instead of checking tRC_min timing >>>> for EDO mode support. >>>> >>> >>> Fixes and Cc to stable here too, as you'd like to have this backported >>> as well, don't you? >> >> Actually the reason why Christophe split this into two patches is >> because timings.mode was introduced rather lately, he wanted the same >> patch to apply on all stable kernels, he actually asked for that split >> and I agreed (another solution would have been to send this current >> patch to Linus and have the other version sent to stable, but it >> requires a bit of scheduling on both ends). >> >> Link: https://lore.kernel.org/linux-mtd/20230327101156.0ec2816a@xps-13/T/#t > > Right, I understood that from the beginning. If it were to me, I would > Cc: stable@vger.kernel.org #v5.4+ for the first patch and > Cc: stable@vger.kernel.org #v5.10+ for the second. > > So first would be alone just in v5.4, and starting with v5.10 we'll have > both and we'll mimic what we currently have in upstream mainline. > I can send a V3 with cc tag added as per Tudor's suggestion. Or cc tag will be added when the patches will be applied? Regards, Christophe Kerello. >> >>> >>>> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> >>> >>> Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> >>> >>>> --- >>>> drivers/mtd/nand/raw/stm32_fmc2_nand.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>> index 3abb63d00a0b..9e74bcd90aaa 100644 >>>> --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>> +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c >>>> @@ -1531,7 +1531,7 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, >>>> if (IS_ERR(sdrt)) >>>> return PTR_ERR(sdrt); >>>> >>>> - if (sdrt->tRC_min < 30000) >>>> + if (conf->timings.mode > 3) >>>> return -EOPNOTSUPP; >>>> >>>> if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) >> >> >> Thanks, >> Miquèl ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-03-28 7:28 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-27 9:47 [PATCH v2 0/2] mtd: rawnand: stm32_fmc2: do not support EDO mode Christophe Kerello 2023-03-27 9:47 ` Christophe Kerello 2023-03-27 9:47 ` [PATCH v2 1/2] " Christophe Kerello 2023-03-27 9:47 ` Christophe Kerello 2023-03-27 10:29 ` Tudor Ambarus 2023-03-27 10:29 ` Tudor Ambarus 2023-03-27 10:40 ` Miquel Raynal 2023-03-27 10:40 ` Miquel Raynal 2023-03-27 9:47 ` [PATCH v2 2/2] mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min Christophe Kerello 2023-03-27 9:47 ` Christophe Kerello 2023-03-27 10:30 ` Tudor Ambarus 2023-03-27 10:30 ` Tudor Ambarus 2023-03-27 10:43 ` Miquel Raynal 2023-03-27 10:43 ` Miquel Raynal 2023-03-27 11:06 ` Tudor Ambarus 2023-03-27 11:06 ` Tudor Ambarus 2023-03-28 7:27 ` Christophe Kerello [this message] 2023-03-28 7:27 ` Christophe Kerello 2023-03-28 7:56 ` Miquel Raynal 2023-03-28 7:56 ` Miquel Raynal 2023-03-28 9:38 ` Christophe Kerello 2023-03-28 9:38 ` Christophe Kerello 2023-03-28 14:01 ` Miquel Raynal 2023-03-28 14:01 ` Miquel Raynal 2023-03-27 10:09 ` [PATCH v2 0/2] mtd: rawnand: stm32_fmc2: do not support EDO mode Tudor Ambarus 2023-03-27 10:09 ` Tudor Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6759a843-409b-d9fe-8a00-ed6d69144aaf@foss.st.com \ --to=christophe.kerello@foss.st.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=tudor.ambarus@linaro.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.