From: Tudor Ambarus <tudor.ambarus@linaro.org> To: Christophe Kerello <christophe.kerello@foss.st.com>, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 1/2] mtd: rawnand: stm32_fmc2: do not support EDO mode Date: Mon, 27 Mar 2023 11:29:56 +0100 [thread overview] Message-ID: <a17cd888-ef4d-ced0-adba-c6a6abdba51a@linaro.org> (raw) In-Reply-To: <20230327094742.38856-2-christophe.kerello@foss.st.com> Hi, On 3/27/23 10:47, Christophe Kerello wrote: > FMC2 controller does not support EDO mode (timings mode 4 and 5). > commit subject and message should be in imperative mood, so I would change the commit subject to "mtd: rawnand: stm32_fmc2: Remove unsupported EDO mode" and the message to something like "Remove the EDO mode support from as the FMC2 controller does not support the feature." Extra points if you describe what happened when you used timings mode 4 and 5 with the current version of the driver. Miquel, could you add Cc to stable when applying? Cc: stable@vger.kernel.org > Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> > Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver") Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > index 5d627048c420..3abb63d00a0b 100644 > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > @@ -1531,6 +1531,9 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, > if (IS_ERR(sdrt)) > return PTR_ERR(sdrt); > > + if (sdrt->tRC_min < 30000) > + return -EOPNOTSUPP; > + > if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) > return 0; >
WARNING: multiple messages have this Message-ID (diff)
From: Tudor Ambarus <tudor.ambarus@linaro.org> To: Christophe Kerello <christophe.kerello@foss.st.com>, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 1/2] mtd: rawnand: stm32_fmc2: do not support EDO mode Date: Mon, 27 Mar 2023 11:29:56 +0100 [thread overview] Message-ID: <a17cd888-ef4d-ced0-adba-c6a6abdba51a@linaro.org> (raw) In-Reply-To: <20230327094742.38856-2-christophe.kerello@foss.st.com> Hi, On 3/27/23 10:47, Christophe Kerello wrote: > FMC2 controller does not support EDO mode (timings mode 4 and 5). > commit subject and message should be in imperative mood, so I would change the commit subject to "mtd: rawnand: stm32_fmc2: Remove unsupported EDO mode" and the message to something like "Remove the EDO mode support from as the FMC2 controller does not support the feature." Extra points if you describe what happened when you used timings mode 4 and 5 with the current version of the driver. Miquel, could you add Cc to stable when applying? Cc: stable@vger.kernel.org > Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> > Fixes: 2cd457f328c1 ("mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver") Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- > drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > index 5d627048c420..3abb63d00a0b 100644 > --- a/drivers/mtd/nand/raw/stm32_fmc2_nand.c > +++ b/drivers/mtd/nand/raw/stm32_fmc2_nand.c > @@ -1531,6 +1531,9 @@ static int stm32_fmc2_nfc_setup_interface(struct nand_chip *chip, int chipnr, > if (IS_ERR(sdrt)) > return PTR_ERR(sdrt); > > + if (sdrt->tRC_min < 30000) > + return -EOPNOTSUPP; > + > if (chipnr == NAND_DATA_IFACE_CHECK_ONLY) > return 0; > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2023-03-27 10:30 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-27 9:47 [PATCH v2 0/2] mtd: rawnand: stm32_fmc2: do not support EDO mode Christophe Kerello 2023-03-27 9:47 ` Christophe Kerello 2023-03-27 9:47 ` [PATCH v2 1/2] " Christophe Kerello 2023-03-27 9:47 ` Christophe Kerello 2023-03-27 10:29 ` Tudor Ambarus [this message] 2023-03-27 10:29 ` Tudor Ambarus 2023-03-27 10:40 ` Miquel Raynal 2023-03-27 10:40 ` Miquel Raynal 2023-03-27 9:47 ` [PATCH v2 2/2] mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min Christophe Kerello 2023-03-27 9:47 ` Christophe Kerello 2023-03-27 10:30 ` Tudor Ambarus 2023-03-27 10:30 ` Tudor Ambarus 2023-03-27 10:43 ` Miquel Raynal 2023-03-27 10:43 ` Miquel Raynal 2023-03-27 11:06 ` Tudor Ambarus 2023-03-27 11:06 ` Tudor Ambarus 2023-03-28 7:27 ` Christophe Kerello 2023-03-28 7:27 ` Christophe Kerello 2023-03-28 7:56 ` Miquel Raynal 2023-03-28 7:56 ` Miquel Raynal 2023-03-28 9:38 ` Christophe Kerello 2023-03-28 9:38 ` Christophe Kerello 2023-03-28 14:01 ` Miquel Raynal 2023-03-28 14:01 ` Miquel Raynal 2023-03-27 10:09 ` [PATCH v2 0/2] mtd: rawnand: stm32_fmc2: do not support EDO mode Tudor Ambarus 2023-03-27 10:09 ` Tudor Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a17cd888-ef4d-ced0-adba-c6a6abdba51a@linaro.org \ --to=tudor.ambarus@linaro.org \ --cc=christophe.kerello@foss.st.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.