From: Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org> To: Boris Brezillon <boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> Cc: "David Woodhouse" <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, "Brian Norris" <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Boris Brezillon" <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, "Marek Vasut" <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Richard Weinberger" <richard-/L3Ra7n9ekc@public.gmane.org>, "Cyrille Pitchen" <cyrille.pitchen-yU5RGvR974pGWvitb5QawA@public.gmane.org>, "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" <linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>, "Mark Brown" <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "Peter Pan" <peterpansjtu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, "Frieder Schrempf" <frieder.schrempf-wPoT/lNZgHizQB+pC5nmwQ@public.gmane.org>, "Yogesh Gaur" <yogeshnarayan.gaur-3arQi8VN3Tc@public.gmane.org>, "Rafał Miłecki" <rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org>, "Kamal Dasu" <kdasu.kdev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Subject: Re: [RFC PATCH 4/6] spi: ti-qspi: Implement the spi_mem interface Date: Mon, 12 Feb 2018 21:30:09 +0530 [thread overview] Message-ID: <67e61203-a2e9-853c-6cda-7226499611c2@ti.com> (raw) In-Reply-To: <20180212133158.3032442f@bbrezillon> On 12-Feb-18 6:01 PM, Boris Brezillon wrote: > On Mon, 12 Feb 2018 17:13:55 +0530 > Vignesh R <vigneshr-l0cyMroinI0@public.gmane.org> wrote: > >> On Tuesday 06 February 2018 04:51 AM, Boris Brezillon wrote: >> > From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> >> > >> > The spi_mem interface is meant to replace the spi_flash_read() one. >> > Implement the ->exec_op() method so that we can smoothly get rid of the >> > old interface. >> > >> > Signed-off-by: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> >> > --- >> > drivers/spi/spi-ti-qspi.c | 85 +++++++++++++++++++++++++++++++++++++++-------- >> > 1 file changed, 72 insertions(+), 13 deletions(-) >> > >> > diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c >> > index c24d9b45a27c..40cac3ef6cc9 100644 >> > --- a/drivers/spi/spi-ti-qspi.c >> > +++ b/drivers/spi/spi-ti-qspi.c >> >> [...] >> >> > +static const struct spi_controller_mem_ops ti_qspi_mem_ops = { >> > + .exec_op = ti_qspi_exec_mem_op, >> >> .supports_op = ti_qspi_supports_mem_op, >> >> Its required as per spi_controller_check_ops() in Patch 1/6 > > ->supports_op() is optional, and if it's missing, the core will do the > regular QuadSPI/DualSPI/SingleSPI check (see spi_mem_supports_op() > implementation). You might have overlooked spi_controller_check_ops() from Patch 1/6: +static int spi_controller_check_ops(struct spi_controller *ctlr) +{ + /* + * The controller can implement only the high-level SPI-memory + * operations if it does not support regular SPI transfers. + */ + if (ctlr->mem_ops) { + if (!ctlr->mem_ops->supports_op || + !ctlr->mem_ops->exec_op) + return -EINVAL; + } else if (!ctlr->transfer && !ctlr->transfer_one && + !ctlr->transfer_one_message) { + return -EINVAL; + } + + return 0; +} + So if ->supports_op() is not populated by SPI controller driver, then driver probe fails with -EINVAL. This is what I observed on my TI hardware when testing this patch series. > This being said, if you think a custom ->supports_op() > implementation is needed for this controller I can add one. > spi_mem_supports_op() should suffice for now if above issue is fixed. Regards Vignesh -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr@ti.com> To: Boris Brezillon <boris.brezillon@bootlin.com> Cc: "David Woodhouse" <dwmw2@infradead.org>, "Brian Norris" <computersforpeace@gmail.com>, "Boris Brezillon" <boris.brezillon@free-electrons.com>, "Marek Vasut" <marek.vasut@gmail.com>, "Richard Weinberger" <richard@nod.at>, "Cyrille Pitchen" <cyrille.pitchen@wedev4u.fr>, "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>, "Mark Brown" <broonie@kernel.org>, "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>, "Peter Pan" <peterpansjtu@gmail.com>, "Frieder Schrempf" <frieder.schrempf@exceet.de>, "Yogesh Gaur" <yogeshnarayan.gaur@nxp.com>, "Rafał Miłecki" <rafal@milecki.pl>, "Kamal Dasu" <kdasu.kdev@gmail.com> Subject: Re: [RFC PATCH 4/6] spi: ti-qspi: Implement the spi_mem interface Date: Mon, 12 Feb 2018 21:30:09 +0530 [thread overview] Message-ID: <67e61203-a2e9-853c-6cda-7226499611c2@ti.com> (raw) In-Reply-To: <20180212133158.3032442f@bbrezillon> On 12-Feb-18 6:01 PM, Boris Brezillon wrote: > On Mon, 12 Feb 2018 17:13:55 +0530 > Vignesh R <vigneshr@ti.com> wrote: > >> On Tuesday 06 February 2018 04:51 AM, Boris Brezillon wrote: >> > From: Boris Brezillon <boris.brezillon@free-electrons.com> >> > >> > The spi_mem interface is meant to replace the spi_flash_read() one. >> > Implement the ->exec_op() method so that we can smoothly get rid of the >> > old interface. >> > >> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com> >> > --- >> > drivers/spi/spi-ti-qspi.c | 85 +++++++++++++++++++++++++++++++++++++++-------- >> > 1 file changed, 72 insertions(+), 13 deletions(-) >> > >> > diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c >> > index c24d9b45a27c..40cac3ef6cc9 100644 >> > --- a/drivers/spi/spi-ti-qspi.c >> > +++ b/drivers/spi/spi-ti-qspi.c >> >> [...] >> >> > +static const struct spi_controller_mem_ops ti_qspi_mem_ops = { >> > + .exec_op = ti_qspi_exec_mem_op, >> >> .supports_op = ti_qspi_supports_mem_op, >> >> Its required as per spi_controller_check_ops() in Patch 1/6 > > ->supports_op() is optional, and if it's missing, the core will do the > regular QuadSPI/DualSPI/SingleSPI check (see spi_mem_supports_op() > implementation). You might have overlooked spi_controller_check_ops() from Patch 1/6: +static int spi_controller_check_ops(struct spi_controller *ctlr) +{ + /* + * The controller can implement only the high-level SPI-memory + * operations if it does not support regular SPI transfers. + */ + if (ctlr->mem_ops) { + if (!ctlr->mem_ops->supports_op || + !ctlr->mem_ops->exec_op) + return -EINVAL; + } else if (!ctlr->transfer && !ctlr->transfer_one && + !ctlr->transfer_one_message) { + return -EINVAL; + } + + return 0; +} + So if ->supports_op() is not populated by SPI controller driver, then driver probe fails with -EINVAL. This is what I observed on my TI hardware when testing this patch series. > This being said, if you think a custom ->supports_op() > implementation is needed for this controller I can add one. > spi_mem_supports_op() should suffice for now if above issue is fixed. Regards Vignesh
next prev parent reply other threads:[~2018-02-12 16:00 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-05 23:21 [RFC PATCH 0/6] spi: Extend the framework to generically support memory devices Boris Brezillon 2018-02-05 23:21 ` Boris Brezillon [not found] ` <20180205232120.5851-1-boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> 2018-02-05 23:21 ` [RFC PATCH 1/6] spi: Extend the core to ease integration of SPI memory controllers Boris Brezillon 2018-02-05 23:21 ` Boris Brezillon [not found] ` <20180205232120.5851-2-boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> 2018-02-06 9:43 ` Maxime Chevallier 2018-02-06 9:43 ` Maxime Chevallier 2018-02-06 10:25 ` Boris Brezillon 2018-02-06 10:25 ` Boris Brezillon 2018-02-06 12:06 ` Mark Brown 2018-02-06 12:06 ` Mark Brown 2018-02-09 12:52 ` Miquel Raynal 2018-02-09 12:52 ` Miquel Raynal 2018-02-11 16:00 ` Boris Brezillon 2018-02-11 16:00 ` Boris Brezillon 2018-02-12 11:50 ` Vignesh R 2018-02-12 11:50 ` Vignesh R [not found] ` <40a44152-e62c-d57e-7646-7699301c29cc-l0cyMroinI0@public.gmane.org> 2018-02-12 12:28 ` Boris Brezillon 2018-02-12 12:28 ` Boris Brezillon 2018-02-19 13:53 ` Mark Brown 2018-02-19 14:20 ` Boris Brezillon 2018-02-19 14:00 ` Mark Brown 2018-02-19 14:32 ` Boris Brezillon 2018-02-28 7:51 ` Peter Pan 2018-02-28 7:51 ` Peter Pan 2018-02-28 12:25 ` Boris Brezillon 2018-02-28 12:25 ` Boris Brezillon 2018-03-04 21:15 ` Cyrille Pitchen 2018-03-04 21:15 ` Cyrille Pitchen 2018-03-05 9:00 ` Boris Brezillon 2018-03-05 9:00 ` Boris Brezillon 2018-03-05 13:01 ` Cyrille Pitchen 2018-03-05 13:01 ` Cyrille Pitchen 2018-03-05 13:47 ` Boris Brezillon 2018-03-05 13:47 ` Boris Brezillon 2018-03-08 14:07 ` Boris Brezillon 2018-03-08 14:07 ` Boris Brezillon 2018-02-05 23:21 ` [RFC PATCH 2/6] spi: bcm-qspi: Implement the spi_mem interface Boris Brezillon 2018-02-05 23:21 ` Boris Brezillon 2018-02-05 23:21 ` [RFC PATCH 3/6] spi: bcm53xx: " Boris Brezillon 2018-02-05 23:21 ` Boris Brezillon 2018-02-05 23:21 ` [RFC PATCH 4/6] spi: ti-qspi: " Boris Brezillon 2018-02-05 23:21 ` Boris Brezillon [not found] ` <20180205232120.5851-5-boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> 2018-02-11 15:17 ` Miquel Raynal 2018-02-11 15:17 ` Miquel Raynal 2018-02-11 17:18 ` Boris Brezillon 2018-02-11 17:18 ` Boris Brezillon 2018-02-12 7:54 ` Miquel Raynal 2018-02-12 7:54 ` Miquel Raynal 2018-02-12 11:43 ` Vignesh R 2018-02-12 11:43 ` Vignesh R [not found] ` <6a9eaaaf-20a6-b332-03d0-9d16e24d0b3d-l0cyMroinI0@public.gmane.org> 2018-02-12 12:31 ` Boris Brezillon 2018-02-12 12:31 ` Boris Brezillon 2018-02-12 16:00 ` Vignesh R [this message] 2018-02-12 16:00 ` Vignesh R [not found] ` <67e61203-a2e9-853c-6cda-7226499611c2-l0cyMroinI0@public.gmane.org> 2018-02-12 16:08 ` Boris Brezillon 2018-02-12 16:08 ` Boris Brezillon 2018-02-14 16:25 ` Vignesh R 2018-02-14 16:25 ` Vignesh R [not found] ` <0944fefa-6ef8-a93a-dad6-660044b8ec8e-l0cyMroinI0@public.gmane.org> 2018-02-14 19:09 ` Boris Brezillon 2018-02-14 19:09 ` Boris Brezillon 2018-02-14 20:44 ` Schrempf Frieder 2018-02-14 20:44 ` Schrempf Frieder [not found] ` <561c779b-28b1-ac8a-6b27-46b5ac59344b-wPoT/lNZgHizQB+pC5nmwQ@public.gmane.org> 2018-02-14 21:00 ` Boris Brezillon 2018-02-14 21:00 ` Boris Brezillon 2018-02-15 16:38 ` Schrempf Frieder 2018-02-15 16:38 ` Schrempf Frieder 2018-02-17 11:01 ` Vignesh R 2018-02-17 11:01 ` Vignesh R [not found] ` <55878296-f1c9-434b-3c7e-e2f03f5824a9-l0cyMroinI0@public.gmane.org> 2018-02-17 21:52 ` Boris Brezillon 2018-02-17 21:52 ` Boris Brezillon 2018-02-16 10:25 ` Boris Brezillon 2018-02-16 10:25 ` Boris Brezillon 2018-02-05 23:21 ` [RFC PATCH 5/6] mtd: spi-nor: Use the spi_mem_xx() API Boris Brezillon 2018-02-05 23:21 ` Boris Brezillon [not found] ` <20180205232120.5851-6-boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> 2018-02-12 11:44 ` Vignesh R 2018-02-12 11:44 ` Vignesh R [not found] ` <933bd372-8b75-183f-0b03-563cabbbcc68-l0cyMroinI0@public.gmane.org> 2018-02-12 12:32 ` Boris Brezillon 2018-02-12 12:32 ` Boris Brezillon 2018-06-11 6:25 ` Yogesh Narayan Gaur 2018-06-11 6:25 ` Yogesh Narayan Gaur 2018-06-11 7:35 ` Boris Brezillon 2018-06-11 7:35 ` Boris Brezillon 2018-02-05 23:21 ` [RFC PATCH 6/6] spi: Get rid of the spi_flash_read() API Boris Brezillon 2018-02-05 23:21 ` Boris Brezillon [not found] ` <20180205232120.5851-7-boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> 2018-02-16 10:21 ` Vignesh R 2018-02-16 10:21 ` Vignesh R [not found] ` <674d7b22-a3ac-e812-04db-aa0acb1671b0-l0cyMroinI0@public.gmane.org> 2018-02-16 10:24 ` Boris Brezillon 2018-02-16 10:24 ` Boris Brezillon 2018-02-19 16:25 ` [RFC PATCH 0/6] spi: Extend the framework to generically support memory devices Mark Brown 2018-02-19 16:51 ` Boris Brezillon 2018-03-04 21:40 ` Cyrille Pitchen 2018-03-04 21:40 ` Cyrille Pitchen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=67e61203-a2e9-853c-6cda-7226499611c2@ti.com \ --to=vigneshr-l0cymroini0@public.gmane.org \ --cc=boris.brezillon-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \ --cc=boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \ --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=cyrille.pitchen-yU5RGvR974pGWvitb5QawA@public.gmane.org \ --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \ --cc=frieder.schrempf-wPoT/lNZgHizQB+pC5nmwQ@public.gmane.org \ --cc=kdasu.kdev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=peterpansjtu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=rafal-g1n6cQUeyibVItvQsEIGlw@public.gmane.org \ --cc=richard-/L3Ra7n9ekc@public.gmane.org \ --cc=yogeshnarayan.gaur-3arQi8VN3Tc@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.