From: Andrew Davis <afd@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Daniel Tang <dt.tangr@gmail.com>,
Fabian Vogt <fabian@ritter-vogt.de>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 7/9] ARM: dts: nspire: Use MATRIX_KEY macro for linux,keymap
Date: Thu, 3 Nov 2022 11:29:49 -0500 [thread overview]
Message-ID: <67f9ce4b-1ed6-fc41-c133-1fbafb743830@ti.com> (raw)
In-Reply-To: <CAKdAkRTQ2bjQEn1HM=ZMHdC8Goyf1rUDNfMkNK3jMA2CR-t4eg@mail.gmail.com>
On 11/2/22 11:07 PM, Dmitry Torokhov wrote:
> Hi Andrew,
>
> On Tue, Nov 1, 2022 at 2:59 PM Andrew Davis <afd@ti.com> wrote:
>>
>> This looks better and allows us to see the row and column numbers
>> more easily. Switch to this macro here.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>> arch/arm/boot/dts/nspire-clp.dts | 90 ++++++++++++++++++++++++--------
>> arch/arm/boot/dts/nspire-cx.dts | 90 ++++++++++++++++++++++++--------
>> arch/arm/boot/dts/nspire-tp.dts | 90 ++++++++++++++++++++++++--------
>> 3 files changed, 204 insertions(+), 66 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/nspire-clp.dts b/arch/arm/boot/dts/nspire-clp.dts
>> index f52f38c615886..916ede0c2499c 100644
>> --- a/arch/arm/boot/dts/nspire-clp.dts
>> +++ b/arch/arm/boot/dts/nspire-clp.dts
>> @@ -6,32 +6,78 @@
>> */
>> /dts-v1/;
>>
>> +#include <dt-bindings/input/input.h>
>> +
>> /include/ "nspire-classic.dtsi"
>>
>> &keypad {
>> linux,keymap = <
>> - 0x0000001c 0x0001001c 0x00020039
>> - 0x0004002c 0x00050034 0x00060015
>> - 0x0007000b 0x0008002d 0x01000033
>> - 0x0101004e 0x01020011 0x01030004
>> - 0x0104002f 0x01050003 0x01060016
>> - 0x01070002 0x01080014 0x02000062
>> - 0x0201000c 0x0202001f 0x02030007
>> - 0x02040013 0x02050006 0x02060010
>> - 0x02070005 0x02080019 0x03000027
>> - 0x03010037 0x03020018 0x0303000a
>> - 0x03040031 0x03050009 0x03060032
>> - 0x03070008 0x03080026 0x04000028
>> - 0x04010035 0x04020025 0x04040024
>> - 0x04060017 0x04080023 0x05000028
>> - 0x05020022 0x0503001b 0x05040021
>> - 0x0505001a 0x05060012 0x0507006f
>> - 0x05080020 0x0509002a 0x0601001c
>> - 0x0602002e 0x06030068 0x06040030
>> - 0x0605006d 0x0606001e 0x06070001
>> - 0x0608002b 0x0609000f 0x07000067
>> - 0x0702006a 0x0704006c 0x07060069
>> - 0x0707000e 0x0708001d 0x070a000d
>> + MATRIX_KEY(0, 0, 0x1c)
>> + MATRIX_KEY(0, 1, 0x1c)
>> + MATRIX_KEY(0, 2, 0x39)
>
> Can this also be switched over to using KEY_* macros to describe the
> keycodes emitted?
>
That's going to be done in a follow up patch. This change here was
done mechanically, but moving to KEY_* might need to be double
checked by hand since some of these do not seem to map how one
would expect to the function on the keypad.
Thanks,
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Davis <afd@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Daniel Tang <dt.tangr@gmail.com>,
Fabian Vogt <fabian@ritter-vogt.de>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 7/9] ARM: dts: nspire: Use MATRIX_KEY macro for linux,keymap
Date: Thu, 3 Nov 2022 11:29:49 -0500 [thread overview]
Message-ID: <67f9ce4b-1ed6-fc41-c133-1fbafb743830@ti.com> (raw)
In-Reply-To: <CAKdAkRTQ2bjQEn1HM=ZMHdC8Goyf1rUDNfMkNK3jMA2CR-t4eg@mail.gmail.com>
On 11/2/22 11:07 PM, Dmitry Torokhov wrote:
> Hi Andrew,
>
> On Tue, Nov 1, 2022 at 2:59 PM Andrew Davis <afd@ti.com> wrote:
>>
>> This looks better and allows us to see the row and column numbers
>> more easily. Switch to this macro here.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>> arch/arm/boot/dts/nspire-clp.dts | 90 ++++++++++++++++++++++++--------
>> arch/arm/boot/dts/nspire-cx.dts | 90 ++++++++++++++++++++++++--------
>> arch/arm/boot/dts/nspire-tp.dts | 90 ++++++++++++++++++++++++--------
>> 3 files changed, 204 insertions(+), 66 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/nspire-clp.dts b/arch/arm/boot/dts/nspire-clp.dts
>> index f52f38c615886..916ede0c2499c 100644
>> --- a/arch/arm/boot/dts/nspire-clp.dts
>> +++ b/arch/arm/boot/dts/nspire-clp.dts
>> @@ -6,32 +6,78 @@
>> */
>> /dts-v1/;
>>
>> +#include <dt-bindings/input/input.h>
>> +
>> /include/ "nspire-classic.dtsi"
>>
>> &keypad {
>> linux,keymap = <
>> - 0x0000001c 0x0001001c 0x00020039
>> - 0x0004002c 0x00050034 0x00060015
>> - 0x0007000b 0x0008002d 0x01000033
>> - 0x0101004e 0x01020011 0x01030004
>> - 0x0104002f 0x01050003 0x01060016
>> - 0x01070002 0x01080014 0x02000062
>> - 0x0201000c 0x0202001f 0x02030007
>> - 0x02040013 0x02050006 0x02060010
>> - 0x02070005 0x02080019 0x03000027
>> - 0x03010037 0x03020018 0x0303000a
>> - 0x03040031 0x03050009 0x03060032
>> - 0x03070008 0x03080026 0x04000028
>> - 0x04010035 0x04020025 0x04040024
>> - 0x04060017 0x04080023 0x05000028
>> - 0x05020022 0x0503001b 0x05040021
>> - 0x0505001a 0x05060012 0x0507006f
>> - 0x05080020 0x0509002a 0x0601001c
>> - 0x0602002e 0x06030068 0x06040030
>> - 0x0605006d 0x0606001e 0x06070001
>> - 0x0608002b 0x0609000f 0x07000067
>> - 0x0702006a 0x0704006c 0x07060069
>> - 0x0707000e 0x0708001d 0x070a000d
>> + MATRIX_KEY(0, 0, 0x1c)
>> + MATRIX_KEY(0, 1, 0x1c)
>> + MATRIX_KEY(0, 2, 0x39)
>
> Can this also be switched over to using KEY_* macros to describe the
> keycodes emitted?
>
That's going to be done in a follow up patch. This change here was
done mechanically, but moving to KEY_* might need to be double
checked by hand since some of these do not seem to map how one
would expect to the function on the keypad.
Thanks,
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-03 16:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 21:57 [PATCH v4 0/9] TI-Nspire cleanups Andrew Davis
2022-11-01 21:57 ` Andrew Davis
2022-11-01 21:57 ` [PATCH v4 1/9] dt-bindings: mfd: Add TI-Nspire misc registers Andrew Davis
2022-11-01 21:57 ` Andrew Davis
2022-11-02 17:35 ` Rob Herring
2022-11-02 17:35 ` Rob Herring
2022-11-02 19:05 ` Andrew Davis
2022-11-02 19:05 ` Andrew Davis
2022-11-02 21:26 ` Rob Herring
2022-11-02 21:26 ` Rob Herring
2022-11-03 1:13 ` Andrew Davis
2022-11-03 1:13 ` Andrew Davis
2022-11-01 21:57 ` [PATCH v4 2/9] ARM: dts: nspire: Use syscon-reboot to handle restart Andrew Davis
2022-11-01 21:57 ` Andrew Davis
2022-11-01 21:57 ` [PATCH v4 3/9] ARM: dts: nspire: Fix cpu node to conform with DT binding Andrew Davis
2022-11-01 21:57 ` Andrew Davis
2022-11-01 21:57 ` [PATCH v4 4/9] ARM: dts: nspire: Fix sram " Andrew Davis
2022-11-01 21:57 ` Andrew Davis
2022-11-01 21:58 ` [PATCH v4 5/9] ARM: dts: nspire: Fix vbus_reg " Andrew Davis
2022-11-01 21:58 ` Andrew Davis
2022-11-01 21:58 ` [PATCH v4 6/9] ARM: dts: nspire: Fix uart " Andrew Davis
2022-11-01 21:58 ` Andrew Davis
2022-11-01 21:58 ` [PATCH v4 7/9] ARM: dts: nspire: Use MATRIX_KEY macro for linux,keymap Andrew Davis
2022-11-01 21:58 ` Andrew Davis
2022-11-03 4:07 ` Dmitry Torokhov
2022-11-03 4:07 ` Dmitry Torokhov
2022-11-03 16:29 ` Andrew Davis [this message]
2022-11-03 16:29 ` Andrew Davis
2022-11-01 21:58 ` [PATCH v4 8/9] ARM: nspire: Use syscon-reboot to handle restart Andrew Davis
2022-11-01 21:58 ` Andrew Davis
2022-11-01 21:58 ` [PATCH v4 9/9] ARM: nspire: Remove unused header file mmio.h Andrew Davis
2022-11-01 21:58 ` Andrew Davis
2022-11-02 12:42 ` [PATCH v4 0/9] TI-Nspire cleanups Arnd Bergmann
2022-11-02 12:42 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67f9ce4b-1ed6-fc41-c133-1fbafb743830@ti.com \
--to=afd@ti.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dt.tangr@gmail.com \
--cc=fabian@ritter-vogt.de \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.