All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: linux-kernel@vger.kernel.org
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org, Joe Perches <joe@perches.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Subject: [PATCH 1/3] mtd: lpddr: Fix bad logic in print_drs_error
Date: Mon, 27 Apr 2020 14:02:22 -0500	[thread overview]
Message-ID: <68edaa1aa3c8b4ddecad2f093404c4693d1e2a17.1588013366.git.gustavo@embeddedor.com> (raw)
In-Reply-To: <cover.1588013366.git.gustavo@embeddedor.com>

Update logic for broken test. Use a more common logging style.

It appears the logic in this function is broken for the
consecutive tests of

        if (prog_status & 0x3)
                ...
        else if (prog_status & 0x2)
                ...
        else (prog_status & 0x1)
                ...

Likely the first test should be

        if ((prog_status & 0x3) == 0x3)

Found by inspection of include files using printk.

Fixes: eb3db27507f7 ("[MTD] LPDDR PFOW definition")
Cc: stable@vger.kernel.org
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 include/linux/mtd/pfow.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mtd/pfow.h b/include/linux/mtd/pfow.h
index 122f3439e1af..c65d7a3be3c6 100644
--- a/include/linux/mtd/pfow.h
+++ b/include/linux/mtd/pfow.h
@@ -128,7 +128,7 @@ static inline void print_drs_error(unsigned dsr)
 
 	if (!(dsr & DSR_AVAILABLE))
 		printk(KERN_NOTICE"DSR.15: (0) Device not Available\n");
-	if (prog_status & 0x03)
+	if ((prog_status & 0x03) == 0x03)
 		printk(KERN_NOTICE"DSR.9,8: (11) Attempt to program invalid "
 						"half with 41h command\n");
 	else if (prog_status & 0x02)
-- 
2.26.0


WARNING: multiple messages have this Message-ID (diff)
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: linux-kernel@vger.kernel.org
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Joe Perches <joe@perches.com>
Subject: [PATCH 1/3] mtd: lpddr: Fix bad logic in print_drs_error
Date: Mon, 27 Apr 2020 14:02:22 -0500	[thread overview]
Message-ID: <68edaa1aa3c8b4ddecad2f093404c4693d1e2a17.1588013366.git.gustavo@embeddedor.com> (raw)
In-Reply-To: <cover.1588013366.git.gustavo@embeddedor.com>

Update logic for broken test. Use a more common logging style.

It appears the logic in this function is broken for the
consecutive tests of

        if (prog_status & 0x3)
                ...
        else if (prog_status & 0x2)
                ...
        else (prog_status & 0x1)
                ...

Likely the first test should be

        if ((prog_status & 0x3) == 0x3)

Found by inspection of include files using printk.

Fixes: eb3db27507f7 ("[MTD] LPDDR PFOW definition")
Cc: stable@vger.kernel.org
Reported-by: Joe Perches <joe@perches.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 include/linux/mtd/pfow.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mtd/pfow.h b/include/linux/mtd/pfow.h
index 122f3439e1af..c65d7a3be3c6 100644
--- a/include/linux/mtd/pfow.h
+++ b/include/linux/mtd/pfow.h
@@ -128,7 +128,7 @@ static inline void print_drs_error(unsigned dsr)
 
 	if (!(dsr & DSR_AVAILABLE))
 		printk(KERN_NOTICE"DSR.15: (0) Device not Available\n");
-	if (prog_status & 0x03)
+	if ((prog_status & 0x03) == 0x03)
 		printk(KERN_NOTICE"DSR.9,8: (11) Attempt to program invalid "
 						"half with 41h command\n");
 	else if (prog_status & 0x02)
-- 
2.26.0


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-04-27 18:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 19:00 [PATCH 0/3] mtd: lpddr: Fix bad logic bug in print_drs_error Gustavo A. R. Silva
2020-04-27 19:00 ` Gustavo A. R. Silva
2020-04-27 19:02 ` Gustavo A. R. Silva [this message]
2020-04-27 19:02   ` [PATCH 1/3] mtd: lpddr: Fix bad logic " Gustavo A. R. Silva
2020-04-27 19:03 ` [PATCH 2/3] mtd: lpddr: Replace printk with pr_notice Gustavo A. R. Silva
2020-04-27 19:03   ` Gustavo A. R. Silva
2020-04-27 19:01   ` Joe Perches
2020-04-27 19:01     ` Joe Perches
2020-04-27 19:10     ` Gustavo A. R. Silva
2020-04-27 19:10       ` Gustavo A. R. Silva
2020-04-27 19:15       ` Joe Perches
2020-04-27 19:15         ` Joe Perches
2020-04-27 19:21         ` Miquel Raynal
2020-04-27 19:21           ` Miquel Raynal
2020-04-27 19:15       ` Miquel Raynal
2020-04-27 19:15         ` Miquel Raynal
2020-04-27 19:04 ` [PATCH 3/3] mtd: lpddr: Move function print_drs_error to lpddr_cmds.c Gustavo A. R. Silva
2020-04-27 19:04   ` Gustavo A. R. Silva
2020-04-27 19:03   ` Joe Perches
2020-04-27 19:03     ` Joe Perches
2020-04-27 19:11     ` Gustavo A. R. Silva
2020-04-27 19:11       ` Gustavo A. R. Silva
2020-08-11 23:47 ` [PATCH 0/3] mtd: lpddr: Fix bad logic bug in print_drs_error Joe Perches
2020-08-11 23:47   ` Joe Perches
2020-08-12  7:23   ` Miquel Raynal
2020-08-12  7:23     ` Miquel Raynal
2020-08-12 15:00     ` Gustavo A. R. Silva
2020-08-12 15:00       ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68edaa1aa3c8b4ddecad2f093404c4693d1e2a17.1588013366.git.gustavo@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.