From: Joe Perches <joe@perches.com> To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>, linux-kernel@vger.kernel.org Cc: Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, linux-mtd@lists.infradead.org Subject: Re: [PATCH 3/3] mtd: lpddr: Move function print_drs_error to lpddr_cmds.c Date: Mon, 27 Apr 2020 12:03:30 -0700 [thread overview] Message-ID: <ce8be38d71da0a9020a42359152dad7ee217d18c.camel@perches.com> (raw) In-Reply-To: <5cc0d2e83e971693d974235608c8d96fe94c849d.1588013366.git.gustavo@embeddedor.com> On Mon, 2020-04-27 at 14:04 -0500, Gustavo A. R. Silva wrote: > Function print_drs_error is only used in drivers/mtd/lpddr/lpddr_cmds.c > so, better to move it there. [] > diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c [] > @@ -94,6 +94,39 @@ struct mtd_info *lpddr_cmdset(struct map_info *map) > } > EXPORT_SYMBOL(lpddr_cmdset); > > +static inline void print_drs_error(unsigned int dsr) There's no need for inline as it's used once.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>, linux-kernel@vger.kernel.org Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, Vignesh Raghavendra <vigneshr@ti.com>, Miquel Raynal <miquel.raynal@bootlin.com> Subject: Re: [PATCH 3/3] mtd: lpddr: Move function print_drs_error to lpddr_cmds.c Date: Mon, 27 Apr 2020 12:03:30 -0700 [thread overview] Message-ID: <ce8be38d71da0a9020a42359152dad7ee217d18c.camel@perches.com> (raw) In-Reply-To: <5cc0d2e83e971693d974235608c8d96fe94c849d.1588013366.git.gustavo@embeddedor.com> On Mon, 2020-04-27 at 14:04 -0500, Gustavo A. R. Silva wrote: > Function print_drs_error is only used in drivers/mtd/lpddr/lpddr_cmds.c > so, better to move it there. [] > diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c [] > @@ -94,6 +94,39 @@ struct mtd_info *lpddr_cmdset(struct map_info *map) > } > EXPORT_SYMBOL(lpddr_cmdset); > > +static inline void print_drs_error(unsigned int dsr) There's no need for inline as it's used once. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-04-27 19:03 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-27 19:00 [PATCH 0/3] mtd: lpddr: Fix bad logic bug in print_drs_error Gustavo A. R. Silva 2020-04-27 19:00 ` Gustavo A. R. Silva 2020-04-27 19:02 ` [PATCH 1/3] mtd: lpddr: Fix bad logic " Gustavo A. R. Silva 2020-04-27 19:02 ` Gustavo A. R. Silva 2020-04-27 19:03 ` [PATCH 2/3] mtd: lpddr: Replace printk with pr_notice Gustavo A. R. Silva 2020-04-27 19:03 ` Gustavo A. R. Silva 2020-04-27 19:01 ` Joe Perches 2020-04-27 19:01 ` Joe Perches 2020-04-27 19:10 ` Gustavo A. R. Silva 2020-04-27 19:10 ` Gustavo A. R. Silva 2020-04-27 19:15 ` Joe Perches 2020-04-27 19:15 ` Joe Perches 2020-04-27 19:21 ` Miquel Raynal 2020-04-27 19:21 ` Miquel Raynal 2020-04-27 19:15 ` Miquel Raynal 2020-04-27 19:15 ` Miquel Raynal 2020-04-27 19:04 ` [PATCH 3/3] mtd: lpddr: Move function print_drs_error to lpddr_cmds.c Gustavo A. R. Silva 2020-04-27 19:04 ` Gustavo A. R. Silva 2020-04-27 19:03 ` Joe Perches [this message] 2020-04-27 19:03 ` Joe Perches 2020-04-27 19:11 ` Gustavo A. R. Silva 2020-04-27 19:11 ` Gustavo A. R. Silva 2020-08-11 23:47 ` [PATCH 0/3] mtd: lpddr: Fix bad logic bug in print_drs_error Joe Perches 2020-08-11 23:47 ` Joe Perches 2020-08-12 7:23 ` Miquel Raynal 2020-08-12 7:23 ` Miquel Raynal 2020-08-12 15:00 ` Gustavo A. R. Silva 2020-08-12 15:00 ` Gustavo A. R. Silva
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ce8be38d71da0a9020a42359152dad7ee217d18c.camel@perches.com \ --to=joe@perches.com \ --cc=gustavo@embeddedor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.