All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nicolas Saenz Julienne <nsaenzju@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Minchan Kim <minchan@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Juri Lelli <juri.lelli@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Phil Elwell <phil@raspberrypi.com>,
	regressions@lists.linux.dev
Subject: Re: vchiq: Performance regression since 5.18-rc1
Date: Mon, 30 May 2022 11:54:10 +0200	[thread overview]
Message-ID: <69590289-58ef-d32b-0459-36fa00627605@i2se.com> (raw)
In-Reply-To: <Yo41ggMvkI1B9TeM@fuller.cnet>

Hi Marcelo,
hi Sebastian,

Am 25.05.22 um 15:56 schrieb Marcelo Tosatti:
> On Mon, May 23, 2022 at 09:09:07AM +0200, Sebastian Andrzej Siewior wrote:
>> On 2022-05-22 01:22:00 [+0200], Stefan Wahren wrote:
>>> Hi,
>> Hi,
>>
>>> while testing the staging/vc04_services/interface/vchiq_arm driver with my
>>> Raspberry Pi 3 B+ (multi_v7_defconfig) i noticed a huge performance
>>> regression since [ff042f4a9b050895a42cae893cc01fa2ca81b95c] mm:
>>> lru_cache_disable: replace work queue synchronization with synchronize_rcu
>>>
>>> Usually i run "vchiq_test -f 1" to see the driver is still working [1].
>> What about
>> 	https://lore.kernel.org/all/YmrWK%2FKoU1zrAxPI@fuller.cnet/
>>
>> Sebastian
> Stefan,
>
> Can you please try the patch above ?

this patch fixes the regression. Great

Best regards

>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Marcelo Tosatti <mtosatti@redhat.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Nicolas Saenz Julienne <nsaenzju@redhat.com>,
	Borislav Petkov <bp@alien8.de>, Minchan Kim <minchan@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	Juri Lelli <juri.lelli@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Phil Elwell <phil@raspberrypi.com>,
	regressions@lists.linux.dev
Subject: Re: vchiq: Performance regression since 5.18-rc1
Date: Mon, 30 May 2022 11:54:10 +0200	[thread overview]
Message-ID: <69590289-58ef-d32b-0459-36fa00627605@i2se.com> (raw)
In-Reply-To: <Yo41ggMvkI1B9TeM@fuller.cnet>

Hi Marcelo,
hi Sebastian,

Am 25.05.22 um 15:56 schrieb Marcelo Tosatti:
> On Mon, May 23, 2022 at 09:09:07AM +0200, Sebastian Andrzej Siewior wrote:
>> On 2022-05-22 01:22:00 [+0200], Stefan Wahren wrote:
>>> Hi,
>> Hi,
>>
>>> while testing the staging/vc04_services/interface/vchiq_arm driver with my
>>> Raspberry Pi 3 B+ (multi_v7_defconfig) i noticed a huge performance
>>> regression since [ff042f4a9b050895a42cae893cc01fa2ca81b95c] mm:
>>> lru_cache_disable: replace work queue synchronization with synchronize_rcu
>>>
>>> Usually i run "vchiq_test -f 1" to see the driver is still working [1].
>> What about
>> 	https://lore.kernel.org/all/YmrWK%2FKoU1zrAxPI@fuller.cnet/
>>
>> Sebastian
> Stefan,
>
> Can you please try the patch above ?

this patch fixes the regression. Great

Best regards

>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-05-30  9:54 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21 23:22 vchiq: Performance regression since 5.18-rc1 Stefan Wahren
2022-05-21 23:22 ` Stefan Wahren
2022-05-21 23:46 ` Paul E. McKenney
2022-05-21 23:46   ` Paul E. McKenney
2022-05-22 15:11   ` Stefan Wahren
2022-05-22 15:11     ` Stefan Wahren
2022-05-23  4:48     ` Paul E. McKenney
2022-05-23  4:48       ` Paul E. McKenney
2022-05-23  6:19       ` Stefan Wahren
2022-05-23  6:19         ` Stefan Wahren
2022-05-23  9:29         ` Phil Elwell
2022-05-23  9:29           ` Phil Elwell
2022-05-23 10:48           ` Stefan Wahren
2022-05-23 10:48             ` Stefan Wahren
2022-05-23 11:01             ` Phil Elwell
2022-05-23 11:01               ` Phil Elwell
2022-05-23 11:15               ` Stefan Wahren
2022-05-23 11:15                 ` Stefan Wahren
2022-05-23 11:22                 ` Phil Elwell
2022-05-23 11:22                   ` Phil Elwell
2022-05-23  7:09 ` Sebastian Andrzej Siewior
2022-05-23  7:09   ` Sebastian Andrzej Siewior
2022-05-25 13:56   ` Marcelo Tosatti
2022-05-25 13:56     ` Marcelo Tosatti
2022-05-25 14:07     ` Stefan Wahren
2022-05-25 14:07       ` Stefan Wahren
2022-05-25 14:26       ` Sebastian Andrzej Siewior
2022-05-25 14:26         ` Sebastian Andrzej Siewior
2022-05-25 15:02         ` Paul E. McKenney
2022-05-25 15:02           ` Paul E. McKenney
2022-05-25 15:37       ` Marcelo Tosatti
2022-05-25 15:37         ` Marcelo Tosatti
2022-05-29 22:47         ` Stefan Wahren
2022-05-29 22:47           ` Stefan Wahren
2022-05-30  9:54     ` Stefan Wahren [this message]
2022-05-30  9:54       ` Stefan Wahren
2022-06-01 21:02       ` Stefan Wahren
2022-05-23  9:28 ` Thorsten Leemhuis
2022-05-23  9:28   ` Thorsten Leemhuis
2022-07-04  9:48   ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69590289-58ef-d32b-0459-36fa00627605@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=bp@alien8.de \
    --cc=juri.lelli@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=minchan@kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=nsaenzju@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=phil@raspberrypi.com \
    --cc=regressions@lists.linux.dev \
    --cc=tglx@linutronix.de \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.