Re: [PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static

Re: [PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static

[Marek Vasut]

On 1/10/19 3:07 PM, Wei Yongjun wrote:
> Fixes the following sparse warning:
> 
> drivers/gpio/gpio-pca953x.c:292:28: warning:
>  symbol 'pca953x_i2c_regmap' was not declared. Should it be static?
> 
> Fixes: 49427232764d ("gpio: pca953x: Perform basic regmap conversion")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Nice, thanks.
Reviewed-by: Marek Vasut <marex@denx.de>

For future reference, how did you run sparse to detect this ?

> ---
>  drivers/gpio/gpio-pca953x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 83617fd..0dc9641 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -289,7 +289,7 @@ static bool pca953x_volatile_register(struct device *dev, unsigned int reg)
>  	return pca953x_check_register(chip, reg, bank);
>  }
>  
> -const struct regmap_config pca953x_i2c_regmap = {
> +static const struct regmap_config pca953x_i2c_regmap = {
>  	.reg_bits = 8,
>  	.val_bits = 8,
> 
> 
> 


-- 
Best regards,
Marek Vasut

[PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static

[Wei Yongjun]

Fixes the following sparse warning:

drivers/gpio/gpio-pca953x.c:292:28: warning:
 symbol 'pca953x_i2c_regmap' was not declared. Should it be static?

Fixes: 49427232764d ("gpio: pca953x: Perform basic regmap conversion")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/gpio/gpio-pca953x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 83617fd..0dc9641 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -289,7 +289,7 @@ static bool pca953x_volatile_register(struct device *dev, unsigned int reg)
 	return pca953x_check_register(chip, reg, bank);
 }
 
-const struct regmap_config pca953x_i2c_regmap = {
+static const struct regmap_config pca953x_i2c_regmap = {
 	.reg_bits = 8,
 	.val_bits = 8,

RE: [PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static

[weiyongjun (A)]

PiBGcm9tOiBNYXJlayBWYXN1dCBbbWFpbHRvOm1hcmVrLnZhc3V0QGdtYWlsLmNvbV0NCj4gU2Vu
dDogVGh1cnNkYXksIEphbnVhcnkgMTAsIDIwMTkgMTA6MDcgUE0NCj4gVG86IHdlaXlvbmdqdW4g
KEEpIDx3ZWl5b25nanVuMUBodWF3ZWkuY29tPjsgTGludXMgV2FsbGVpag0KPiA8bGludXMud2Fs
bGVpakBsaW5hcm8ub3JnPjsgQmFydG9zeiBHb2xhc3pld3NraQ0KPiA8YmdvbGFzemV3c2tpQGJh
eWxpYnJlLmNvbT4NCj4gQ2M6IGxpbnV4LWdwaW9Admdlci5rZXJuZWwub3JnOyBrZXJuZWwtamFu
aXRvcnNAdmdlci5rZXJuZWwub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggLW5leHRdIGdwaW86
IHBjYTk1M3g6IE1ha2Ugc3ltYm9sDQo+ICdwY2E5NTN4X2kyY19yZWdtYXAnIHN0YXRpYw0KPiAN
Cj4gT24gMS8xMC8xOSAzOjA3IFBNLCBXZWkgWW9uZ2p1biB3cm90ZToNCj4gPiBGaXhlcyB0aGUg
Zm9sbG93aW5nIHNwYXJzZSB3YXJuaW5nOg0KPiA+DQo+ID4gZHJpdmVycy9ncGlvL2dwaW8tcGNh
OTUzeC5jOjI5MjoyODogd2FybmluZzoNCj4gPiAgc3ltYm9sICdwY2E5NTN4X2kyY19yZWdtYXAn
IHdhcyBub3QgZGVjbGFyZWQuIFNob3VsZCBpdCBiZSBzdGF0aWM/DQo+ID4NCj4gPiBGaXhlczog
NDk0MjcyMzI3NjRkICgiZ3BpbzogcGNhOTUzeDogUGVyZm9ybSBiYXNpYyByZWdtYXAgY29udmVy
c2lvbiIpDQo+ID4gU2lnbmVkLW9mZi1ieTogV2VpIFlvbmdqdW4gPHdlaXlvbmdqdW4xQGh1YXdl
aS5jb20+DQo+IA0KPiBOaWNlLCB0aGFua3MuDQo+IFJldmlld2VkLWJ5OiBNYXJlayBWYXN1dCA8
bWFyZXhAZGVueC5kZT4NCj4gDQo+IEZvciBmdXR1cmUgcmVmZXJlbmNlLCBob3cgZGlkIHlvdSBy
dW4gc3BhcnNlIHRvIGRldGVjdCB0aGlzID8NCg0KDQpJIGhhdmUgYSBzY3JpcHQgd2hpY2ggcnVu
IHNwYXJzZSBldmVyeWRheSBvbiBlYWNoIGNoYW5nZWQgZmlsZQ0Kb2YgbGludXgtbmV4dC5naXQg
dHJlZS4gU28gbW9zdCBvZiB0aGlzIGlzc3VlcyBjYW4gYmUgZGV0ZWN0ZWQuDQoNCj4gDQo+ID4g
LS0tDQo+ID4gIGRyaXZlcnMvZ3Bpby9ncGlvLXBjYTk1M3guYyB8IDIgKy0NCj4gPiAgMSBmaWxl
IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+ID4NCj4gPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncGlvL2dwaW8tcGNhOTUzeC5jIGIvZHJpdmVycy9ncGlvL2dwaW8tcGNh
OTUzeC5jDQo+ID4gaW5kZXggODM2MTdmZC4uMGRjOTY0MSAxMDA2NDQNCj4gPiAtLS0gYS9kcml2
ZXJzL2dwaW8vZ3Bpby1wY2E5NTN4LmMNCj4gPiArKysgYi9kcml2ZXJzL2dwaW8vZ3Bpby1wY2E5
NTN4LmMNCj4gPiBAQCAtMjg5LDcgKzI4OSw3IEBAIHN0YXRpYyBib29sIHBjYTk1M3hfdm9sYXRp
bGVfcmVnaXN0ZXIoc3RydWN0IGRldmljZQ0KPiAqZGV2LCB1bnNpZ25lZCBpbnQgcmVnKQ0KPiA+
ICAJcmV0dXJuIHBjYTk1M3hfY2hlY2tfcmVnaXN0ZXIoY2hpcCwgcmVnLCBiYW5rKTsNCj4gPiAg
fQ0KPiA+DQo+ID4gLWNvbnN0IHN0cnVjdCByZWdtYXBfY29uZmlnIHBjYTk1M3hfaTJjX3JlZ21h
cCA9IHsNCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCByZWdtYXBfY29uZmlnIHBjYTk1M3hfaTJj
X3JlZ21hcCA9IHsNCj4gPiAgCS5yZWdfYml0cyA9IDgsDQo+ID4gIAkudmFsX2JpdHMgPSA4LA0K
PiA+DQo+ID4NCj4gPg0KPiANCj4gDQo+IC0tDQo+IEJlc3QgcmVnYXJkcywNCj4gTWFyZWsgVmFz
dXQNCg=

Re: [PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static

[Marek Vasut]

On 1/11/19 2:50 AM, weiyongjun (A) wrote:
>> From: Marek Vasut [mailto:marek.vasut@gmail.com]
>> Sent: Thursday, January 10, 2019 10:07 PM
>> To: weiyongjun (A) <weiyongjun1@huawei.com>; Linus Walleij
>> <linus.walleij@linaro.org>; Bartosz Golaszewski
>> <bgolaszewski@baylibre.com>
>> Cc: linux-gpio@vger.kernel.org; kernel-janitors@vger.kernel.org
>> Subject: Re: [PATCH -next] gpio: pca953x: Make symbol
>> 'pca953x_i2c_regmap' static
>>
>> On 1/10/19 3:07 PM, Wei Yongjun wrote:
>>> Fixes the following sparse warning:
>>>
>>> drivers/gpio/gpio-pca953x.c:292:28: warning:
>>>  symbol 'pca953x_i2c_regmap' was not declared. Should it be static?
>>>
>>> Fixes: 49427232764d ("gpio: pca953x: Perform basic regmap conversion")
>>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>>
>> Nice, thanks.
>> Reviewed-by: Marek Vasut <marex@denx.de>
>>
>> For future reference, how did you run sparse to detect this ?
> 
> 
> I have a script which run sparse everyday on each changed file
> of linux-next.git tree. So most of this issues can be detected.

Can you share that script ? I'm sure others can benefit from that too.

-- 
Best regards,
Marek Vasut

RE: [PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static

[weiyongjun (A)]

PiA+Pg0KPiA+PiBPbiAxLzEwLzE5IDM6MDcgUE0sIFdlaSBZb25nanVuIHdyb3RlOg0KPiA+Pj4g
Rml4ZXMgdGhlIGZvbGxvd2luZyBzcGFyc2Ugd2FybmluZzoNCj4gPj4+DQo+ID4+PiBkcml2ZXJz
L2dwaW8vZ3Bpby1wY2E5NTN4LmM6MjkyOjI4OiB3YXJuaW5nOg0KPiA+Pj4gIHN5bWJvbCAncGNh
OTUzeF9pMmNfcmVnbWFwJyB3YXMgbm90IGRlY2xhcmVkLiBTaG91bGQgaXQgYmUgc3RhdGljPw0K
PiA+Pj4NCj4gPj4+IEZpeGVzOiA0OTQyNzIzMjc2NGQgKCJncGlvOiBwY2E5NTN4OiBQZXJmb3Jt
IGJhc2ljIHJlZ21hcCBjb252ZXJzaW9uIikNCj4gPj4+IFNpZ25lZC1vZmYtYnk6IFdlaSBZb25n
anVuIDx3ZWl5b25nanVuMUBodWF3ZWkuY29tPg0KPiA+Pg0KPiA+PiBOaWNlLCB0aGFua3MuDQo+
ID4+IFJldmlld2VkLWJ5OiBNYXJlayBWYXN1dCA8bWFyZXhAZGVueC5kZT4NCj4gPj4NCj4gPj4g
Rm9yIGZ1dHVyZSByZWZlcmVuY2UsIGhvdyBkaWQgeW91IHJ1biBzcGFyc2UgdG8gZGV0ZWN0IHRo
aXMgPw0KPiA+DQo+ID4NCj4gPiBJIGhhdmUgYSBzY3JpcHQgd2hpY2ggcnVuIHNwYXJzZSBldmVy
eWRheSBvbiBlYWNoIGNoYW5nZWQgZmlsZQ0KPiA+IG9mIGxpbnV4LW5leHQuZ2l0IHRyZWUuIFNv
IG1vc3Qgb2YgdGhpcyBpc3N1ZXMgY2FuIGJlIGRldGVjdGVkLg0KPiANCj4gQ2FuIHlvdSBzaGFy
ZSB0aGF0IHNjcmlwdCA/IEknbSBzdXJlIG90aGVycyBjYW4gYmVuZWZpdCBmcm9tIHRoYXQgdG9v
Lg0KDQpTdXJlLCB0aGUgc2NyaXB0IGV4aXN0cyBpbiBteSBnaXRodWIsIGFzIGEgcGFydCBvZiBv
dXIgYXV0b21hdGVkIHBhdGNoIHN5c3RlbS4NCmh0dHBzOi8vZ2l0aHViLmNvbS93ZWl5ai9kcGF0
Y2gtZGV2ZWwvYmxvYi9tYXN0ZXIvZHBhdGNoL2NvcmUvY2hlY2tzcGFyc2UucHkNCg0KV2UgYXJl
IGNvbnNpZGVyaW5nIG1ha2luZyBpdCBhcyBhIHB1YmxpYyBzeXN0ZW0sIGJ1dCBzdGlsbCBub3Qg
cmVhZHkuDQoNCj4gDQo+IC0tDQo+IEJlc3QgcmVnYXJkcywNCj4gTWFyZWsgVmFzdXQNCg=

Re: [PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static

[Linus Walleij]

On Thu, Jan 10, 2019 at 3:01 PM Wei Yongjun <weiyongjun1@huawei.com> wrote:

> Fixes the following sparse warning:
>
> drivers/gpio/gpio-pca953x.c:292:28: warning:
>  symbol 'pca953x_i2c_regmap' was not declared. Should it be static?
>
> Fixes: 49427232764d ("gpio: pca953x: Perform basic regmap conversion")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Patch applied for fixes with Marek's ACK, awesome sparsing!

Yours,
Linus Walleij

Re: [PATCH -next] gpio: pca953x: Make symbol 'pca953x_i2c_regmap' static

[Marek Vasut]

On 1/11/19 6:45 AM, weiyongjun (A) wrote:
>>>>
>>>> On 1/10/19 3:07 PM, Wei Yongjun wrote:
>>>>> Fixes the following sparse warning:
>>>>>
>>>>> drivers/gpio/gpio-pca953x.c:292:28: warning:
>>>>>  symbol 'pca953x_i2c_regmap' was not declared. Should it be static?
>>>>>
>>>>> Fixes: 49427232764d ("gpio: pca953x: Perform basic regmap conversion")
>>>>> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
>>>>
>>>> Nice, thanks.
>>>> Reviewed-by: Marek Vasut <marex@denx.de>
>>>>
>>>> For future reference, how did you run sparse to detect this ?
>>>
>>>
>>> I have a script which run sparse everyday on each changed file
>>> of linux-next.git tree. So most of this issues can be detected.
>>
>> Can you share that script ? I'm sure others can benefit from that too.
> 
> Sure, the script exists in my github, as a part of our automated patch system.
> https://github.com/weiyj/dpatch-devel/blob/master/dpatch/core/checksparse.py
> 
> We are considering making it as a public system, but still not ready.

Fantastic, thanks!

-- 
Best regards,
Marek Vasut