* [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw
@ 2018-04-12 23:55 Juro Bystricky
2018-04-13 12:50 ` Burton, Ross
0 siblings, 1 reply; 5+ messages in thread
From: Juro Bystricky @ 2018-04-12 23:55 UTC (permalink / raw)
To: yocto; +Cc: jurobystricky, alistair.francis
The commit "qemu: Bump to version 2.11.0" in oe-core broke the
build of qemu for mingw, due to using "socketpair", which is
not supported by mingw. "socketpair" is used in a local patch,
not in the qemu upstream code. The original local patch had
conditional code to exclude "socketpair" for _WIN32, but the
modified patch for qemu 2.11.0 removed this.
The fix is to simply remove the offending patch.
Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
---
recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
1 file changed, 4 insertions(+)
create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
diff --git a/recipes-devtools/qemu/qemu_2.11.%.bbappend b/recipes-devtools/qemu/qemu_2.11.%.bbappend
new file mode 100644
index 0000000..764b500
--- /dev/null
+++ b/recipes-devtools/qemu/qemu_2.11.%.bbappend
@@ -0,0 +1,4 @@
+
+
+SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
+
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw
2018-04-12 23:55 [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw Juro Bystricky
@ 2018-04-13 12:50 ` Burton, Ross
2018-04-13 14:46 ` Bystricky, Juro
0 siblings, 1 reply; 5+ messages in thread
From: Burton, Ross @ 2018-04-13 12:50 UTC (permalink / raw)
To: Juro Bystricky; +Cc: Yocto-mailing-list, Juro Bystricky, Alistair Francis
Is it feasible to fix the original patch?
Ross
On 13 April 2018 at 00:55, Juro Bystricky <juro.bystricky@intel.com> wrote:
> The commit "qemu: Bump to version 2.11.0" in oe-core broke the
> build of qemu for mingw, due to using "socketpair", which is
> not supported by mingw. "socketpair" is used in a local patch,
> not in the qemu upstream code. The original local patch had
> conditional code to exclude "socketpair" for _WIN32, but the
> modified patch for qemu 2.11.0 removed this.
>
> The fix is to simply remove the offending patch.
>
> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
> ---
> recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
> 1 file changed, 4 insertions(+)
> create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
>
> diff --git a/recipes-devtools/qemu/qemu_2.11.%.bbappend b/recipes-devtools/qemu/qemu_2.11.%.bbappend
> new file mode 100644
> index 0000000..764b500
> --- /dev/null
> +++ b/recipes-devtools/qemu/qemu_2.11.%.bbappend
> @@ -0,0 +1,4 @@
> +
> +
> +SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw
2018-04-13 12:50 ` Burton, Ross
@ 2018-04-13 14:46 ` Bystricky, Juro
2018-04-13 15:19 ` Burton, Ross
0 siblings, 1 reply; 5+ messages in thread
From: Bystricky, Juro @ 2018-04-13 14:46 UTC (permalink / raw)
To: Burton, Ross; +Cc: Yocto-mailing-list, Juro Bystricky, Alistair Francis
yes, I've done it before:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=sumo&id=bc112b8368eb3842ccb2430fdf17e736ea39a742
I'll do it gain. Hopefully it will last longer this time.
________________________________________
From: Burton, Ross [ross.burton@intel.com]
Sent: Friday, April 13, 2018 5:50 AM
To: Bystricky, Juro
Cc: Yocto-mailing-list; Juro Bystricky; Alistair Francis
Subject: Re: [yocto] [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw
Is it feasible to fix the original patch?
Ross
On 13 April 2018 at 00:55, Juro Bystricky <juro.bystricky@intel.com> wrote:
> The commit "qemu: Bump to version 2.11.0" in oe-core broke the
> build of qemu for mingw, due to using "socketpair", which is
> not supported by mingw. "socketpair" is used in a local patch,
> not in the qemu upstream code. The original local patch had
> conditional code to exclude "socketpair" for _WIN32, but the
> modified patch for qemu 2.11.0 removed this.
>
> The fix is to simply remove the offending patch.
>
> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
> ---
> recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
> 1 file changed, 4 insertions(+)
> create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
>
> diff --git a/recipes-devtools/qemu/qemu_2.11.%.bbappend b/recipes-devtools/qemu/qemu_2.11.%.bbappend
> new file mode 100644
> index 0000000..764b500
> --- /dev/null
> +++ b/recipes-devtools/qemu/qemu_2.11.%.bbappend
> @@ -0,0 +1,4 @@
> +
> +
> +SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
> +
> --
> 2.7.4
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw
2018-04-13 14:46 ` Bystricky, Juro
@ 2018-04-13 15:19 ` Burton, Ross
2018-04-13 15:24 ` Alistair Francis
0 siblings, 1 reply; 5+ messages in thread
From: Burton, Ross @ 2018-04-13 15:19 UTC (permalink / raw)
To: Bystricky, Juro; +Cc: Yocto-mailing-list, Juro Bystricky, Alistair Francis
Thanks Juro. I'll remember to keep an eye out for the ifdefs disappearing.
Ross
On 13 April 2018 at 15:46, Bystricky, Juro <juro.bystricky@intel.com> wrote:
> yes, I've done it before:
> https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=sumo&id=bc112b8368eb3842ccb2430fdf17e736ea39a742
> I'll do it gain. Hopefully it will last longer this time.
>
>
> ________________________________________
> From: Burton, Ross [ross.burton@intel.com]
> Sent: Friday, April 13, 2018 5:50 AM
> To: Bystricky, Juro
> Cc: Yocto-mailing-list; Juro Bystricky; Alistair Francis
> Subject: Re: [yocto] [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw
>
> Is it feasible to fix the original patch?
>
> Ross
>
> On 13 April 2018 at 00:55, Juro Bystricky <juro.bystricky@intel.com> wrote:
>> The commit "qemu: Bump to version 2.11.0" in oe-core broke the
>> build of qemu for mingw, due to using "socketpair", which is
>> not supported by mingw. "socketpair" is used in a local patch,
>> not in the qemu upstream code. The original local patch had
>> conditional code to exclude "socketpair" for _WIN32, but the
>> modified patch for qemu 2.11.0 removed this.
>>
>> The fix is to simply remove the offending patch.
>>
>> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
>> ---
>> recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
>> 1 file changed, 4 insertions(+)
>> create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
>>
>> diff --git a/recipes-devtools/qemu/qemu_2.11.%.bbappend b/recipes-devtools/qemu/qemu_2.11.%.bbappend
>> new file mode 100644
>> index 0000000..764b500
>> --- /dev/null
>> +++ b/recipes-devtools/qemu/qemu_2.11.%.bbappend
>> @@ -0,0 +1,4 @@
>> +
>> +
>> +SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
>> +
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw
2018-04-13 15:19 ` Burton, Ross
@ 2018-04-13 15:24 ` Alistair Francis
0 siblings, 0 replies; 5+ messages in thread
From: Alistair Francis @ 2018-04-13 15:24 UTC (permalink / raw)
To: Burton, Ross; +Cc: Yocto-mailing-list, Juro Bystricky, Alistair Francis
On Fri, Apr 13, 2018 at 8:19 AM, Burton, Ross <ross.burton@intel.com> wrote:
> Thanks Juro. I'll remember to keep an eye out for the ifdefs disappearing.
Maybe add some comments in the patch to ensure whoever is working with
it knows why they are there.
Alistair
>
> Ross
>
> On 13 April 2018 at 15:46, Bystricky, Juro <juro.bystricky@intel.com> wrote:
>> yes, I've done it before:
>> https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?h=sumo&id=bc112b8368eb3842ccb2430fdf17e736ea39a742
>> I'll do it gain. Hopefully it will last longer this time.
>>
>>
>> ________________________________________
>> From: Burton, Ross [ross.burton@intel.com]
>> Sent: Friday, April 13, 2018 5:50 AM
>> To: Bystricky, Juro
>> Cc: Yocto-mailing-list; Juro Bystricky; Alistair Francis
>> Subject: Re: [yocto] [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw
>>
>> Is it feasible to fix the original patch?
>>
>> Ross
>>
>> On 13 April 2018 at 00:55, Juro Bystricky <juro.bystricky@intel.com> wrote:
>>> The commit "qemu: Bump to version 2.11.0" in oe-core broke the
>>> build of qemu for mingw, due to using "socketpair", which is
>>> not supported by mingw. "socketpair" is used in a local patch,
>>> not in the qemu upstream code. The original local patch had
>>> conditional code to exclude "socketpair" for _WIN32, but the
>>> modified patch for qemu 2.11.0 removed this.
>>>
>>> The fix is to simply remove the offending patch.
>>>
>>> Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
>>> ---
>>> recipes-devtools/qemu/qemu_2.11.%.bbappend | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>> create mode 100644 recipes-devtools/qemu/qemu_2.11.%.bbappend
>>>
>>> diff --git a/recipes-devtools/qemu/qemu_2.11.%.bbappend b/recipes-devtools/qemu/qemu_2.11.%.bbappend
>>> new file mode 100644
>>> index 0000000..764b500
>>> --- /dev/null
>>> +++ b/recipes-devtools/qemu/qemu_2.11.%.bbappend
>>> @@ -0,0 +1,4 @@
>>> +
>>> +
>>> +SRC_URI_remove_mingw32 = "file://chardev-connect-socket-to-a-spawned-command.patch"
>>> +
>>> --
>>> 2.7.4
>>>
>>> --
>>> _______________________________________________
>>> yocto mailing list
>>> yocto@yoctoproject.org
>>> https://lists.yoctoproject.org/listinfo/yocto
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-04-13 15:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 23:55 [meta-mingw][PATCH] qemu_2.11.%.bbappend: fix broken qemu build for mingw Juro Bystricky
2018-04-13 12:50 ` Burton, Ross
2018-04-13 14:46 ` Bystricky, Juro
2018-04-13 15:19 ` Burton, Ross
2018-04-13 15:24 ` Alistair Francis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.