All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: Johan Hovold <johan@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
	Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
	Michal Michalik <michal.michalik@intel.com>,
	netdev@vger.kernel.org, richardcochran@gmail.com,
	Gurucharan <gurucharanx.g@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS
Date: Fri, 2 Sep 2022 09:42:54 +0200	[thread overview]
Message-ID: <6a426c91-5c03-a328-d341-ef98bc3d8115@kernel.org> (raw)
In-Reply-To: <YxBU5AV4jfqaExaW@hovoldconsulting.com>

On 01. 09. 22, 8:44, Johan Hovold wrote:
> Looks like this was merged in 5.18 with 43113ff73453 ("ice: add TTY for
> GNSS module for E810T device") without any input from people familiar
> with tty either.

FWIW doesn't it crash in ice_gnss_tty_write() on parallel tty opens due to:
          tty->driver_data = NULL;
in ice_gnss_tty_open()?

There are many "interesting" constructs in the driver...

thanks,
-- 
js
suse labs


  reply	other threads:[~2022-09-02  7:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29 22:00 [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2022-08-29 (ice) Tony Nguyen
2022-08-29 22:00 ` [PATCH net 1/3] ice: Fix DMA mappings leak Tony Nguyen
2022-08-29 22:00 ` [PATCH net 2/3] ice: use bitmap_free instead of devm_kfree Tony Nguyen
2022-08-29 22:00 ` [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS Tony Nguyen
2022-08-31 21:54   ` Jakub Kicinski
2022-08-31 23:36     ` Tony Nguyen
2022-09-01  5:46     ` Greg Kroah-Hartman
2022-09-01 20:18       ` Jakub Kicinski
2022-09-02 16:55         ` Tony Nguyen
2022-09-05 19:32       ` Michalik, Michal
2022-09-06  6:15         ` Greg Kroah-Hartman
2022-09-06 20:55           ` Michalik, Michal
2022-09-07  5:45             ` Greg Kroah-Hartman
2022-09-08 13:44               ` Michalik, Michal
2022-09-01  6:44     ` Johan Hovold
2022-09-02  7:42       ` Jiri Slaby [this message]
2022-09-02 10:47         ` Jiri Slaby
2022-09-05 19:47           ` Michalik, Michal
2022-09-05 19:41       ` Michalik, Michal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a426c91-5c03-a328-d341-ef98bc3d8115@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gurucharanx.g@intel.com \
    --cc=johan@kernel.org \
    --cc=kuba@kernel.org \
    --cc=michal.michalik@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.