All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michalik, Michal" <michal.michalik@intel.com>
To: Jiri Slaby <jirislaby@kernel.org>,
	Johan Hovold <johan@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"richardcochran@gmail.com" <richardcochran@gmail.com>,
	"G, GurucharanX" <gurucharanx.g@intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: RE: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS
Date: Mon, 5 Sep 2022 19:47:14 +0000	[thread overview]
Message-ID: <BN6PR11MB4177F222B679682F697E986EE37F9@BN6PR11MB4177.namprd11.prod.outlook.com> (raw)
In-Reply-To: <b32ef683-e09c-522b-ffa7-ea09628e81db@kernel.org>

Hi Jiri,

Agree with you, we will work on aligning to the GNSS subsystem if that would be
possible in our implementation according to Johan suggestion.

We will also make sure to make our code less "interesting", when comes to constructs.

Thanks a lot!

BR,
M^2

> -----Original Message-----
> From: Jiri Slaby <jirislaby@kernel.org> 
> Sent: Friday, September 2, 2022 12:47 PM
> To: Johan Hovold <johan@kernel.org>; Jakub Kicinski <kuba@kernel.org>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Cc: davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Michalik, Michal <michal.michalik@intel.com>; netdev@vger.kernel.org; richardcochran@gmail.com; G, GurucharanX <gurucharanx.g@intel.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Subject: Re: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS
> 
> On 02. 09. 22, 9:42, Jiri Slaby wrote:
> > On 01. 09. 22, 8:44, Johan Hovold wrote:
> >> Looks like this was merged in 5.18 with 43113ff73453 ("ice: add TTY for
> >> GNSS module for E810T device") without any input from people familiar
> >> with tty either.
> > 
> > FWIW doesn't it crash in ice_gnss_tty_write() on parallel tty opens due to:
> >           tty->driver_data = NULL;
> > in ice_gnss_tty_open()?
> 
> Oh, the driver checks for tty->driver_data in every operation (gee). So 
> at least that crash is mitigated. The userspace will "only" receive 
> EFAULT from time to time.
> 
> > There are many "interesting" constructs in the driver...
> 
> The checks belong among this "interesting" constructs too.
> 
> > thanks,-- 
> js
> suse labs
>

  reply	other threads:[~2022-09-05 19:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29 22:00 [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2022-08-29 (ice) Tony Nguyen
2022-08-29 22:00 ` [PATCH net 1/3] ice: Fix DMA mappings leak Tony Nguyen
2022-08-29 22:00 ` [PATCH net 2/3] ice: use bitmap_free instead of devm_kfree Tony Nguyen
2022-08-29 22:00 ` [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS Tony Nguyen
2022-08-31 21:54   ` Jakub Kicinski
2022-08-31 23:36     ` Tony Nguyen
2022-09-01  5:46     ` Greg Kroah-Hartman
2022-09-01 20:18       ` Jakub Kicinski
2022-09-02 16:55         ` Tony Nguyen
2022-09-05 19:32       ` Michalik, Michal
2022-09-06  6:15         ` Greg Kroah-Hartman
2022-09-06 20:55           ` Michalik, Michal
2022-09-07  5:45             ` Greg Kroah-Hartman
2022-09-08 13:44               ` Michalik, Michal
2022-09-01  6:44     ` Johan Hovold
2022-09-02  7:42       ` Jiri Slaby
2022-09-02 10:47         ` Jiri Slaby
2022-09-05 19:47           ` Michalik, Michal [this message]
2022-09-05 19:41       ` Michalik, Michal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN6PR11MB4177F222B679682F697E986EE37F9@BN6PR11MB4177.namprd11.prod.outlook.com \
    --to=michal.michalik@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=gurucharanx.g@intel.com \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.