From: "Michalik, Michal" <michal.michalik@intel.com>
To: Johan Hovold <johan@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"richardcochran@gmail.com" <richardcochran@gmail.com>,
"G, GurucharanX" <gurucharanx.g@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Subject: RE: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS
Date: Mon, 5 Sep 2022 19:41:34 +0000 [thread overview]
Message-ID: <BN6PR11MB4177480C375591CF5BA8E812E37F9@BN6PR11MB4177.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YxBU5AV4jfqaExaW@hovoldconsulting.com>
Hello Johan,
Much thanks for valuable feedback. We really appreciate that you have pointed that
problem so we can fix it as soon as possible.
BR,
M^2
> -----Original Message-----
> From: Johan Hovold <johan@kernel.org>
> Sent: Thursday, September 1, 2022 8:45 AM
> To: Jakub Kicinski <kuba@kernel.org>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Cc: davem@davemloft.net; pabeni@redhat.com; edumazet@google.com; Michalik, Michal <michal.michalik@intel.com>; netdev@vger.kernel.org; richardcochran@gmail.com; G, GurucharanX <gurucharanx.g@intel.com>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>; Jiri Slaby <jirislaby@kernel.org>
> Subject: Re: [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS
>
> On Wed, Aug 31, 2022 at 02:54:39PM -0700, Jakub Kicinski wrote:
> > On Mon, 29 Aug 2022 15:00:49 -0700 Tony Nguyen wrote:
> > > From: Michal Michalik <michal.michalik@intel.com>
> > >
> > > Some third party tools (ex. ubxtool) try to change GNSS TTY parameters
> > > (ex. speed). While being optional implementation, without set_termios
> > > handle this operation fails and prevents those third party tools from
> > > working. TTY interface in ice driver is virtual and doesn't need any change
> > > on set_termios, so is left empty. Add this mock to support all Linux TTY
> > > APIs.
> > >
> > > Fixes: 43113ff73453 ("ice: add TTY for GNSS module for E810T device")
> > > Signed-off-by: Michal Michalik <michal.michalik@intel.com>
> > > Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
> > > Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> >
> > Please CC GNSS and TTY maintainers on the patches relating to
> > the TTY/GNSS channel going forward.
> >
> > CC: Greg, Jiri, Johan
> >
> > We'll pull in a day or two if there are no objections.
>
> Hmm. Why was this implemented as a roll-your-own tty driver instead of
> using the GNSS subsystem, which also would have allowed for a smaller
> (and likely less buggy) implementation?
>
> Looks like this was merged in 5.18 with 43113ff73453 ("ice: add TTY for
> GNSS module for E810T device") without any input from people familiar
> with tty either.
>
Original author is off, but to be completely honest with you - we most likely
did not noticed the possiblity to align to GNSS subsystem. That is a mistake -
we are working on understanding if we can easily fix that. We will back you you
as soon as came up with the solution.
> Johan
>
prev parent reply other threads:[~2022-09-05 19:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 22:00 [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2022-08-29 (ice) Tony Nguyen
2022-08-29 22:00 ` [PATCH net 1/3] ice: Fix DMA mappings leak Tony Nguyen
2022-08-29 22:00 ` [PATCH net 2/3] ice: use bitmap_free instead of devm_kfree Tony Nguyen
2022-08-29 22:00 ` [PATCH net 3/3] ice: Add set_termios tty operations handle to GNSS Tony Nguyen
2022-08-31 21:54 ` Jakub Kicinski
2022-08-31 23:36 ` Tony Nguyen
2022-09-01 5:46 ` Greg Kroah-Hartman
2022-09-01 20:18 ` Jakub Kicinski
2022-09-02 16:55 ` Tony Nguyen
2022-09-05 19:32 ` Michalik, Michal
2022-09-06 6:15 ` Greg Kroah-Hartman
2022-09-06 20:55 ` Michalik, Michal
2022-09-07 5:45 ` Greg Kroah-Hartman
2022-09-08 13:44 ` Michalik, Michal
2022-09-01 6:44 ` Johan Hovold
2022-09-02 7:42 ` Jiri Slaby
2022-09-02 10:47 ` Jiri Slaby
2022-09-05 19:47 ` Michalik, Michal
2022-09-05 19:41 ` Michalik, Michal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB4177480C375591CF5BA8E812E37F9@BN6PR11MB4177.namprd11.prod.outlook.com \
--to=michal.michalik@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gurucharanx.g@intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.