* [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb
@ 2018-10-15 20:44 Douglas Anderson
2018-10-16 20:53 ` Stephen Boyd
2018-10-17 7:34 ` msavaliy
0 siblings, 2 replies; 4+ messages in thread
From: Douglas Anderson @ 2018-10-15 20:44 UTC (permalink / raw)
To: gregkh
Cc: msavaliy, linux-arm-msm, alokc, mka, evgreen, Douglas Anderson,
linux-kernel, linux-serial, Jiri Slaby
If you turn on CONFIG_KGDB then you'll get CONFIG_CONSOLE_POLL
selected.
If you have CONFIG_CONSOLE_POLL selected then the GENI serial driver
was setting RX_BYTES_PW to 1 for _all_ UART ports.
This doesn't seem like such a good idea. Let's only set RX_BYTES_PW
to 1 for the console port.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/tty/serial/qcom_geni_serial.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index d3b5261ee80a..9ee6ce725e43 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -89,9 +89,9 @@
#define MAX_LOOPBACK_CFG 3
#ifdef CONFIG_CONSOLE_POLL
-#define RX_BYTES_PW 1
+#define CONSOLE_RX_BYTES_PW 1
#else
-#define RX_BYTES_PW 4
+#define CONSOLE_RX_BYTES_PW 4
#endif
struct qcom_geni_serial_port {
@@ -853,11 +853,13 @@ static int qcom_geni_serial_port_setup(struct uart_port *uport)
unsigned int rxstale = DEFAULT_BITS_PER_CHAR * STALE_TIMEOUT;
u32 proto;
- if (uart_console(uport))
+ if (uart_console(uport)) {
port->tx_bytes_pw = 1;
- else
+ port->rx_bytes_pw = CONSOLE_RX_BYTES_PW;
+ } else {
port->tx_bytes_pw = 4;
- port->rx_bytes_pw = RX_BYTES_PW;
+ port->rx_bytes_pw = 4;
+ }
proto = geni_se_read_proto(&port->se);
if (proto != GENI_SE_UART) {
--
2.19.1.331.ge82ca0e54c-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb
2018-10-15 20:44 [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb Douglas Anderson
@ 2018-10-16 20:53 ` Stephen Boyd
2018-10-17 7:34 ` msavaliy
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2018-10-16 20:53 UTC (permalink / raw)
To: gregkh
Cc: msavaliy, linux-arm-msm, alokc, mka, evgreen, Douglas Anderson,
linux-kernel, linux-serial, Jiri Slaby
Quoting Douglas Anderson (2018-10-15 13:44:24)
> If you turn on CONFIG_KGDB then you'll get CONFIG_CONSOLE_POLL
> selected.
>
> If you have CONFIG_CONSOLE_POLL selected then the GENI serial driver
> was setting RX_BYTES_PW to 1 for _all_ UART ports.
>
> This doesn't seem like such a good idea. Let's only set RX_BYTES_PW
> to 1 for the console port.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb
@ 2018-10-16 20:53 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2018-10-16 20:53 UTC (permalink / raw)
To: Douglas Anderson, gregkh
Cc: msavaliy, linux-arm-msm, alokc, mka, evgreen, Douglas Anderson,
linux-kernel, linux-serial, Jiri Slaby
Quoting Douglas Anderson (2018-10-15 13:44:24)
> If you turn on CONFIG_KGDB then you'll get CONFIG_CONSOLE_POLL
> selected.
>
> If you have CONFIG_CONSOLE_POLL selected then the GENI serial driver
> was setting RX_BYTES_PW to 1 for _all_ UART ports.
>
> This doesn't seem like such a good idea. Let's only set RX_BYTES_PW
> to 1 for the console port.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb
2018-10-15 20:44 [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb Douglas Anderson
2018-10-16 20:53 ` Stephen Boyd
@ 2018-10-17 7:34 ` msavaliy
1 sibling, 0 replies; 4+ messages in thread
From: msavaliy @ 2018-10-17 7:34 UTC (permalink / raw)
To: Douglas Anderson
Cc: gregkh, linux-arm-msm, alokc, mka, evgreen, linux-kernel,
linux-serial, Jiri Slaby, linux-arm-msm-owner
On 2018-10-16 02:14, Douglas Anderson wrote:
> If you turn on CONFIG_KGDB then you'll get CONFIG_CONSOLE_POLL
> selected.
>
> If you have CONFIG_CONSOLE_POLL selected then the GENI serial driver
> was setting RX_BYTES_PW to 1 for _all_ UART ports.
>
> This doesn't seem like such a good idea. Let's only set RX_BYTES_PW
> to 1 for the console port.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> drivers/tty/serial/qcom_geni_serial.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
Good finding, Makes sense to keep changes this way for console only
port.
Reviewed-by: Mukesh Kumar Savaliya <msavaliy@codeaurora.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-17 7:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-15 20:44 [PATCH] tty: serial: qcom_geni_serial: Don't slow all ports just for kgdb Douglas Anderson
2018-10-16 20:53 ` Stephen Boyd
2018-10-16 20:53 ` Stephen Boyd
2018-10-17 7:34 ` msavaliy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.