Re: [PATCH 1/1] fix compilation error when add libgloss under DEPENDS in recipe

Re: [PATCH 1/1] fix compilation error when add libgloss under DEPENDS in recipe

[nagesh.shamnur]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

 Dear Group,
    When include newlib and libgloss under DEPENDS in custom recipe,
 then newlib compilation is successful however libgloss compilation
 fails since it is unable to find the needed include path under
 recipe-sysroot/usr/include. This patch is to fix this issue by
 including recipe-sysroot/usr/include while configuring libgloss.

 Regards,
 Nagesh

[-- Attachment #2: 0001-fix-compilation-error-for-libgloss.patch --]
[-- Type: text/x-patch, Size: 800 bytes --]

From 773a10fbc2858f2397abcf64c60e64384a92f25f Mon Sep 17 00:00:00 2001
From: Nagesh <nagesh.shamnur@huawei.com>
Date: Wed, 28 Jul 2021 13:09:50 +0530
Subject: [PATCH 1/1] fix compilation error when add libgloss under
DEPENDS in recipe

Signed-off-by: Nagesh <nagesh.shamnur@huawei.com>
---
 meta/recipes-core/newlib/newlib.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-core/newlib/newlib.inc b/meta/recipes-core/newlib/newlib.inc
index 0aba21fae7..edf4d1b52b 100644
--- a/meta/recipes-core/newlib/newlib.inc
+++ b/meta/recipes-core/newlib/newlib.inc
@@ -26,6 +26,7 @@ B = "${WORKDIR}/build"
 
 ## disable stdlib
 TARGET_CC_ARCH_append = " -nostdlib"
+CFLAGS_prepend = "-I${RECIPE_SYSROOT}/usr/include"
 
 EXTRA_OECONF = " \
                 --build=${BUILD_SYS}  \
-- 
2.25.1

Re: [OE-core] [PATCH 1/1] fix compilation error when add libgloss under DEPENDS in recipe

[Michael Opdenacker]

Hi Nagesh,

On 7/28/21 9:53 AM, nagesh shamnur wrote:
>  Dear Group,
>     When include newlib and libgloss under DEPENDS in custom recipe,
>  then newlib compilation is successful however libgloss compilation
>  fails since it is unable to find the needed include path under
>  recipe-sysroot/usr/include. This patch is to fix this issue by
>  including recipe-sysroot/usr/include while configuring libgloss.


Many thanks for your patch corresponding to the fix that you found for
your recent issue!

The patch looks good, but next time, it would be even better if you
could send it as an inline attachment (easiest to do with the "git
send-email"  command). This makes it easier for people to review your
patch and in particular directly quote parts of your patch and comment
or reply on specific lines.

I realize that the YP manual doesn't explain this requirement well. I'll
post an improvement to the corresponding section
(https://docs.yoctoproject.org/dev-manual/common-tasks.html#using-email-to-submit-a-patch).

Thanks again,
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH 1/1] fix compilation error when add libgloss under DEPENDS in recipe

[nagesh shamnur]

Thanks Michael for the feedback. Will surely keep that in mind and take care.

Cheers!
Nagesh.

On Wed, Jul 28, 2021 at 1:47 PM Michael Opdenacker
<michael.opdenacker@bootlin.com> wrote:
>
> Hi Nagesh,
>
> On 7/28/21 9:53 AM, nagesh shamnur wrote:
> >  Dear Group,
> >     When include newlib and libgloss under DEPENDS in custom recipe,
> >  then newlib compilation is successful however libgloss compilation
> >  fails since it is unable to find the needed include path under
> >  recipe-sysroot/usr/include. This patch is to fix this issue by
> >  including recipe-sysroot/usr/include while configuring libgloss.
>
>
> Many thanks for your patch corresponding to the fix that you found for
> your recent issue!
>
> The patch looks good, but next time, it would be even better if you
> could send it as an inline attachment (easiest to do with the "git
> send-email"  command). This makes it easier for people to review your
> patch and in particular directly quote parts of your patch and comment
> or reply on specific lines.
>
> I realize that the YP manual doesn't explain this requirement well. I'll
> post an improvement to the corresponding section
> (https://docs.yoctoproject.org/dev-manual/common-tasks.html#using-email-to-submit-a-patch).
>
> Thanks again,
> Michael.
>
> --
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>

Re: [OE-core] [PATCH 1/1] fix compilation error when add libgloss under DEPENDS in recipe

[Michael Opdenacker]

Hi Nagesh,

On 7/28/21 10:17 AM, Michael Opdenacker wrote:
> Hi Nagesh,
>
> On 7/28/21 9:53 AM, nagesh shamnur wrote:
>>  Dear Group,
>>     When include newlib and libgloss under DEPENDS in custom recipe,
>>  then newlib compilation is successful however libgloss compilation
>>  fails since it is unable to find the needed include path under
>>  recipe-sysroot/usr/include. This patch is to fix this issue by
>>  including recipe-sysroot/usr/include while configuring libgloss.
>
> Many thanks for your patch corresponding to the fix that you found for
> your recent issue!
>
> The patch looks good, but next time, it would be even better if you
> could send it as an inline attachment (easiest to do with the "git
> send-email"  command). This makes it easier for people to review your
> patch and in particular directly quote parts of your patch and comment
> or reply on specific lines.


I overlooked your first message, in which you tried to send your patch
as an inline attachment. Unfortunately, saving the e-mail and then
trying to apply it with "git am" didn't work. I guess that's why you
sent it as a regular attachment. You wouldn't have had this issue if you
had sent it through "git send-email".

To allow "git send-email"  to send messages, there are details on
https://docs.yoctoproject.org/dev-manual/common-tasks.html#using-email-to-submit-a-patch

Since you have a Gmail account, you can configure git send-email to
directly send e-mail through your account:
git config --global sendemail.smtpserver smtp.googlemail.com
git config --global sendemail.smtpserverport 587
git config --global sendemail.smtpencryption tls
git config --global sendemail.smtpuser jdoe@gmail.com
git config --global sendemail.smtppass xxx

I haven't tested this recently though. I hope this helps.

Cheers,
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com